Skip to content

Commit 02a27c9

Browse files
authored
Remove unused kernel diagnostic from io-uring-test (#287)
* This diagnostic is both unused and unreliable because uname may return kernel versions that semver cannot parse, such as '6.8.9-300.fc40.x86_64'.
1 parent 4d73b2a commit 02a27c9

File tree

3 files changed

+0
-27
lines changed

3 files changed

+0
-27
lines changed

Cargo.lock

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

io-uring-test/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ anyhow = "1"
1313
tempfile = "3"
1414
once_cell = "1"
1515
socket2 = "0.5"
16-
semver = "1.0.21"
1716

1817
[features]
1918
direct-syscall = [ "io-uring/direct-syscall" ]

io-uring-test/src/main.rs

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,11 @@ mod tests;
44

55
use io_uring::{cqueue, squeue, IoUring, Probe};
66
use std::cell::Cell;
7-
use std::ffi::CStr;
8-
use std::mem;
97

108
pub struct Test {
119
probe: Probe,
1210
target: Option<String>,
1311
count: Cell<usize>,
14-
kernel_version: semver::Version,
15-
}
16-
17-
impl Test {
18-
fn check_kernel_version(&self, min_version: &str) -> bool {
19-
self.kernel_version >= semver::Version::parse(min_version).unwrap()
20-
}
2112
}
2213

2314
fn main() -> anyhow::Result<()> {
@@ -72,16 +63,6 @@ fn test<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
7263
probe,
7364
target: std::env::args().nth(1),
7465
count: Cell::new(0),
75-
kernel_version: {
76-
let mut uname: libc::utsname = unsafe { mem::zeroed() };
77-
unsafe {
78-
assert!(libc::uname(&mut uname) >= 0);
79-
}
80-
81-
let version = unsafe { CStr::from_ptr(uname.release.as_ptr()) };
82-
let version = version.to_str().unwrap();
83-
semver::Version::parse(version).unwrap()
84-
},
8566
};
8667

8768
tests::queue::test_nop(&mut ring, &test)?;

0 commit comments

Comments
 (0)