Skip to content

Commit 92bef36

Browse files
authored
Fix ci test for new kernel (#271)
* Fix tcp_recv_multi test * Fix fmt
1 parent 801d885 commit 92bef36

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

io-uring-test/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ fn test<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
148148
tests::net::test_tcp_buffer_select_recvmsg(&mut ring, &test)?;
149149
tests::net::test_tcp_buffer_select_readv(&mut ring, &test)?;
150150
tests::net::test_tcp_recv_multi(&mut ring, &test)?;
151-
tests::net::test_shutdown(&mut ring, &test)?;
151+
tests::net::test_tcp_shutdown(&mut ring, &test)?;
152152
tests::net::test_socket(&mut ring, &test)?;
153153
tests::net::test_udp_recvmsg_multishot(&mut ring, &test)?;
154154
tests::net::test_udp_recvmsg_multishot_trunc(&mut ring, &test)?;

io-uring-test/src/tests/net.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use io_uring::types::Fd;
55
use io_uring::{cqueue, opcode, squeue, types, IoUring};
66
use once_cell::sync::OnceCell;
77
use std::convert::TryInto;
8-
use std::net::{TcpListener, TcpStream};
8+
use std::net::{Shutdown, TcpListener, TcpStream};
99
use std::os::fd::FromRawFd;
1010
use std::os::unix::io::AsRawFd;
1111
use std::{io, mem};
@@ -1120,6 +1120,7 @@ pub fn test_tcp_recv_multi<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
11201120

11211121
// write all 1024 + 256
11221122
send_stream.write_all(&input)?;
1123+
send_stream.shutdown(Shutdown::Write)?;
11231124

11241125
// multishot recv using a buf_group with 1024 length buffers
11251126
let recv_e = opcode::RecvMulti::new(recv_fd, 0xdead)
@@ -1146,16 +1147,16 @@ pub fn test_tcp_recv_multi<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
11461147
assert_eq!(cqes[1].result(), 256); // length 256
11471148
assert!(cqueue::more(cqes[1].flags()));
11481149
assert_eq!(cqueue::buffer_select(cqes[1].flags()), Some(1));
1149-
assert_eq!(&bufs[1024..(1024 + 256)], &input[1024..(1024 + 256)]);
1150+
assert_eq!(&bufs[1024..][..256], &input[1024..][..256]);
11501151

11511152
assert_eq!(cqes[2].user_data(), 0x22);
1152-
assert!(cqueue::more(cqes[1].flags()));
1153+
assert!(!cqueue::more(cqes[2].flags()));
11531154
assert_eq!(cqes[2].result(), -105); // No buffer space available
11541155

11551156
Ok(())
11561157
}
11571158

1158-
pub fn test_shutdown<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
1159+
pub fn test_tcp_shutdown<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
11591160
ring: &mut IoUring<S, C>,
11601161
test: &Test,
11611162
) -> anyhow::Result<()> {
@@ -1165,7 +1166,7 @@ pub fn test_shutdown<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
11651166
test.probe.is_supported(opcode::Shutdown::CODE);
11661167
);
11671168

1168-
println!("test shutdown");
1169+
println!("test tcp_shutdown");
11691170

11701171
const SHUT_WR: i32 = 1;
11711172

@@ -1176,7 +1177,7 @@ pub fn test_shutdown<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
11761177

11771178
unsafe {
11781179
ring.submission()
1179-
.push(&shutdown_e.build().into())
1180+
.push(&shutdown_e.build().user_data(0x28).into())
11801181
.expect("queue is full");
11811182
}
11821183

@@ -1185,6 +1186,7 @@ pub fn test_shutdown<S: squeue::EntryMarker, C: cqueue::EntryMarker>(
11851186
let cqes: Vec<cqueue::Entry> = ring.completion().map(Into::into).collect();
11861187

11871188
assert_eq!(cqes.len(), 1);
1189+
assert_eq!(cqes[0].user_data(), 0x28);
11881190
assert_eq!(cqes[0].result(), 0);
11891191

11901192
let text = b"C'est la vie";

0 commit comments

Comments
 (0)