Fix nightly compiler complaints about size_of #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
|
I don't think the test failures are related BTW. It says |
|
Yeah, I just checked by reverting the commit so the PR is blank and it's still broken. Very strange. |
|
I believe this is something that changed with github actions but I don't have the energy to deal with it. |
|
Yeah fair enough. They might have blocked io_uring syscalls? Anyway, I'm fine leaving this here until someone finds a fix (don't have time to look into it either). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the prelude now includes size_of, the nightly compiler really doesn't like it when you fully qualify size_of.