Skip to content

Commit a502d1b

Browse files
authored
loom: remove StaticAtomicU64 (#7902)
1 parent 0273e45 commit a502d1b

File tree

5 files changed

+13
-15
lines changed

5 files changed

+13
-15
lines changed

tokio/src/loom/mocked.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,6 @@ pub(crate) mod sync {
5858
}
5959

6060
pub(crate) use loom::sync::*;
61-
62-
pub(crate) mod atomic {
63-
pub(crate) use loom::sync::atomic::*;
64-
65-
// TODO: implement a loom version
66-
pub(crate) type StaticAtomicU64 = std::sync::atomic::AtomicU64;
67-
}
6861
}
6962

7063
pub(crate) mod rand {

tokio/src/loom/std/atomic_u64.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ cfg_not_has_atomic_u64! {
1616
mod imp;
1717
}
1818

19-
pub(crate) use imp::{AtomicU64, StaticAtomicU64};
19+
pub(crate) use imp::AtomicU64;

tokio/src/loom/std/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ pub(crate) mod sync {
7171
pub(crate) mod atomic {
7272
pub(crate) use crate::loom::std::atomic_u16::AtomicU16;
7373
pub(crate) use crate::loom::std::atomic_u32::AtomicU32;
74-
pub(crate) use crate::loom::std::atomic_u64::{AtomicU64, StaticAtomicU64};
74+
pub(crate) use crate::loom::std::atomic_u64::AtomicU64;
7575
pub(crate) use crate::loom::std::atomic_usize::AtomicUsize;
7676

7777
pub(crate) use std::sync::atomic::{fence, AtomicBool, AtomicPtr, AtomicU8, Ordering};

tokio/src/runtime/task/id.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,15 @@ impl fmt::Display for Id {
6767

6868
impl Id {
6969
pub(crate) fn next() -> Self {
70-
use crate::loom::sync::atomic::Ordering::Relaxed;
71-
use crate::loom::sync::atomic::StaticAtomicU64;
70+
use crate::loom::sync::atomic::{AtomicU64, Ordering::Relaxed};
7271

7372
#[cfg(all(test, loom))]
7473
crate::loom::lazy_static! {
75-
static ref NEXT_ID: StaticAtomicU64 = StaticAtomicU64::new(1);
74+
static ref NEXT_ID: AtomicU64 = AtomicU64::new(1);
7675
}
7776

7877
#[cfg(not(all(test, loom)))]
79-
static NEXT_ID: StaticAtomicU64 = StaticAtomicU64::new(1);
78+
static NEXT_ID: AtomicU64 = AtomicU64::new(1);
8079

8180
loop {
8281
let id = NEXT_ID.fetch_add(1, Relaxed);

tokio/src/runtime/thread_id.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,15 @@ pub(crate) struct ThreadId(NonZeroU64);
55

66
impl ThreadId {
77
pub(crate) fn next() -> Self {
8-
use crate::loom::sync::atomic::{Ordering::Relaxed, StaticAtomicU64};
8+
use crate::loom::sync::atomic::{AtomicU64, Ordering::Relaxed};
99

10-
static NEXT_ID: StaticAtomicU64 = StaticAtomicU64::new(0);
10+
#[cfg(all(test, loom))]
11+
crate::loom::lazy_static! {
12+
static ref NEXT_ID: AtomicU64 = AtomicU64::new(0);
13+
}
14+
15+
#[cfg(not(all(test, loom)))]
16+
static NEXT_ID: AtomicU64 = AtomicU64::new(0);
1117

1218
let mut last = NEXT_ID.load(Relaxed);
1319
loop {

0 commit comments

Comments
 (0)