Skip to content

Commit da292df

Browse files
martin-gADD-SP
authored andcommitted
sync: close the broadcast::Sender in broadcast::Sender::new() (#7629)
(cherry picked from commit 6d1ae62)
1 parent b9feac8 commit da292df

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

tokio/src/sync/broadcast.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ impl<T> Sender<T> {
522522
tail: Mutex::new(Tail {
523523
pos: 0,
524524
rx_cnt: receiver_count,
525-
closed: false,
525+
closed: receiver_count == 0,
526526
waiters: LinkedList::new(),
527527
}),
528528
num_tx: AtomicUsize::new(1),

tokio/tests/sync_broadcast.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -656,3 +656,15 @@ async fn receiver_recv_is_cooperative() {
656656
_ = tokio::task::yield_now() => {},
657657
}
658658
}
659+
660+
#[tokio::test]
661+
async fn broadcast_sender_new_must_be_closed() {
662+
let capacity = 1;
663+
let tx: broadcast::Sender<()> = broadcast::Sender::new(capacity);
664+
665+
tx.send(()).unwrap_err();
666+
667+
let _rx = tx.subscribe();
668+
669+
tx.send(()).unwrap();
670+
}

0 commit comments

Comments
 (0)