Skip to content

Commit 68a77dc

Browse files
authored
fix!(layer): change old semantic convention (#209)
## Motivation #115 - the semantic convention name has changed. ## Solution `otel.status_message` has been renamed to `otel.status_description`. If code uses the old field it will be sent as a normal key-value attribute without special meaning.
1 parent da83e89 commit 68a77dc

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/layer.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ use web_time::Instant;
2323
const SPAN_NAME_FIELD: &str = "otel.name";
2424
const SPAN_KIND_FIELD: &str = "otel.kind";
2525
const SPAN_STATUS_CODE_FIELD: &str = "otel.status_code";
26-
const SPAN_STATUS_MESSAGE_FIELD: &str = "otel.status_message";
26+
const SPAN_STATUS_DESCRIPTION_FIELD: &str = "otel.status_description";
2727

2828
const EVENT_EXCEPTION_NAME: &str = "exception";
2929
const FIELD_EXCEPTION_MESSAGE: &str = "exception.message";
@@ -442,7 +442,7 @@ impl field::Visit for SpanAttributeVisitor<'_> {
442442
SPAN_NAME_FIELD => self.span_builder_updates.name = Some(value.to_string().into()),
443443
SPAN_KIND_FIELD => self.span_builder_updates.span_kind = str_to_span_kind(value),
444444
SPAN_STATUS_CODE_FIELD => self.span_builder_updates.status = Some(str_to_status(value)),
445-
SPAN_STATUS_MESSAGE_FIELD => {
445+
SPAN_STATUS_DESCRIPTION_FIELD => {
446446
self.span_builder_updates.status = Some(otel::Status::error(value.to_string()))
447447
}
448448
_ => self.record(KeyValue::new(field.name(), value.to_string())),
@@ -462,7 +462,7 @@ impl field::Visit for SpanAttributeVisitor<'_> {
462462
SPAN_STATUS_CODE_FIELD => {
463463
self.span_builder_updates.status = Some(str_to_status(&format!("{:?}", value)))
464464
}
465-
SPAN_STATUS_MESSAGE_FIELD => {
465+
SPAN_STATUS_DESCRIPTION_FIELD => {
466466
self.span_builder_updates.status = Some(otel::Status::error(format!("{:?}", value)))
467467
}
468468
_ => self.record(KeyValue::new(
@@ -1374,14 +1374,14 @@ mod tests {
13741374
}
13751375

13761376
#[test]
1377-
fn span_status_message() {
1377+
fn span_status_description() {
13781378
let tracer = TestTracer(Arc::new(Mutex::new(None)));
13791379
let subscriber = tracing_subscriber::registry().with(layer().with_tracer(tracer.clone()));
13801380

13811381
let message = "message";
13821382

13831383
tracing::subscriber::with_default(subscriber, || {
1384-
tracing::debug_span!("request", otel.status_message = message);
1384+
tracing::debug_span!("request", otel.status_description = message);
13851385
});
13861386

13871387
let recorded_status_message = tracer

0 commit comments

Comments
 (0)