From 25ef236713bc90124e3491be5eb0d7e7d1650cac Mon Sep 17 00:00:00 2001 From: Ibraheem Ahmed Date: Mon, 21 Jul 2025 12:44:51 -0400 Subject: [PATCH] avoid checking dispatcher settings twice in `tracing::enabled` --- tracing/src/lib.rs | 1 + tracing/src/macros.rs | 7 +------ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tracing/src/lib.rs b/tracing/src/lib.rs index 0ea4e165ac..d97b2e2de8 100644 --- a/tracing/src/lib.rs +++ b/tracing/src/lib.rs @@ -1009,6 +1009,7 @@ pub mod __macro_support { /// by the `tracing` macros, but it is not part of the stable versioned API. /// Breaking changes to this module may occur in small-numbered versions /// without warning. + #[inline] pub fn __is_enabled(meta: &Metadata<'static>, interest: Interest) -> bool { interest.is_always() || crate::dispatcher::get_default(|default| default.enabled(meta)) } diff --git a/tracing/src/macros.rs b/tracing/src/macros.rs index e3cf07c8c0..df0d2df6c6 100644 --- a/tracing/src/macros.rs +++ b/tracing/src/macros.rs @@ -1228,12 +1228,7 @@ macro_rules! enabled { fields: $($fields)* }; let interest = __CALLSITE.interest(); - if !interest.is_never() && $crate::__macro_support::__is_enabled(__CALLSITE.metadata(), interest) { - let meta = __CALLSITE.metadata(); - $crate::dispatcher::get_default(|current| current.enabled(meta)) - } else { - false - } + !interest.is_never() && $crate::__macro_support::__is_enabled(__CALLSITE.metadata(), interest) } else { false }