Thoughts on moving UniqueName to settings?

[schneidenbach]

Hey @tomasfabian, love your library here.

I'm using SqlTableDependencyProvider to listen for changes on a specific table using the UniqueScope lifetime scope. I noted that this specific scope is designed to persist between application restarts, so I started digging into how the subscription names itself and found the following line:

Joker/SqlTableDependency.Extensions/SqlTableDependencyWithReconnection.cs

Line 84 in 08b1567

public virtual string UniqueName => Environment.MachineName;

In order to override this setting, I need to:

• inherit from SqlTableDependencyWithUniqueScope and override the UniqueName prop
• override CreateSqlTableDependency in SqlTableDependencyProvider and pass this SqlTableDependencyWithUniqueScope in instead

It's not a ton of friction, but I was curious to know how you felt about exposing the UniqueName property in SqlTableDependencySettings instead? If so, I'll issue a PR with that change.

[tomasfabian]

Hi Spencer, thank you for reaching me out and for your appreciation. Your suggestion sounds very reasonable to me, too. It would be great if you will Create a PR. It would be nice to do it without a breaking change. Do you already have a good name for this setting eg. SqlTableDependencySettings.Scope(Unique)Name? Regards, Tomas. po 12. 7. 2021 o 22:13 Spencer Schneidenbach ***@***.***> napísal(a):

…

Hey @tomasfabian <https://github.com/tomasfabian>, love your library here. I'm using SqlTableDependencyProvider to listen for changes on a specific table using the UniqueScope lifetime scope. I noted that this specific scope is designed to persist between application restarts, so I started digging into how the subscription names itself and found the following line: https://github.com/tomasfabian/Joker/blob/08b1567c66fde3e774f53ecd5c3d7f61c971251b/SqlTableDependency.Extensions/SqlTableDependencyWithReconnection.cs#L84 In order to override this setting, I need to: - inherit from SqlTableDependencyWithUniqueScope and override the UniqueName prop - override CreateSqlTableDependency in SqlTableDependencyProvider and pass this SqlTableDependencyWithUniqueScope in instead It's not a ton of friction, but I was curious to know how you felt about exposing the UniqueName property in SqlTableDependencySettings instead? If so, I'll issue a PR with that change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG63GRD7X7SRFRLI4UP6GDTXNEFZANCNFSM5AHREPDA> .

[tomasfabian]

hi @schneidenbach,
I pushed the requested feature (UniqueName to settings). Could you please review it?

Commit details

Thank you Tomas

[tomasfabian]

Hi @sergiu-enache, which LifetimeScope are you using?

  public enum LifetimeScope
  {
    ConnectionScope = 1,
    UniqueScope = 2,
    ApplicationScope = 3,
  }

[sergiu-enache]

@tomasfabian is UniqueScope, using OPs workaround I managed to make it work

[tomasfabian]

@sergiu-enache great! It should be configured in this way.

What does the OPs abbreviation mean, please?

[sergiu-enache]

sorry, too much reddit haha.. Original Poster

I think I used OnCreateSettings() correctly but no luck, still used Environment.MachineName in the end.

[sergiu-enache]

also thank you for this package, CreateBulkRecordChangesNotifier will solve my issue