Improved C++ Flow

Author: tomasmark79

application/src/Application.cpp

@@ -13,6 +13,8 @@ int main(int argc, char **argv) {
   using namespace dotnamecpp::logging;
   using namespace dotnamecpp::utils;
 
+  constexpr int runDurationSeconds = 5;
+
   try {
     // Parse command-line options
     cxxopts::Options options(appName, "DotName C++ Application");
@@ -42,35 +44,32 @@ int main(int argc, char **argv) {
                               .appPrefix = appName};
     auto logger = UtilsFactory::createLogger(LoggerType::Console, loggerConfig);
 
-    // Log application start
-    logger->infoStream() << appName << " running...";
+#if __cplusplus >= 202002L
+    // Available in C++20 and later
+    logger->infoWithLocation(appName + " started ...");
+#else
+    logger->infoStream() << appName << " started ...";
+#endif
 
-    // Initialize assets
     auto assetManager = UtilsFactory::createAssetManager(execPathResult.value(), appName);
-
     if (!assetManager->validate()) {
       logger->errorStream() << "Failed to validate assets: " << assetManager->getAssetsPath();
       return EXIT_FAILURE;
     }
 
-    logger->infoStream() << "Assets initialized: " << assetManager->getAssetsPath();
-
     // Initialize library
     auto library = std::make_unique<v1::DotNameLib>(logger, assetManager);
+    if (!library->isInitialized()) {
+      logger->errorStream() << "Library initialization failed";
+      return EXIT_FAILURE;
+    }
 
-#if __cplusplus >= 202002L
-    // Available in C++20 and later
-    logger->infoWithLocation("Library initialized successfully");
-#else
-    logger->infoStream() << "Library initialized successfully";
-#endif
-
-    if (!library->run(5)) {
+    if (!library->run(runDurationSeconds)) {
       logger->errorStream() << "Failed to run library";
       return EXIT_FAILURE;
     }
 
-    logger->infoStream() << appName << " shutting down";
+    logger->infoStream() << appName << " ... shutting down";
     return EXIT_SUCCESS;
 
   } catch (const std::exception &e) {

include/DotNameLib/DotNameLib.hpp

@@ -1,9 +1,9 @@
 #pragma once
 
-#include <DotNameLib/version.h> // first configuration will create this file
+#include <DotNameLib/version.h> // cmake configuration will generate this file
 #include <Utils/UtilsFactory.hpp>
+
 #include <atomic>
-#include <filesystem>
 #include <memory>
 #include <string>
 
@@ -28,29 +28,15 @@ namespace dotnamecpp::v1 {
     ~DotNameLib();
 
     /**
-     * @brief Copy construction is deleted
+     * @brief Copy and move operations are deleted
+     *
+     * This class manages unique resources
+     * and should not be copied or moved.
      */
     DotNameLib(const DotNameLib &other) = delete;
-
-    /**
-     * @brief Copy assignment is deleted
-     */
     DotNameLib &operator=(const DotNameLib &other) = delete;
-
-    /**
-     * @brief Move constructor
-     *
-     * @param other Object to move from
-     */
-    DotNameLib(DotNameLib &&other) noexcept;
-
-    /**
-     * @brief Move assignment operator
-     *
-     * @param other Object to move from
-     * @return Reference to this object
-     */
-    DotNameLib &operator=(DotNameLib &&other) noexcept;
+    DotNameLib(DotNameLib &&other) = delete;
+    DotNameLib &operator=(DotNameLib &&other) = delete;
 
     // ============================================================================
     // Main API
@@ -80,27 +66,26 @@ namespace dotnamecpp::v1 {
     // ============================================================================
 
     /**
-     * @brief Check if the library is properly initialized
+     * @brief Check if the library is initialized
      *
-     * @return true if initialized and ready to use
-     * @return false if initialization failed
+     * @return true
+     * @return false
      */
     [[nodiscard]]
     bool isInitialized() const noexcept;
 
     /**
-     * @brief Get the assets directory path
+     * @brief Get the Asset Manager object
      *
-     * @return const std::filesystem::path& Path to assets
+     * @return const std::shared_ptr<dotnamecpp::assets::IAssetManager>&
      */
     [[nodiscard]]
-    const std::filesystem::path &getAssetsPath() const noexcept;
+    const std::shared_ptr<dotnamecpp::assets::IAssetManager> &getAssetManager() const noexcept;
 
   private:
     const std::string libName_ = "DotNameLib v." DOTNAMELIB_VERSION;
     std::shared_ptr<dotnamecpp::logging::ILogger> logger_;
     std::shared_ptr<dotnamecpp::assets::IAssetManager> assetManager_;
-    std::filesystem::path assetsPath_;
     bool isInitialized_ = false;
     std::atomic<bool> shouldStop_{false};
   };

src/DotNameLib.cpp

@@ -14,11 +14,9 @@ namespace dotnamecpp::v1 {
       return;
     }
 
-    logger_->infoStream() << libName_ << " initialized ...";
+    // just an example of asset usage
     const auto logoPath = assetManager_->resolveAsset("DotNameCppLogo.svg");
-    if (assetManager_->assetExists("DotNameCppLogo.svg")) {
-      logger_->debugStream() << "Logo: " << logoPath << " found";
-    } else {
+    if (!assetManager_->assetExists("DotNameCppLogo.svg")) {
       logger_->warningStream() << "Logo not found: " << logoPath;
     }
 
@@ -29,51 +27,16 @@ namespace dotnamecpp::v1 {
     // └──────────────────────────────────────────────────────────────────┘
 
     isInitialized_ = true;
-    logger_->infoStream() << libName_ << " initialized successfully.";
+    logger_->infoStream() << libName_ << " initialized ...";
   }
 
   DotNameLib::~DotNameLib() {
     if (isInitialized_) {
-      // Ensure graceful shutdown
       stop();
-      logger_->infoStream() << libName_ << " destructed";
+      logger_->infoStream() << libName_ << " ... destructed";
     } else {
-      logger_->infoStream() << libName_ << " (not initialized) destructed";
-    }
-  }
-
-  DotNameLib::DotNameLib(DotNameLib &&other) noexcept
-      : logger_(std::move(other.logger_)), assetManager_(std::move(other.assetManager_)),
-        assetsPath_(std::move(other.assetsPath_)), isInitialized_(other.isInitialized_),
-        shouldStop_(other.shouldStop_.load()) {
-    other.isInitialized_ = false;
-    other.shouldStop_.store(false);
-    if (logger_) {
-      logger_->infoStream() << libName_ << " move constructed";
-    }
-  }
-
-  DotNameLib &DotNameLib::operator=(DotNameLib &&other) noexcept {
-    if (this != &other) {
-      // Stop current instance
-      if (isInitialized_) {
-        stop();
-      }
-
-      // Move all members
-      logger_ = std::move(other.logger_);
-      assetManager_ = std::move(other.assetManager_);
-      assetsPath_ = std::move(other.assetsPath_);
-      isInitialized_ = other.isInitialized_;
-      shouldStop_.store(other.shouldStop_.load());
-
-      other.isInitialized_ = false;
-      other.shouldStop_.store(false);
-      if (logger_) {
-        logger_->infoStream() << libName_ << " move assigned";
-      }
+      logger_->infoStream() << libName_ << " ... (not initialized) destructed";
     }
-    return *this;
   }
 
   bool DotNameLib::run(int durationSeconds) {
@@ -92,11 +55,9 @@ namespace dotnamecpp::v1 {
       // │ Example: Start services, process data, etc.                      │
       // └──────────────────────────────────────────────────────────────────┘
 
-      logger_->infoStream() << libName_ << " started successfully";
-
       // Run for specified duration
       if (durationSeconds > 0) {
-        logger_->infoStream() << "Running for " << durationSeconds << " seconds...";
+        logger_->infoStream() << "MOCK BUSINESS LOGIC running for " << durationSeconds << " seconds ...";
         for (int i = 0; i < durationSeconds && !shouldStop_.load(); ++i) {
           std::this_thread::sleep_for(std::chrono::seconds(1));
         }
@@ -106,7 +67,6 @@ namespace dotnamecpp::v1 {
         } else {
           logger_->infoStream() << libName_ << " finished after " << durationSeconds << " seconds";
         }
-        stop();
       } else {
         logger_->infoStream() << "Running indefinitely. Call stop() to terminate.";
         constexpr int pollIntervalMs = 100;
@@ -129,7 +89,7 @@ namespace dotnamecpp::v1 {
       return;
     }
 
-    logger_->infoStream() << "Stopping " << libName_ << "...";
+    logger_->infoStream() << "Stopping " << libName_ << " ...";
     shouldStop_.store(true);
 
     // ┌──────────────────────────────────────────────────────────────────┐
@@ -140,6 +100,9 @@ namespace dotnamecpp::v1 {
   }
 
   bool DotNameLib::isInitialized() const noexcept { return isInitialized_; }
-  const std::filesystem::path &DotNameLib::getAssetsPath() const noexcept { return assetsPath_; }
+  const std::shared_ptr<dotnamecpp::assets::IAssetManager> &
+      DotNameLib::getAssetManager() const noexcept {
+    return assetManager_;
+  }
 
 } // namespace dotnamecpp::v1