tests: adapt disk assessment check

fixes: cockpit-project#21728

Libblockdev changed how SmartFailing property is set. Now it is less
strict with when a disk is considered as failing.

storaged-project/libblockdev#1097

Author: tomasmatus

test/verify/check-storage-smart

@@ -17,6 +17,7 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with Cockpit; If not, see <https://www.gnu.org/licenses/>.
 
+from os import getenv
 from sys import stderr
 
 import storagelib
@@ -53,8 +54,10 @@ class TestStorageSmart(storagelib.StorageSmartCase):
             b.wait_in_text(self.card_desc("Device health (SMART)", "Self-test status"), status)
             if bad_sectors is not None:
                 b.wait_in_text(self.card_desc("Device health (SMART)", "Number of bad sectors"), bad_sectors)
+                b.wait_visible(self.card_desc("Device health (SMART)", "Number of bad sectors") + " .pf-m-warning")
             if failing_attrs is not None:
                 b.wait_in_text(self.card_desc("Device health (SMART)", "Attributes failing"), failing_attrs)
+                b.wait_visible(self.card_desc("Device health (SMART)", "Attributes failing") + " .pf-m-warning")
 
         m = self.machine
         b = self.browser
@@ -82,17 +85,27 @@ class TestStorageSmart(storagelib.StorageSmartCase):
         set_smart_dump("INTEL_SSDSA2MH080G1GC--045C8820", "/dev/sda")
         check_smart_info("Disk is OK", "2309 hours", "Interrupted")
 
-        # Aborted self test and has known bad sector
+        # latest libblockdev builds from copr have different behavior when assessing disk as failed
+        is_nightly_scenario = "daily" in getenv("TEST_SCENARIO", "")
+
+        # Aborted self test and has known bad sector (overall assessment is still OK)
         set_smart_dump("ST9160821AS--3.CLH", "/dev/sda")
-        check_smart_info("Disk is failing", "556 hours", "Aborted", bad_sectors="1")
+        if is_nightly_scenario:
+            check_smart_info("Disk is OK", "556 hours", "Aborted", bad_sectors="1")
+        else:
+            check_smart_info("Disk is failing", "556 hours", "Aborted", bad_sectors="1")
 
         # Multiple bad sectors
         set_smart_dump("Maxtor_96147H8--BAC51KJ0", "/dev/sda")
-        check_smart_info("Disk is failing", "2016 hours", "Successful", bad_sectors="71")
+        if is_nightly_scenario:
+            check_smart_info("Disk is OK", "2016 hours", "Successful", bad_sectors="71")
+        else:
+            check_smart_info("Disk is failing", "2016 hours", "Successful", bad_sectors="71")
 
         # Multiple bad sectors with failing attribute
         set_smart_dump("Maxtor_96147H8--BAC51KJ0--2", "/dev/sda")
         check_smart_info("Disk is failing", "2262 hours", "Successful", bad_sectors="71", failing_attrs="1")
+        b.wait_visible(self.card_desc("Device health (SMART)", "Assessment") + " .pf-m-danger")
 
         # Check that SMART card is not visible on DVD drive
         b.go("/storage")