bug fix: tab command conflict

Author: tomcat323

packages/amazonq/src/app/inline/EditRendering/displayImage.ts

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import { getLogger, setContext } from 'aws-core-vscode/shared'
 import { getLogger, setContext } from 'aws-core-vscode/shared'
 import * as vscode from 'vscode'
 import { diffLines } from 'diff'
@@ -18,6 +19,7 @@ export class EditDecorationManager {
     private currentRemovedCodeDecorations: vscode.DecorationOptions[] = []
     private acceptHandler: (() => void) | undefined
     private rejectHandler: (() => void) | undefined
+    private disposables: vscode.Disposable[] = []
 
     constructor() {
         this.imageDecorationType = vscode.window.createTextEditorDecorationType({
@@ -27,8 +29,6 @@ export class EditDecorationManager {
         this.removedCodeDecorationType = vscode.window.createTextEditorDecorationType({
             backgroundColor: 'rgba(255, 0, 0, 0.2)',
         })
-
-        this.registerCommandHandlers()
     }
 
     /**
@@ -104,6 +104,7 @@ export class EditDecorationManager {
         removedHighlights?: vscode.DecorationOptions[]
     ): void {
         // Clear any existing decorations
+        this.registerCommandHandlers()
         this.clearDecorations(editor)
 
         // Set context to enable the Tab key handler
@@ -152,24 +153,30 @@ export class EditDecorationManager {
      */
     public registerCommandHandlers(): void {
         // Register Tab key handler for accepting suggestion
-        vscode.commands.registerCommand('aws.amazonq.inline.acceptEdit', () => {
+        const acceptDisposable = vscode.commands.registerCommand('aws.amazonq.inline.acceptEdit', () => {
             if (this.acceptHandler) {
                 this.acceptHandler()
             }
         })
+        this.disposables.push(acceptDisposable)
 
         // Register Esc key handler for rejecting suggestion
-        vscode.commands.registerCommand('aws.amazonq.inline.rejectEdit', () => {
+        const rejectDisposable = vscode.commands.registerCommand('aws.amazonq.inline.rejectEdit', () => {
             if (this.rejectHandler) {
                 this.rejectHandler()
             }
         })
+        this.disposables.push(rejectDisposable)
     }
 
     /**
      * Disposes resources
      */
     public dispose(): void {
+        for (const disposable of this.disposables) {
+            disposable.dispose()
+        }
+        this.disposables = []
         this.imageDecorationType.dispose()
         this.removedCodeDecorationType.dispose()
     }
@@ -267,9 +274,18 @@ export async function displaySvgDecoration(
             // Calculate cursor position before replacing content
             const endPosition = getEndOfEditPosition(originalCode, newCode)
 
+            // Replace content
+
+            // Calculate cursor position before replacing content
+            const endPosition = getEndOfEditPosition(originalCode, newCode)
+
             // Replace content
             replaceEditorContent(editor, newCode)
 
+            // Move cursor to end of the actual changed content
+            editor.selection = new vscode.Selection(endPosition, endPosition)
+
+
             // Move cursor to end of the actual changed content
             editor.selection = new vscode.Selection(endPosition, endPosition)
 
@@ -289,6 +305,7 @@ export async function displaySvgDecoration(
                 deletedCharacterCount: deletedCharacterCount,
             }
             languageClient.sendNotification('aws/logInlineCompletionSessionResults', params)
+            decorationManager.dispose()
         },
         () => {
             // Handle reject
@@ -307,6 +324,7 @@ export async function displaySvgDecoration(
                 deletedCharacterCount: deletedCharacterCount,
             }
             languageClient.sendNotification('aws/logInlineCompletionSessionResults', params)
+            decorationManager.dispose()
         },
         originalCode,
         newCode