Accept internal Skia bug for the time being (2) + remove redundant comments.

Author: therealbluepandabear

app/src/main/java/com/therealbluepandabear/pixapencil/activities/canvas/canvashelpers/CanvasActivity+drawPixelGridViewBitmap.kt

@@ -21,17 +21,8 @@ package com.therealbluepandabear.pixapencil.activities.canvas.canvashelpers
 import android.graphics.Bitmap
 import com.therealbluepandabear.pixapencil.activities.canvas.CanvasActivity
 import com.therealbluepandabear.pixapencil.extensions.rotate
-import kotlin.math.abs
-import kotlin.math.ceil
-
-/**
- * We are using 'ceil' to ensure that there is no crooked rotation effect, as when the user
- * selects '180 degrees', they are actually rotating the canvas by 179.9 degrees, I made this the behavior due to a
- * bug in the SDK in which when you rotate the canvas 180 degrees, the drop shadow is lost.
- * Thus, if we had no 'ceil', the resulting bitmap would be crooked as for some reason it rounds it down in this situation.
- */
 
 fun CanvasActivity.drawPixelGridViewBitmap(): Bitmap {
     return binding.activityCanvasPixelGridView.pixelGridViewBitmap
-        .rotate(ceil(abs(binding.activityCanvasCardView.rotation)).toInt(), viewModel.flipMatrix)
+        .rotate(binding.activityCanvasCardView.rotation.toInt(), viewModel.flipMatrix)
 }

app/src/main/java/com/therealbluepandabear/pixapencil/activities/canvas/canvashelpers/CanvasActivity+drawTransparentBackgroundViewBitmap.kt

@@ -21,17 +21,8 @@ package com.therealbluepandabear.pixapencil.activities.canvas.canvashelpers
 import android.graphics.Bitmap
 import com.therealbluepandabear.pixapencil.activities.canvas.CanvasActivity
 import com.therealbluepandabear.pixapencil.extensions.rotate
-import kotlin.math.abs
-import kotlin.math.ceil
-
-/**
- * We are using 'ceil' to ensure that there is no crooked rotation effect, as when the user
- * selects '180 degrees', they are actually rotating the canvas by 179.9 degrees, I made this the behavior due to a
- * bug in the SDK in which when you rotate the canvas 180 degrees, the drop shadow is lost.
- * Thus, if we had no 'ceil', the resulting bitmap would be crooked as for some reason it rounds it down in this situation.
- */
 
 fun CanvasActivity.drawTransparentBackgroundViewBitmap(): Bitmap {
     return binding.activityCanvasTransparentBackgroundView.transparentBackgroundViewBitmap
-        .rotate(ceil(abs(binding.activityCanvasCardView.rotation)).toInt(), viewModel.flipMatrix)
+        .rotate(binding.activityCanvasCardView.rotation.toInt(), viewModel.flipMatrix)
 }

app/src/main/java/com/therealbluepandabear/pixapencil/activities/canvas/canvashelpers/CanvasActivity+flip.kt

@@ -21,31 +21,24 @@ package com.therealbluepandabear.pixapencil.activities.canvas.canvashelpers
 import com.therealbluepandabear.pixapencil.activities.canvas.CanvasActivity
 import com.therealbluepandabear.pixapencil.enums.FlipValue
 
-/**
- * There is a bug in which when you rotate a view 180 degrees, its drop shadow disappears.
- * This has been reported to Google but it hasn't been fixed in some compat libraries.
- * Hopefully it gets fixed in other libraries soon, but for now we can simply rotate it by 179.9 degrees and it seems to fix it.
- * The difference isn't noticeable.
- */
-
 fun CanvasActivity.flip(flipValue: FlipValue) {
     if (viewModel.flipMatrix.isEmpty() || viewModel.flipMatrix.last() != flipValue) {
         viewModel.flipMatrix.add(flipValue)
     }
 
     if (flipValue == FlipValue.Horizontal) {
-        if (binding.activityCanvasCardView.rotationY == 179.9f) {
+        if (binding.activityCanvasCardView.rotationY == 180f) {
             binding.activityCanvasCardView.rotationY = 0f
             viewModel.flipMatrix.removeLast()
         } else {
-            binding.activityCanvasCardView.rotationY = 179.9f
+            binding.activityCanvasCardView.rotationY = 180f
         }
     } else {
-        if (binding.activityCanvasCardView.rotationX == 179.9f) {
+        if (binding.activityCanvasCardView.rotationX == 180f) {
             binding.activityCanvasCardView.rotationX = 0f
             viewModel.flipMatrix.removeLast()
         } else {
-            binding.activityCanvasCardView.rotationX = 179.9f
+            binding.activityCanvasCardView.rotationX = 180f
         }
     }
 }

app/src/main/java/com/therealbluepandabear/pixapencil/enums/RotationValue.kt

@@ -18,13 +18,6 @@
 
 package com.therealbluepandabear.pixapencil.enums
 
-/**
- * There is a bug in which when you rotate a view 180 degrees, its drop shadow disappears.
- * This has been reported to Google but it hasn't been fixed in some compat libraries.
- * Hopefully it gets fixed in other libraries soon, but for now we can simply rotate it by 179.9 degrees and it seems to fix it.
- * The difference isn't noticeable.
- */
-
 enum class RotationValue(val degrees: Float, val clockwise: Boolean = false) {
     NinetyAntiClockwise(90f),
     NinetyClockwise(90f, true),