misc fixes on Lively and Webly

tomooda · tomooda · commit c63e93ebd978 · 2026-01-14T09:55:56.000+09:00
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTCut.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTCut.class.st
@@ -5,8 +5,9 @@ Class {
 		'frames',
 		'remark'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'instance creation' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTDirector.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTDirector.class.st
@@ -16,8 +16,9 @@ Class {
 	#classVars : [
 		'Server'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-UI',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'UI'
 }
 
 { #category : 'instance creation' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTEventFrame.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTEventFrame.class.st
@@ -5,8 +5,9 @@ Class {
 		'morphName',
 		'event'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'instance creation' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTFieldWidget.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTFieldWidget.class.st
@@ -8,8 +8,9 @@ Class {
 		'showsDiagram',
 		'type'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'menu declaration' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTFrame.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTFrame.class.st
@@ -4,8 +4,9 @@ Class {
 	#instVars : [
 		'timestamp'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'menu' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTImageWidget.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTImageWidget.class.st
@@ -5,8 +5,9 @@ Class {
 		'form',
 		'value'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'json' }
@@ -45,13 +46,15 @@ LWTImageWidget >> basename [
 
 { #category : 'operations' }
 LWTImageWidget >> changeImage [
+
 	(LivelyWalkThrough
-		fileOpen: 'Select an image file'
-		extensions: #('png' 'jpg' 'jpeg')
-		path: nil
-		preview: #image)
-		ifNotNil: [ :filename | 
-			[ form := Form fromFileNamed: filename fullName ]
+		 fileOpen: 'Select an image file'
+		 extensions: #( 'png' 'jpg' 'jpeg' )
+		 path: nil
+		 preview: #image) ifNotNil: [ :filename |
+			[
+				form := Form fromFileNamed: filename fullName.
+				self changed ]
 				on: Error
 				do: [ :ex |  ] ]
 ]
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTLivetalkBrowser.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTLivetalkBrowser.class.st
@@ -7,8 +7,9 @@ Class {
 		'codeSelection',
 		'selectedScriptSelector'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-UI',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'UI'
 }
 
 { #category : 'instance creation' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTLivetalkCompiler.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTLivetalkCompiler.class.st
@@ -14,8 +14,9 @@ Class {
 		'dialog',
 		'step'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'compiling' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTLivetalkScript.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTLivetalkScript.class.st
@@ -8,8 +8,9 @@ Class {
 		'performer',
 		'compiledMethod'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'instance creation' }
@@ -58,21 +59,22 @@ LWTLivetalkScript >> name [
 
 { #category : 'private' }
 LWTLivetalkScript >> setWidgetName: nameString event: eventString performer: anObject source: sourceString ifFail: errorBlock [
+
 	(self class scriptCompilerClass new
-		compileToSmalltalk: sourceString
-		ifError: [ :msg :pos | ^ errorBlock cull: msg cull: pos ])
-		ifNotNil: [ :smalltalkSource | 
-			| compiler  |
-			widgetName := nameString.
-			event := eventString asSymbol.
-			performer := anObject.
-			compiler := OpalCompiler new
-				source: smalltalkSource;
-				class: performer class;
-				noPattern: true;
-				failBlock: [ ^ errorBlock value ].
-			compiledMethod := compiler compile.
-			source := sourceString ]
+		 compileToSmalltalk: sourceString
+		 ifError: [ :msg :pos | ^ errorBlock cull: msg cull: pos ])
+		ifNotNil: [ :smalltalkSource |
+				| compiler |
+				widgetName := nameString.
+				event := eventString asSymbol.
+				performer := anObject.
+				compiler := OpalCompiler new
+					            source: smalltalkSource;
+					            class: performer class;
+					            isScripting: true;
+					            failBlock: [ ^ errorBlock value ].
+				compiledMethod := compiler compile.
+				source := sourceString ]
 ]
 
 { #category : 'accessing' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTMouseSensor.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTMouseSensor.class.st
@@ -7,8 +7,9 @@ Class {
 		'borderColor',
 		'borderWidth'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'instance creation' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTPlotWidget.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTPlotWidget.class.st
@@ -9,8 +9,9 @@ Class {
 		'lineWidth',
 		'dotRadius'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'json' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTRemoteWidget.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTRemoteWidget.class.st
@@ -4,8 +4,9 @@ Class {
 	#instVars : [
 		'url'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'accessing' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTTimerWidget.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTTimerWidget.class.st
@@ -6,8 +6,9 @@ Class {
 		'stepTime',
 		'stepping'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'json' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTVDMCallFrame.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTVDMCallFrame.class.st
@@ -6,8 +6,9 @@ Class {
 		'expression',
 		'value'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'instance creation' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTVDMStateFrame.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTVDMStateFrame.class.st
@@ -4,8 +4,9 @@ Class {
 	#instVars : [
 		'states'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'instance creation' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTVariableImageWidget.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTVariableImageWidget.class.st
@@ -6,8 +6,9 @@ Class {
 		'value',
 		'forms'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'operations' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTWidget.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTWidget.class.st
@@ -9,8 +9,9 @@ Class {
 		'showsName',
 		'frozen'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Widgets',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Widgets'
 }
 
 { #category : 'json' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LWTWidgetDispenser.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LWTWidgetDispenser.class.st
@@ -11,8 +11,9 @@ Class {
 		'areaWidget',
 		'remoteWidget'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-UI',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'UI'
 }
 
 { #category : 'accessing' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/LivelyWalkThrough.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/LivelyWalkThrough.class.st
@@ -7,8 +7,9 @@ Class {
 	#classVars : [
 		'Server'
 	],
-	#category : 'ViennaTalk-LivelyWalkThrough-Core',
-	#package : 'ViennaTalk-LivelyWalkThrough-Core'
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Models',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Models'
 }
 
 { #category : 'instance creation' }
@@ -20,18 +21,16 @@ LivelyWalkThrough class >> default [
 LivelyWalkThrough class >> fileOpen: title extensions: exts path: path preview: preview [
 	"LivelyWalkThrough fileOpen: 'title' extensions: #('png' 'jpg') path: nil preview: #image"
 
-	| ref ui fd |
-	ref := path isString ifTrue: [ (FileSystem disk pathFromString: path)  asFileReference ] ifFalse: [ path  ].
-	ui := UIManager default.
-	fd := FileDialogWindow basicNew
-		basicTheme: ui theme;
-		previewType: preview;
-		initialize;
-		title: title;
-		answerPathName.
-	exts ifNotNil: [ fd validExtensions: exts ].
-	path ifNotNil: [ fd selectPath: ref parent  ].
-	^ (ui openModal: fd) answer ifNotNil: [ :ans | ans asFileReference ]
+	| fileBrowser |
+	fileBrowser := StOpenFilePresenter new
+		               extensions: exts;
+		               yourself.
+	preview ifNotNil: [
+		fileBrowser previewer: StFileBrowserAdaptiveContentPreviewer new ].
+	(fileBrowser asModalWindow
+		 title: title;
+		 open) cancelled ifTrue: [ ^ nil ].
+	^ fileBrowser selectedEntry asFileReference
 ]
 
 { #category : 'class initialization' }
diff --git a/repository/ViennaTalk-LivelyWalkThrough-Core/ManifestViennaTalkLivelyWalkThroughCore.class.st b/repository/ViennaTalk-LivelyWalkThrough-Core/ManifestViennaTalkLivelyWalkThroughCore.class.st
@@ -0,0 +1,10 @@
+"
+Please describe the package using the class comment of the included manifest class. The manifest class also includes other additional metadata for the package. These meta data are used by other tools such as the SmalllintManifestChecker and the critics Browser
+"
+Class {
+	#name : 'ManifestViennaTalkLivelyWalkThroughCore',
+	#superclass : 'PackageManifest',
+	#category : 'ViennaTalk-LivelyWalkThrough-Core-Manifest',
+	#package : 'ViennaTalk-LivelyWalkThrough-Core',
+	#tag : 'Manifest'
+}
diff --git a/repository/ViennaTalk-WeblyWalkThrough-Server/WeblyWalkThrough.class.st b/repository/ViennaTalk-WeblyWalkThrough-Server/WeblyWalkThrough.class.st
