Skip to content

Commit 8783aa1

Browse files
committed
Accept "new" and "initialize" method both documented
1 parent 7e5bb30 commit 8783aa1

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

lib/rdoc/parser/prism_ruby.rb

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -527,16 +527,6 @@ def add_method(name, receiver_name:, receiver_fallback_type:, visibility:, singl
527527
handle_modifier_directive(meth, end_line)
528528
return unless should_document?(meth)
529529

530-
if meth.name == 'initialize' && !singleton
531-
if meth.dont_rename_initialize
532-
meth.visibility = :protected
533-
else
534-
meth.name = 'new'
535-
meth.singleton = true
536-
meth.visibility = :public
537-
end
538-
end
539-
540530
internal_add_method(
541531
receiver,
542532
meth,
@@ -548,6 +538,18 @@ def add_method(name, receiver_name:, receiver_fallback_type:, visibility:, singl
548538
block_params: block_params,
549539
tokens: tokens
550540
)
541+
542+
# Rename after add_method to register duplicated 'new' and 'initialize'
543+
# defined in c and ruby just like the old parser did.
544+
if meth.name == 'initialize' && !singleton
545+
if meth.dont_rename_initialize
546+
meth.visibility = :protected
547+
else
548+
meth.name = 'new'
549+
meth.singleton = true
550+
meth.visibility = :public
551+
end
552+
end
551553
end
552554

553555
private def internal_add_method(container, meth, line_no:, visibility:, singleton:, params:, calls_super:, block_params:, tokens:) # :nodoc:

0 commit comments

Comments
 (0)