Skip to content

Commit 0e68a4c

Browse files
fix: return failed TartVMStatusGet probe w/o error to kill process (#35)
2 parents bf6e679 + 29e5a4a commit 0e68a4c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/prober/probe/github/github.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ type githubProber struct {
4040
func (g githubProber) Probe(runnerName string) (probe.Result, string, error) {
4141
runners, err := g.client.GetRunnerByName(runnerName)
4242
if err != nil {
43-
return probe.Failure, fmt.Sprintf("Failed to get runner <%v> from github", runnerName), err
43+
return probe.Failure, fmt.Sprintf("Failed to get runner <%s> from github", runnerName), err
4444
}
4545

4646
if len(runners.Runners) == 0 {
47-
return probe.Failure, fmt.Sprintf("Runner <%v> not registered on github", runnerName), nil
47+
return probe.Failure, fmt.Sprintf("Runner <%s> not registered on github", runnerName), nil
4848
}
4949

5050
return probe.Success, "github probe success", nil

pkg/prober/probe/tart/tart.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func New(tartClient *tart.Client) Prober {
4040
func (t tartProber) Probe(tartVMName string) (probe.Result, string, error) {
4141
_, err := t.client.GetTartVMIP(tartVMName)
4242
if err != nil {
43-
return probe.Failure, fmt.Sprintf("Failed to get tart VM %s IP", tartVMName), err
43+
return probe.Failure, fmt.Sprintf("Failed to get tart VM %s IP", tartVMName), nil
4444
}
4545

4646
return probe.Success, "tart probe success", nil

0 commit comments

Comments
 (0)