Avoid triggering PHP Warning: strpos(): Empty needle in UserAgent.php line 25.

DavidGoodwin · DavidGoodwin · commit 53b9e2c01b07 · 2018-02-26T13:46:03.000Z
(Remove any empty parsed useragent strings)
diff --git a/src/Robot/RobotsTxt.php b/src/Robot/RobotsTxt.php
@@ -65,6 +65,9 @@ private function parseFile(RobotsFile $robotFile)
 
         $this->records = [];
         foreach($fileRecords as $record) {
+            if (!empty($record['ua'])) {
+                $record['ua'] = array_filter($record['ua']);
+            }
             if (!empty($record['ua']) && !empty($record['rules'])) {
                 $this->records[] = new Record(new UserAgent($record['ua']), new AccessRules($record['rules']));
             }

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,9 @@ private function parseFile(RobotsFile $robotFile)`
`65`	`65`
`66`	`66`	`$this->records = [];`
`67`	`67`	`foreach($fileRecords as $record) {`
	`68`	`+ if (!empty($record['ua'])) {`
	`69`	`+ $record['ua'] = array_filter($record['ua']);`
	`70`	`+ }`
`68`	`71`	`if (!empty($record['ua']) && !empty($record['rules'])) {`
`69`	`72`	`$this->records[] = new Record(new UserAgent($record['ua']), new AccessRules($record['rules']));`
`70`	`73`	`}`