Skip to content

Commit 7c080d4

Browse files
committed
Drop Python 3.9
1 parent 013687f commit 7c080d4

File tree

4 files changed

+5
-27
lines changed

4 files changed

+5
-27
lines changed

.github/workflows/cd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- uses: actions/checkout@v4
1919
- uses: actions/setup-python@v5
2020
with:
21-
python-version: '3.9'
21+
python-version: '3.10'
2222
- name: Install dependencies
2323
run: |
2424
python -m pip install --upgrade pip

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
# Use macos-13 because pip binary packages for ARM aren't
2525
# available for many dependencies
2626
os: [macos-13, macos-14, ubuntu-latest]
27-
python-version: ["3.9", "3.10", "3.11", "3.12"]
27+
python-version: ["3.10", "3.11", "3.12"]
2828
exclude:
2929
# Just run macos tests on one Python version
3030
- os: macos-13
@@ -33,8 +33,6 @@ jobs:
3333
python-version: "3.11"
3434
- os: macos-13
3535
python-version: "3.12"
36-
- os: macos-14
37-
python-version: "3.9"
3836
- os: macos-14
3937
python-version: "3.10"
4038
- os: macos-14

bio2zarr/core.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@
77
import multiprocessing
88
import os
99
import os.path
10-
import sys
1110
import threading
1211
import time
13-
import warnings
1412

1513
import humanfriendly
1614
import numcodecs
@@ -216,22 +214,6 @@ def setup_progress_counter(counter):
216214
_progress_counter = counter
217215

218216

219-
def warn_py39_mac():
220-
if sys.platform == "darwin" and sys.version_info[:2] == (3, 9):
221-
warnings.warn(
222-
"There is a known issue with bio2zarr on MacOS Python 3.9 "
223-
"in which OS-level named semaphores are leaked. "
224-
"You will also probably see warnings like 'There appear to be N "
225-
"leaked semaphore objects at shutdown'. "
226-
"While this is likely harmless for a few runs, it could lead to "
227-
"issues if you do a lot of conversion. To get prevent this issue "
228-
"either: (1) use --worker-processes=0 or (2) upgrade to a newer "
229-
"Python version. See https://github.com/sgkit-dev/bio2zarr/issues/209 "
230-
"for more details.",
231-
stacklevel=2,
232-
)
233-
234-
235217
class ParallelWorkManager(contextlib.AbstractContextManager):
236218
def __init__(self, worker_processes=1, progress_config=None):
237219
# Need to specify this explicitly to suppport Macs and
@@ -244,7 +226,6 @@ def __init__(self, worker_processes=1, progress_config=None):
244226
# production. See note on the SynchronousExecutor class.
245227
self.executor = SynchronousExecutor()
246228
else:
247-
warn_py39_mac()
248229
self.executor = cf.ProcessPoolExecutor(
249230
max_workers=worker_processes,
250231
mp_context=ctx,

pyproject.toml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ dependencies = [
2424
"cyvcf2",
2525
"bed_reader",
2626
]
27-
requires-python = ">=3.9"
27+
requires-python = ">=3.10"
2828
classifiers = [
2929
"Development Status :: 4 - Beta",
3030
"License :: OSI Approved :: Apache Software License",
@@ -35,7 +35,6 @@ classifiers = [
3535
"Intended Audience :: Science/Research",
3636
"Programming Language :: Python",
3737
"Programming Language :: Python :: 3",
38-
"Programming Language :: Python :: 3.9",
3938
"Programming Language :: Python :: 3.10",
4039
"Programming Language :: Python :: 3.11",
4140
"Programming Language :: Python :: 3.12",
@@ -74,8 +73,8 @@ testpaths = "tests"
7473
addopts = "--cov=bio2zarr --cov-report term-missing"
7574

7675
[tool.ruff]
77-
# Assume Python 3.9
78-
target-version = "py39"
76+
# Assume Python 3.10
77+
target-version = "py310"
7978

8079
# Same as Black.
8180
line-length = 88

0 commit comments

Comments
 (0)