Skip to content

Commit 53b0467

Browse files
committed
Add typing to Finder
1 parent 779cff5 commit 53b0467

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/PHPSemVerChecker/Finder/Finder.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class Finder
1212
* @param array $excludes
1313
* @return array
1414
*/
15-
public function find($path, array $includes, array $excludes = [])
15+
public function find(string $path, array $includes, array $excludes = []): array
1616
{
1717
$finder = new BaseFinder();
1818
$finder->ignoreDotFiles(true)
@@ -37,23 +37,23 @@ public function find($path, array $includes, array $excludes = [])
3737
}
3838

3939
/**
40-
* @param string $path
41-
* @param string $includes
42-
* @param string $excludes
40+
* @param string $path
41+
* @param string|null $includes
42+
* @param string|null $excludes
4343
* @return array
4444
*/
45-
public function findFromString($path, $includes, $excludes)
45+
public function findFromString(string $path, ?string $includes, ?string $excludes): array
4646
{
4747
if ($includes === '*' || $includes === null) {
4848
$includes = [];
4949
} else {
50-
$includes = preg_split('@(?:\s*,\s*|^\s*|\s*$)@', $includes, null, PREG_SPLIT_NO_EMPTY);
50+
$includes = preg_split('@(?:\s*,\s*|^\s*|\s*$)@', $includes, -1, PREG_SPLIT_NO_EMPTY);
5151
}
5252

5353
if ($excludes === '*' || $excludes === null) {
5454
$excludes = [];
5555
} else {
56-
$excludes = preg_split('@(?:\s*,\s*|^\s*|\s*$)@', $excludes, null, PREG_SPLIT_NO_EMPTY);
56+
$excludes = preg_split('@(?:\s*,\s*|^\s*|\s*$)@', $excludes, -1, PREG_SPLIT_NO_EMPTY);
5757
}
5858

5959
return $this->find($path, $includes, $excludes);

0 commit comments

Comments
 (0)