Improved ReporterTest::testOutput test.

Reporter class now doesn't depend on Symfony\Component\Console\Input\InputInterface. The values it depends on must be set using setters instead. In this particular case, setFullPath.
Added line property to the json output.

Author: tomzx

src/PHPSemVerChecker/Console/Command/CompareCommand.php

@@ -79,6 +79,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 		$report = $analyzer->analyze($registryBefore, $registryAfter);
 
 		$reporter = new Reporter($report, $input);
+		$reporter->setFullPath($input->getOption('full-path'));
 		$reporter->output($output);
 
 		$toJson = $input->getOption('to-json');

src/PHPSemVerChecker/Reporter/JsonReporter.php

@@ -55,6 +55,7 @@ public function output()
 					$output['changes'][$context][] = [
 						'level' => Level::toString($level),
 						'location' => $operation->getLocation(),
+						'line' => $operation->getLine(),
 						'target' => $operation->getTarget(),
 						'reason' => $operation->getReason(),
 						'code' => $operation->getCode(),

src/PHPSemVerChecker/Reporter/Reporter.php

@@ -6,30 +6,35 @@
 use PHPSemVerChecker\Report\Report;
 use PHPSemVerChecker\SemanticVersioning\Level;
 use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Reporter {
 	/**
 	 * @var \PHPSemVerChecker\Report\Report
 	 */
 	protected $report;
-	/**
-	 * @var \Symfony\Component\Console\Input\InputInterface
-	 */
-	protected $input;
 	/**
 	 * @var string
 	 */
 	protected $cwd;
+	/**
+	 * @var bool
+	 */
+	protected $fullPath = false;
 
-	public function __construct(Report $report, InputInterface $input)
+	public function __construct(Report $report)
 	{
 		$this->report = $report;
-		$this->input = $input;
 		$this->cwd = getcwd();
 	}
 
+	public function setFullPath($fullPath)
+	{
+		$this->fullPath = $fullPath;
+
+		return $this;
+	}
+
 	public function output(OutputInterface $output)
 	{
 		$suggestedChange = $this->report->getSuggestedLevel();
@@ -81,7 +86,7 @@ protected function outputTable(OutputInterface $output, Report $report, $context
 
 	protected function getLocation(Operation $operation)
 	{
-		$isFullPath = $this->input->getOption('full-path');
+		$isFullPath = $this->fullPath;
 		if ($isFullPath) {
 			$location = $operation->getLocation();
 		} else {

tests/PHPSemVerChecker/Reporter/JsonReporterTest.php

@@ -48,13 +48,15 @@ public function testOutput()
 			$operation = $data['changes']['class'][0];
 
 			return $operation['level'] === Level::toString(Level::MAJOR) &&
+				$operation['line'] === 'test-line' &&
 				$operation['location'] === 'test-location' &&
 				$operation['target'] === 'test-target' &&
 				$operation['reason'] === 'test-reason' &&
 				$operation['code'] === 'test-code';
 		}));
 
 		$operation->shouldReceive('getLocation')->once()->andReturn('test-location')
+			->shouldReceive('getLine')->once()->andReturn('test-line')
 			->shouldReceive('getTarget')->once()->andReturn('test-target')
 			->shouldReceive('getReason')->once()->andReturn('test-reason')
 			->shouldReceive('getCode')->once()->andReturn('test-code');

tests/PHPSemVerChecker/Reporter/ReporterTest.php

@@ -2,7 +2,6 @@
 
 namespace PHPSemVerChecker\Test\Reporter;
 
-use ArrayIterator;
 use Mockery as m;
 use PHPSemVerChecker\Reporter\Reporter;
 use PHPSemVerChecker\SemanticVersioning\Level;
@@ -13,9 +12,9 @@
 class ReporterTest extends TestCase {
 	public function testOutput()
 	{
-		$input = new ArrayInput([]);
 		$output = new NullOutput();
 		$report = m::mock('PHPSemVerChecker\Report\Report');
+		$operation = m::mock('PHPSemVerChecker\Operation\Operation');
 
 		$levels = [
 			Level::PATCH => [],
@@ -24,20 +23,32 @@ public function testOutput()
 		];
 
 		$differences = [
-			'class'     => $levels,
+			'class'     => [
+				Level::PATCH => [],
+				Level::MINOR => [],
+				Level::MAJOR => [
+					$operation
+				],
+			],
 			'function'  => $levels,
 			'interface' => $levels,
 			'method'    => $levels,
 			'trait'     => $levels,
 		];
 
 		$report->shouldReceive('getSuggestedLevel')->andReturn(Level::MAJOR)
-			->shouldReceive('getIterator')->andReturn(new ArrayIterator($differences))
-			->shouldReceive('offsetGet')->andReturn($levels)
-			->shouldReceive('hasDifferences')->andReturn(true)
+			->shouldReceive('hasDifferences')->with('class')->andReturn(true)
+			->shouldReceive('offsetGet')->with('class')->andReturn($differences['class'])
+			->shouldReceive('hasDifferences')->andReturn(false)
 			->shouldReceive('getLevelForContext')->andReturn(Level::MAJOR);
 
-		$reporter = new Reporter($report, $input);
+		$operation->shouldReceive('getLocation')->once()->andReturn('test-location')
+			->shouldReceive('getLine')->once()->andReturn('test-line')
+			->shouldReceive('getTarget')->once()->andReturn('test-target')
+			->shouldReceive('getReason')->once()->andReturn('test-reason')
+			->shouldReceive('getCode')->once()->andReturn('test-code');
+
+		$reporter = new Reporter($report);
 		$reporter->output($output);
 	}
 }