[#62] PHP Notice for an Unknown operation

tomzx · tomzx · commit e47d04bce810 · 2015-05-22T00:09:57.000-04:00
Do not add an Unknown operation to reports. If we do not know what has changed, there is no reason to report it. A report should only contain changes we can explain.
diff --git a/src/PHPSemVerChecker/Analyzer/FunctionAnalyzer.php b/src/PHPSemVerChecker/Analyzer/FunctionAnalyzer.php
@@ -70,10 +70,6 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
 					$report->addFunction($data);
 					continue;
 				}
-
-				// Unable to match an issue, but there is one...
-				$data = new Unknown($fileBefore, $fileAfter);
-				$report->addFunction($data);
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -70,10 +70,6 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)`
`70`	`70`	`$report->addFunction($data);`
`71`	`71`	`continue;`
`72`	`72`	`}`
`73`		`-`
`74`		`- // Unable to match an issue, but there is one...`
`75`		`- $data = new Unknown($fileBefore, $fileAfter);`
`76`		`- $report->addFunction($data);`
`77`	`73`	`}`
`78`	`74`	`}`
`79`	`75`