improve voting

Author: yungwine

modules/utilities.py

@@ -162,6 +162,9 @@ def get_offer_diff(self, offer_hash):
         offer = self.ton.GetOffer(offer_hash)
         config_id = offer["config"]["id"]
         config_value = offer["config"]["value"]
+        if config_id < 0:
+            color_print("{red}Offer config id is negative. Cannot get diff.{endc}")
+            return
 
         if '{' in config_value or '}' in config_value:
             start = config_value.find('{') + 1

modules/validator.py

@@ -16,8 +16,13 @@ def vote_offer(self, args):
         if len(args) == 0:
             color_print("{red}Bad args. Usage:{endc} vo <offer-hash>")
             return
-        for offerHash in args:
-            self.ton.VoteOffer(offerHash)
+        offers = self.ton.GetOffers()
+        for offer_hash in args:
+            offer = self.ton.GetOffer(offer_hash, offers)
+            self.ton.add_save_offer(offer)
+        for offer_hash in args:
+            offer = self.ton.GetOffer(offer_hash, offers)
+            self.ton.VoteOffer(offer)
         color_print("VoteOffer - {green}OK{endc}")
 
     def vote_election_entry(self, args):

mytoncore/functions.py

@@ -435,6 +435,10 @@ def GetBlockTimeAvg(local, timediff):
 
 def Offers(local, ton):
     save_offers = ton.GetSaveOffers()
+    if save_offers:
+        ton.offers_gc(save_offers)
+    else:
+        return
     offers = ton.GetOffers()
     for offer in offers:
         offer_hash = offer.get("hash")
@@ -446,7 +450,7 @@ def Offers(local, ton):
             else:  # old version of save offers {"hash": "pseudohash"}
                 save_offer_pseudohash = save_offer
             if offer_pseudohash == save_offer_pseudohash and offer_pseudohash is not None:
-                ton.VoteOffer(offer_hash)
+                ton.VoteOffer(offer)
 # end define
 
 def Telemetry(local, ton):

mytoncore/mytoncore.py

@@ -2280,23 +2280,23 @@ def SignComplaintVoteRequestWithValidator(self, complaintHash, electionId, valid
 		return fileName
 	#end define
 
-	def VoteOffer(self, offerHash):
+	def VoteOffer(self, offer):
 		self.local.add_log("start VoteOffer function", "debug")
-		fullConfigAddr = self.GetFullConfigAddr()
+		full_config_addr = self.GetFullConfigAddr()
 		wallet = self.GetValidatorWallet(mode="vote")
-		validatorKey = self.GetValidatorKey()
-		validatorPubkey_b64 = self.GetPubKeyBase64(validatorKey)
-		validatorIndex = self.GetValidatorIndex()
-		offer = self.GetOffer(offerHash)
-		if validatorIndex in offer.get("votedValidators"):
+		validator_key = self.GetValidatorKey()
+		validator_pubkey_b64 = self.GetPubKeyBase64(validator_key)
+		validator_index = self.GetValidatorIndex()
+		offer_hash = offer.get("hash")
+		if validator_index in offer.get("votedValidators"):
 			self.local.add_log("Proposal already has been voted", "debug")
 			return
 		self.add_save_offer(offer)
-		var1 = self.CreateConfigProposalRequest(offerHash, validatorIndex)
-		validatorSignature = self.GetValidatorSignature(validatorKey, var1)
-		resultFilePath = self.SignProposalVoteRequestWithValidator(offerHash, validatorIndex, validatorPubkey_b64, validatorSignature)
-		resultFilePath = self.SignBocWithWallet(wallet, resultFilePath, fullConfigAddr, 1.5)
-		self.SendFile(resultFilePath, wallet)
+		var1 = self.CreateConfigProposalRequest(offer_hash, validator_index)
+		validator_signature = self.GetValidatorSignature(validator_key, var1)
+		result_file_path = self.SignProposalVoteRequestWithValidator(offer_hash, validator_index, validator_pubkey_b64, validator_signature)
+		result_file_path = self.SignBocWithWallet(wallet, result_file_path, full_config_addr, 1.5)
+		self.SendFile(result_file_path, wallet, remove=False)
 	#end define
 
 	def VoteComplaint(self, electionId, complaintHash):
@@ -2604,11 +2604,12 @@ def CheckValidators(self, start, end):
 			self.local.add_log("var1: {}, var2: {}, pubkey: {}, election_id: {}".format(var1, var2, pubkey, electionId), "debug")
 	#end define
 
-	def GetOffer(self, offerHash):
+	def GetOffer(self, offer_hash: str, offers: list = None):
 		self.local.add_log("start GetOffer function", "debug")
-		offers = self.GetOffers()
+		if offers is None:
+			offers = self.GetOffers()
 		for offer in offers:
-			if offerHash == offer.get("hash"):
+			if offer_hash == offer.get("hash"):
 				return offer
 		raise Exception("GetOffer error: offer not found.")
 	#end define
@@ -2878,9 +2879,11 @@ def offers_gc(self, save_offers):
 			if offer_hash not in current_offers_hashes:
 				if isinstance(offer, list):
 					param_id = offer[1]
-					if param_id is not None and offer[0] != self.calculate_offer_pseudohash(offer_hash, param_id):
+					phash = self.calculate_offer_pseudohash(offer_hash, param_id)
+					if param_id is not None and offer[0] != phash:
 						# param has been changed so no need to keep anymore
 						save_offers.pop(offer_hash)
+						self.local.add_log(f"Removing offer {offer_hash} from save_offers. Saved phash: {offer[0]}, now phash: {phash}", "debug")
 				else:  # old version of offer in db
 					save_offers.pop(offer_hash)
 		return save_offers
@@ -2891,7 +2894,6 @@ def GetSaveOffers(self):
 		if save_offers is None or isinstance(save_offers, list):
 			save_offers = dict()
 			self.local.db[bname] = save_offers
-		self.offers_gc(save_offers)
 		return save_offers
 	#end define