fix: flaky tests (#19)

Author: Gusarich

.editorconfig

@@ -0,0 +1,9 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+insert_final_newline = true
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true

.gitattributes

@@ -0,0 +1,12 @@
+* text=auto eol=lf
+
+# Keep common scripts LF on all platforms
+*.sh text eol=lf
+*.ts text eol=lf
+*.tsx text eol=lf
+*.js text eol=lf
+*.json text eol=lf
+*.md text eol=lf
+*.yml text eol=lf
+*.yaml text eol=lf
+*.py text eol=lf

package.json

@@ -10,9 +10,9 @@
         "benchmark:add": "jest --runTestsByPath tests/Benchmark.spec.ts --verbose --testPathIgnorePatterns=/node_modules/ --testPathIgnorePatterns=/dist/ -- --add",
         "benchmark:replace": "jest --runTestsByPath tests/Benchmark.spec.ts --verbose --testPathIgnorePatterns=/node_modules/ --testPathIgnorePatterns=/dist/ -- --replace",
         "benchmark:print": "node tests/print-benchmark.js",
-        "format": "npx prettier --write \"**/*.{js,ts,tsx,json,md,yml,yaml}\" && UV_CACHE_DIR=.uv-cache uv run ruff format .",
-        "format:check": "npx prettier --check \"**/*.{js,ts,tsx,json,md,yml,yaml}\" && UV_CACHE_DIR=.uv-cache uv run ruff format --check .",
-        "lint": "UV_CACHE_DIR=.uv-cache uv run ruff check . && npx eslint .",
+        "format": "npx prettier --write \"**/*.{js,ts,tsx,json,md,yml,yaml}\" && uv run ruff format .",
+        "format:check": "npx prettier --check \"**/*.{js,ts,tsx,json,md,yml,yaml}\" && uv run ruff format --check .",
+        "lint": "uv run ruff check . && npx eslint .",
         "check:kernel": "UV_CACHE_DIR=.uv-cache uv run python scripts/check_kernel.py",
         "ci": "npm run format:check && npm run lint && npm run check:kernel && npm test"
     },

src/generator.py

@@ -943,7 +943,7 @@ def process_hit(
 
     init_obj = {
         "code": base64.urlsafe_b64encode(boc_code).decode("utf-8"),
-        "fixedPrefixLength": 0 if fpl_val is None else fpl_val,
+        "fixedPrefixLength": None if fpl_val is None else fpl_val,
         "special": None
         if special is None
         else {"tick": bool(special[0]), "tock": bool(special[1])},

tests/Benchmark.spec.ts

@@ -69,10 +69,7 @@ const benchDeviceIds = parseDeviceIds(benchDevices);
 type PythonCmd = { exe: string; args: string[] };
 
 const resolvePython = (): PythonCmd => {
-    const candidates =
-        process.platform === 'win32'
-            ? ['py', 'py -3', 'python3', 'python']
-            : ['python3', 'python'];
+    const candidates = process.platform === 'win32' ? ['py', 'py -3', 'python3', 'python'] : ['python3', 'python'];
     for (const cmd of candidates) {
         const [exe, ...args] = cmd.split(' ');
         try {
@@ -137,9 +134,7 @@ const normalizeDeviceName = (name: string) =>
 
 const detectedDevicesAll = detectDevices().map(normalizeDeviceName).filter(Boolean);
 const selectedDevices = benchDeviceIds
-    ? benchDeviceIds
-          .map((i) => detectedDevicesAll[i])
-          .filter((n): n is string => typeof n === 'string' && n.length > 0)
+    ? benchDeviceIds.map((i) => detectedDevicesAll[i]).filter((n): n is string => typeof n === 'string' && n.length > 0)
     : detectedDevicesAll;
 
 const benchCases: BenchCase[] = (() => {
@@ -319,10 +314,10 @@ const gpuOk = gpuAvailable();
             const entry = entries[i];
             const prev = i > 0 ? entries[i - 1] : null;
 
-        const dt = new Date(entry.timestamp * 1000);
-        const iso = dt.toISOString().slice(0, 10);
-        const [y, m, d] = iso.split('-');
-        const dateStr = `${d}.${m}.${y.slice(2)}`; // DD.MM.YY
+            const dt = new Date(entry.timestamp * 1000);
+            const iso = dt.toISOString().slice(0, 10);
+            const [y, m, d] = iso.split('-');
+            const dateStr = `${d}.${m}.${y.slice(2)}`; // DD.MM.YY
 
             const row: Record<string, unknown> = {
                 run: raw(String(entry.title)),
@@ -406,8 +401,7 @@ const gpuOk = gpuAvailable();
                   : detectedDevicesAll.length
                     ? detectedDevicesAll
                     : [DEFAULT_DEVICE];
-        const resolvedDeviceName =
-            effectiveDevices.length === 1 ? effectiveDevices[0] : effectiveDevices.join(' + ');
+        const resolvedDeviceName = effectiveDevices.length === 1 ? effectiveDevices[0] : effectiveDevices.join(' + ');
 
         const resultsMap = readResultsMap();
         const priorEntries: BenchEntry[] = resultsMap[resolvedDeviceName] ?? [];

tests/Generator.spec.ts

@@ -23,10 +23,7 @@ const MASTERCHAIN_VARIANTS = [false, true];
 type PythonCmd = { exe: string; args: string[] };
 
 const resolvePython = (): PythonCmd => {
-    const candidates =
-        process.platform === 'win32'
-            ? ['py', 'py -3', 'python3', 'python']
-            : ['python3', 'python'];
+    const candidates = process.platform === 'win32' ? ['py', 'py -3', 'python3', 'python'] : ['python3', 'python'];
     for (const cmd of candidates) {
         const [exe, ...args] = cmd.split(' ');
         try {
@@ -43,7 +40,9 @@ const resolvePython = (): PythonCmd => {
 
 const PYTHON = resolvePython();
 
-function gpuAvailable(): boolean {
+type GpuProbe = { ok: boolean; reason?: string };
+
+function gpuAvailable(): GpuProbe {
     const probe = `
 try:
     import pyopencl as cl
@@ -54,11 +53,26 @@ try:
         except Exception:
             pass
     print("1" if devs else "0")
-except Exception:
-    print("0")
+except Exception as e:
+    print("err:" + repr(e))
 `;
-    const res = spawnSync(PYTHON.exe, [...PYTHON.args, '-c', probe], { cwd: 'src', encoding: 'utf8' });
-    return res.status === 0 && res.stdout.trim() === '1';
+    const res = spawnSync(PYTHON.exe, [...PYTHON.args, '-c', probe], {
+        cwd: 'src',
+        encoding: 'utf8',
+    });
+
+    if (res.error) {
+        return { ok: false, reason: `spawn failed: ${res.error.message}` };
+    }
+    const out = (res.stdout || '').trim();
+    if (res.status !== 0) {
+        const err = (res.stderr || out || `exit ${res.status}`).trim();
+        return { ok: false, reason: `python exited ${res.status}: ${err}` };
+    }
+    if (out === '1') {
+        return { ok: true };
+    }
+    return { ok: false, reason: `pyopencl unavailable or no OpenCL devices (stdout="${out}")` };
 }
 
 type PyInfo = { start_digit_base: number };
@@ -218,9 +232,13 @@ for (let len = 1; len <= 4; len++) {
 
 const scenarios: Scenario[] = [...startScenarios, ...endScenarios, ...comboScenarios];
 
-const gpuOk = gpuAvailable();
+const gpu = gpuAvailable();
+if (!gpu.ok) {
+    // Log once so it shows up even when the suite is skipped.
+    console.warn(`[generator.py GPU matrix] skipping: ${gpu.reason}`);
+}
 
-(gpuOk ? describe : describe.skip)('generator.py GPU matrix', () => {
+(gpu.ok ? describe : describe.skip)('generator.py GPU matrix', () => {
     const owner = Address.parseFriendly(OWNER).address;
 
     it.each(scenarios)('$name', (scenario) => {
@@ -260,7 +278,7 @@ const gpuOk = gpuAvailable();
         // Rebuild StateInit and recompute contract address, compare to reported.
         type HitInit = {
             code: string;
-            fixedPrefixLength?: number;
+            fixedPrefixLength?: number | null;
             special?: { tick: boolean; tock: boolean } | null;
         };
         type HitConfig = {
@@ -276,7 +294,7 @@ const gpuOk = gpuAvailable();
         const stateInit: StateInit & { special?: { tick: boolean; tock: boolean } } = {
             code: codeCell,
         };
-        if (init.fixedPrefixLength && init.fixedPrefixLength > 0) {
+        if (init.fixedPrefixLength !== undefined && init.fixedPrefixLength !== null) {
             stateInit.splitDepth = init.fixedPrefixLength;
         }
         if (init.special) {

tests/print-benchmark.js

@@ -31,7 +31,6 @@ const normalizeRate = (rate, length, ci) => {
 };
 const raw = (s) => ({ [Symbol.for('nodejs.util.inspect.custom')]: () => s });
 
-
 const argv = process.argv;
 let deviceFilter = null;
 for (let i = 0; i < argv.length; i++) {