code cleanup

Author: tongyuantongyu

tool/tcping.go

@@ -72,18 +72,11 @@ func TCPing(q *TCPingQ) (*TCPingP, error) {
 	for i := uint64(0); i < q.Times; i++ {
 		ctx, cancel = context.WithCancel(context.Background())
 		conn, err := d.DialContext(ctx, network, addr.String())
-		if err != nil {
-			r.Data = append(r.Data, TCPingPEntry{
-				Success: false,
-				Latency: float64(time.Since(now)) / float64(time.Millisecond),
-			})
-		} else {
-			r.Data = append(r.Data, TCPingPEntry{
-				Success: true,
-				Latency: float64(time.Since(now)) / float64(time.Millisecond),
-			})
-			_ = conn.Close()
-		}
+		r.Data = append(r.Data, TCPingPEntry{
+			Success: err == nil,
+			Latency: float64(time.Since(now)) / float64(time.Millisecond),
+		})
+		_ = conn.Close()
 		timer.Stop()
 		cancel()
 		time.Sleep(time.Duration(q.Interval) * time.Millisecond)

tool/tls.go

@@ -225,6 +225,7 @@ func TLS(q *TlsQ) (*TlsP, error) {
 		cert := state.PeerCertificates[i-1]
 		hash := sha256.Sum256(cert.Raw)
 		data := Certificate{
+			Size:               len(cert.Raw),
 			Subject:            cert.Subject.String(),
 			Issuer:             cert.Issuer.String(),
 			NotBefore:          cert.NotBefore,

tool/types.go

@@ -153,6 +153,7 @@ const (
 )
 
 type Certificate struct {
+	Size  int  `json:"size,omitempty"`
 	Valid bool `json:"valid"`
 
 	Subject string `json:"subject"`