remove unnecessary checks and increase coverage

Author: tonnico

aws_lambda_powertools/event_handler/api_gateway.py

@@ -830,15 +830,12 @@ def _openapi_operation_parameters(
         return parameters
 
     @staticmethod
-    def _is_pydantic_model_param(field_info: ModelField | Param) -> bool:
+    def _is_pydantic_model_param(field_info: Param) -> bool:
         """Check if the field info represents a Pydantic model parameter."""
         from pydantic import BaseModel
 
         from aws_lambda_powertools.event_handler.openapi.compat import lenient_issubclass
-        from aws_lambda_powertools.event_handler.openapi.params import Param
 
-        if not isinstance(field_info, Param):
-            return False
         return lenient_issubclass(field_info.annotation, BaseModel)
 
     @staticmethod
@@ -850,9 +847,6 @@ def _expand_pydantic_model_parameters(field_info: Param) -> list[dict[str, Any]]
         parameters: list[dict[str, Any]] = []
 
         for field_name, field_def in model_class.model_fields.items():
-            if not field_def.annotation:
-                continue
-
             param_name = field_def.alias or field_name
             individual_param = Route._create_pydantic_field_parameter(
                 param_name=param_name,

tests/functional/event_handler/_pydantic/test_openapi_validation_middleware.py

@@ -323,6 +323,7 @@ def test_validate_pydantic_header_snake_case_to_kebab_case_schema(gw_event):
     class HeaderParams(BaseModel):
         correlation_id: str = Field(description="Correlation ID header")
         user_agent: str = Field(default="PowerTools/1.0", description="User agent header")
+        accept: str = Field(default="application/json")  # omit description to test optional description
 
     @app.get("/kebab-headers")
     def kebab_handler(my_headers: Annotated[HeaderParams, Header()]):
@@ -1124,8 +1125,8 @@ def handler2(header2: Annotated[List[int], Header()], header1: Annotated[str, He
 
         @app.get("/users")
         def handler3(
-            header2: Annotated[List[str], Header(name="Header2")],
-            header1: Annotated[str, Header(name="Header1")],
+            header2: Annotated[List[str], Header(alias="Header2")],
+            header1: Annotated[str, Header(alias="Header1")],
         ):
             print(header2)
 
@@ -1190,8 +1191,8 @@ def handler2(header2: Annotated[List[int], Header()], header1: Annotated[str, He
 
         @app.get("/users")
         def handler3(
-            header2: Annotated[List[str], Header(name="Header2")],
-            header1: Annotated[str, Header(name="Header1")],
+            header2: Annotated[List[str], Header(alias="Header2")],
+            header1: Annotated[str, Header(alias="Header1")],
         ):
             print(header2)
 
@@ -1253,8 +1254,8 @@ def handler2(header2: Annotated[List[int], Header()], header1: Annotated[str, He
 
         @app.get("/users")
         def handler3(
-            header2: Annotated[List[str], Header(name="Header2")],
-            header1: Annotated[str, Header(name="Header1")],
+            header2: Annotated[List[str], Header(alias="Header2")],
+            header1: Annotated[str, Header(alias="Header1")],
         ):
             print(header2)
 
@@ -1318,8 +1319,8 @@ def handler2(header2: Annotated[List[int], Header()], header1: Annotated[str, He
 
         @app.get("/users")
         def handler3(
-            header2: Annotated[List[str], Header(name="Header2")],
-            header1: Annotated[str, Header(name="Header1")],
+            header2: Annotated[List[str], Header(alias="Header2")],
+            header1: Annotated[str, Header(alias="Header1")],
         ):
             print(header2)
 
@@ -1382,8 +1383,8 @@ def handler2(header2: Annotated[List[int], Header()], header1: Annotated[str, He
 
         @app.get("/users")
         def handler3(
-            header2: Annotated[List[str], Header(name="Header2")],
-            header1: Annotated[str, Header(name="Header1")],
+            header2: Annotated[List[str], Header(alias="Header2")],
+            header1: Annotated[str, Header(alias="Header1")],
         ):
             print(header2)
 
@@ -1446,8 +1447,8 @@ def handler1(header2: Annotated[List[int], Header()], header1: Annotated[str, He
 
         @app.get("/users")
         def handler3(
-            header2: Annotated[List[str], Header(name="Header2")],
-            header1: Annotated[str, Header(name="Header1")],
+            header2: Annotated[List[str], Header(alias="Header2")],
+            header1: Annotated[str, Header(alias="Header1")],
         ):
             print(header2)