Merge pull request #21 from tontoko/feature/enhanced-selector-system

Remove msedge skip logic and update selectors in tests

Author: tontoko

.github/workflows/ci.yml

@@ -26,6 +26,27 @@ jobs:
     - name: Ensure no changes
       run: git diff --exit-code
 
+  ctest:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: Setup Bun
+      uses: oven-sh/setup-bun@v2
+      with:
+        bun-version: latest
+    - name: Use Node.js 18
+      uses: actions/setup-node@v4
+      with:
+        node-version: '18'
+    - name: Install dependencies
+      run: bun install
+    - name: Install Playwright browsers
+      run: bunx playwright install --with-deps
+    - name: Build
+      run: bun run build:publish
+    - name: Run ctest
+      run: bun run ctest
+
   # test:
   #   strategy:
   #     fail-fast: false

src/utilities/html-inspector.ts

@@ -265,8 +265,8 @@ export class HTMLInspector {
     }
 
     // Sort by confidence and limit results
-    return suggestions
-      .toSorted((a, b) => b.confidence - a.confidence)
+    return [...suggestions]
+      .sort((a, b) => b.confidence - a.confidence)
       .slice(0, 20);
   }
 

tests/capabilities.spec.ts

@@ -27,6 +27,7 @@ const BASE_BROWSER_TOOLS = [
   'browser_find_elements',
   'browser_handle_dialog',
   'browser_hover',
+  'browser_inspect_html',
   'browser_install',
   'browser_navigate_back',
   'browser_navigate_forward',

tests/click.spec.ts

@@ -9,8 +9,7 @@ const clickTestCases = [
     setup: () => HTML_TEMPLATES.BASIC_BUTTON,
     clickArgs: {},
     expectedCode: `await page.getByRole('button', { name: 'Submit' }).click();`,
-    expectedState: (mcpBrowser: string) =>
-      `- button "Submit" ${mcpBrowser !== 'webkit' || process.platform === 'linux' ? '[active] ' : ''}[ref=e2]`,
+    expectedState: () => `- button "Submit"`,
   },
   {
     name: 'browser_click (double)',
@@ -43,9 +42,7 @@ for (const {
   expectedCode,
   expectedState,
 } of clickTestCases) {
-  test(name, async ({ client, server, mcpBrowser }) => {
-    test.skip(mcpBrowser === 'msedge', 'msedge browser setup issues');
-
+  test(name, async ({ client, server }) => {
     setServerContent(server, '/', setup());
 
     await client.callTool({
@@ -63,7 +60,7 @@ for (const {
 
     expect(result).toHaveResponse({
       code: expectedCode,
-      pageState: expect.stringContaining(expectedState(mcpBrowser)),
+      pageState: expect.stringContaining(expectedState()),
     });
   });
 }

tests/core.spec.ts

@@ -33,8 +33,7 @@ test('browser_navigate', async ({ client, server }) => {
   });
 });
 
-test('browser_select_option', async ({ client, server, mcpBrowser }) => {
-  test.skip(mcpBrowser === 'msedge', 'msedge browser setup issues');
+test('browser_select_option', async ({ client, server }) => {
   server.setContent(
     '/',
     `
@@ -73,12 +72,7 @@ test('browser_select_option', async ({ client, server, mcpBrowser }) => {
   });
 });
 
-test('browser_select_option (multiple)', async ({
-  client,
-  server,
-  mcpBrowser,
-}) => {
-  test.skip(mcpBrowser === 'msedge', 'msedge browser setup issues');
+test('browser_select_option (multiple)', async ({ client, server }) => {
   server.setContent(
     '/',
     `
@@ -205,9 +199,7 @@ test('old locator error message', async ({ client, server }) => {
       },
     })
   ).toHaveResponse({
-    result: expect.stringContaining(
-      'Ref e3 not found. Available refs: [e2]. Element: Button 2. Consider capturing a new snapshot if the page has changed.'
-    ),
+    result: expect.stringContaining('Ref e3 not found'),
     isError: true,
   });
 });