Commit 4bb774f
committed
chore: switch to @tony.ganchev/eslint-plugin-header
Hi, team,
I noticed you are using _eslint-plugin-header_ on ESLint 8.
I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to add support
for ESLint 9 and hoped it would be a temporary measure but since the
original has not been updated for five years I decided to continue
improving the new plugin and have been doing so for the last two years.
Specific improvements include:
- full JSON schema for validating the configuration.
- fixed multiple bugs with the behavior of the plugin on Windows.
- many other bug-fixes.
- improved autofixing and error-reporting behavior.
- added support for leading pragma comments before the header such as
`@jest-environment` or `eslint-env`. In the case of the current
review, this allowed me to remove the `eslint-disable` directive from
one file and reintroduce validation.
I switched the configuration to use the new config format for v3.2.x
as the leading comments feature is not supported by the array-based
format inherited from _eslint-plugin-header_.
I've sent PR proposals to other projects in the _cloudscape-design_
space:
- cloudscape-design/board-components#401
- cloudscape-design/browser-test-tools#188
- cloudscape-design/chart-components#185
- cloudscape-design/code-view#122
- cloudscape-design/collection-hooks#136
- cloudscape-design/component-toolkit#200
- cloudscape-design/components#4308
- cloudscape-design/demos#243
- cloudscape-design/documenter#112
- cloudscape-design/global-styles#73
- cloudscape-design/jest-preset#58
- cloudscape-design/test-utils#114
- cloudscape-design/theming-core#148
Looking forward to your feedback.1 parent cd08e74 commit 4bb774f
File tree
4 files changed
+28
-17
lines changed- src/__tests__
4 files changed
+28
-17
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | | - | |
60 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
61 | 73 | | |
62 | 74 | | |
63 | 75 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
| |||
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
90 | | - | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
0 commit comments