Commit 2d8d19b
committed
chore: switch to @tony.ganchev/eslint-plugin-header
Hi, team,
I noticed you are using eslint-plugin-header on ESLint 8.
I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to add support
for ESLint 9 and hoped it would be a temporary measure but since the
original has not been updated for five years I decided to continue
improving the new plugin and have been doing so for the last two years.
Specific improvements include:
- full JSON schema for validating the configuration.
- fixed multiple bugs with the behavior of the plugin on Windows.
- many other bug-fixes.
- improved autofixing and error-reporting behavior.
- added support for leading pragma comments before the header such as
`@jest-environment``. In the case of the current review, this allowed
me to remove the `eslint-disable` directive from two tests and
reintroduce validation which was actually failing because of the
missing empty line after the header.
I switched the configuration to use the new config format for v3.2.x
as the leading comments feature is not supported by the array-based
format inherited from _eslint-plugin-header_.
I've sent PR proposals to other projects in the _cloudscape-design_
space:
- cloudscape-design/collection-hooks#136
- cloudscape-design/components#4308
- cloudscape-design/demos#243
- cloudscape-design/test-utils#114
Looking forward to your feedback.1 parent 03e7cca commit 2d8d19b
File tree
5 files changed
+340
-200
lines changed- src/internal
- global-flags/__tests__
- visual-mode/__tests__
5 files changed
+340
-200
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
61 | 79 | | |
62 | 80 | | |
63 | 81 | | |
| |||
0 commit comments