Album.GetInfo()

[DukeNuken]

Hey.

For some reason when I try get info for album it am getting error "Response cannot get data"

api.Album.GetInfo("White EP","Howie Day");

[DukeNuken]

I see the problems

1. public class AlbumWithDetails : Album
   public DateTime? ReleaseDate // can be null

2. public class Track
   public int? Duration //can be null

[topas]

Hi,

thank you for the investigation! I am working on a fix. You can expected new NuGet package soon.

[topas]

NuGet package 1.0.4 uploaded. Can you please check it, please?

[DukeNuken]

Thanks. Actually I use more advenced version of your tool. I add everywhere
support for mbid request, You really should do it because it is core logic.
I can commit it to your git if you want.

Duke

2013/10/8 Tomáš Pastorek notifications@github.com

NuGet package 1.0.4 uploaded. Can you please check it, please?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-25847804
.

[topas]

Hi,

Sure, pull request are always welcome! Only respect code conventions and make tests for all your changes.

Thank you!

[DukeNuken]

When I try commit i see an error

remote: Permission to topas/dotLastFm.git denied to DukeNuken.
fatal: unable to access 'https://github.com/topas/dotLastFm/': The requested URL returned error: 403

[topas]

Hi,

You cannot push changes to my resporitory. You have to fork it. If you already have a fork don't forget update it (merge/rebase) to current version of my repo. After that you can push changes to your fork and create pull request on GitHub. Here is nice tutorial: https://help.github.com/articles/fork-a-repo

[DukeNuken]

I made fork on your repo. Not sure if I didnt it correctly :)

[topas]

It seems like in your repository are changes from me. You updated file manually from my repo? You should use upstream merge https://help.github.com/articles/fork-a-repo#pull-in-upstream-changes to get your repository current and ready for your commits.

[DukeNuken]

Sorry man I am never work with git before and really dont like those games with repos. You can check my changes and copy to your project or just ignore it.

[DukeNuken]

Also your code with new Deserializer not working good, For example if value empty and type int32 it is die with error

else if (type.IsPrimitive)
{
        prop.SetValue(x, value.ChangeType(type, Culture), null); //value ==> "" type => Int32
}

[topas]

Hi,

This isn't problem with deserializer but property listeners and playcount should be nullable int. I will fix it.

And your changes... You should really learn how to git and GitHub work. Separating your code from your not actual fork is a bit hard and not helping. Knowledge of git is one of basic skill of today's developer.