Skip to content

Commit c0de22c

Browse files
authored
Merge pull request #1394 from topcoder-platform/PM-2631_allow-checkpoint-reviewers-to-see-reviews
PM-2631 - allow checkpoint reviewers to see reviews
2 parents 18ef8ef + 26ff852 commit c0de22c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentReview.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,12 @@ export const TabContentReview: FC<Props> = (props: Props) => {
222222
},
223223
[challengeInfo?.status],
224224
)
225+
226+
const isSubmitterView = actionChallengeRole === SUBMITTER
227+
&& selectedTab !== APPROVAL
228+
225229
const hasPassedReviewThreshold = useMemo(
226-
() => hasSubmitterPassedThreshold(
230+
() => !isSubmitterView || hasSubmitterPassedThreshold(
227231
providedReviews ?? [],
228232
myOwnedMemberIds,
229233
props.reviewMinimumPassingScore,
@@ -673,8 +677,6 @@ export const TabContentReview: FC<Props> = (props: Props) => {
673677
&& actionChallengeRole === REVIEWER
674678

675679
// show loading ui when fetching data
676-
const isSubmitterView = actionChallengeRole === SUBMITTER
677-
&& selectedTab !== APPROVAL
678680
const reviewRows = isSubmitterView
679681
? (shouldSortReviewTabByScore ? submitterRowsForReviewTab : filteredSubmitterReviews)
680682
: (shouldSortReviewTabByScore ? reviewerRowsForReviewTab : filteredReviews)

0 commit comments

Comments
 (0)