feat: add metric for ping handler update room failures

Author: ffelipelimao

internal/api/handlers/metrics.go

@@ -0,0 +1,41 @@
+// MIT License
+//
+// Copyright (c) 2021 TFG Co
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in all
+// copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+// SOFTWARE.
+
+package handlers
+
+import (
+	"github.com/topfreegames/maestro/internal/core/monitoring"
+)
+
+var pingHandlerUpdateRoomFailuresMetric = monitoring.CreateCounterMetric(&monitoring.MetricOpts{
+	Namespace: monitoring.Namespace,
+	Subsystem: monitoring.SubsystemApi,
+	Name:      "ping_handler_update_room_failures",
+	Help:      "Number of failures in UpdateRoomWithPing handler when calling UpdateRoom",
+	Labels: []string{
+		monitoring.LabelScheduler,
+	},
+})
+
+func reportPingHandlerUpdateRoomFailure(schedulerName string) {
+	pingHandlerUpdateRoomFailuresMetric.WithLabelValues(schedulerName).Inc()
+}

internal/api/handlers/rooms_handler.go

@@ -90,6 +90,7 @@ func (h *RoomsHandler) UpdateRoomWithPing(ctx context.Context, message *api.Upda
 	err = h.roomManager.UpdateRoom(ctx, gameRoom)
 	if err != nil {
 		handlerLogger.Error("error updating room with ping", zap.Any("ping", message), zap.Error(err))
+		reportPingHandlerUpdateRoomFailure(message.SchedulerName)
 		return &api.UpdateRoomWithPingResponse{Success: false}, nil
 	}