Skip to content

Commit edd57a8

Browse files
joaobolognajoao.bologna
andauthored
Fix error omission while creating room in runtime (#681)
* Fix error omission while creating room in runtime --------- Co-authored-by: joao.bologna <joao.bologna@wildlifestudios.com>
1 parent a2924b7 commit edd57a8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

internal/core/services/rooms/room_manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ func (m *RoomManager) createRoomOnStorageAndRuntime(ctx context.Context, schedul
445445
if err != nil {
446446
deleteRoomErr := m.RoomStorage.DeleteRoom(ctx, scheduler.Name, room.ID)
447447
if deleteRoomErr != nil {
448-
return nil, nil, fmt.Errorf("error deleting room during create game room instance error: %w", deleteRoomErr)
448+
return nil, nil, errors.Join(fmt.Errorf("error creating game room and cleaning up room on storage"), err, deleteRoomErr)
449449
}
450450
return nil, nil, err
451451
}

internal/core/services/rooms/room_manager_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,9 @@ func TestRoomManager_CreateRoom(t *testing.T) {
195195
roomStorage.EXPECT().DeleteRoom(context.Background(), scheduler.Name, gameRoom.ID).Return(fmt.Errorf("error deleting room"))
196196

197197
room, instance, err := roomManager.CreateRoom(context.Background(), scheduler, false)
198-
assert.EqualError(t, err, "error deleting room during create game room instance error: error deleting room")
198+
assert.ErrorContains(t, err, "error creating game room and cleaning up room on storage")
199+
assert.ErrorContains(t, err, "error creating game room on runtime")
200+
assert.ErrorContains(t, err, "error deleting room")
199201
assert.Nil(t, room)
200202
assert.Nil(t, instance)
201203
})

0 commit comments

Comments
 (0)