fix(metrics): ReportHistogram impl for stasd (#464)

* fix(metrics): ReportHistogram impl for stasd
* chore(docker): replace deprecated bitnami/etcd
* chore(ci): run CI on go 1.24 due to deps issue
* chore: update missing mocks

Author: hspedro

.github/workflows/tests.yaml

@@ -20,7 +20,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: '1.23'
+        go-version: '1.24'
     - name: Download dependencies
       run: go mod download
   unit-test:
@@ -33,7 +33,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: '1.23'
+        go-version: '1.24'
     - name: Setup dependencies
       env:
         GO111MODULE: auto
@@ -56,7 +56,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: '1.23'
+        go-version: '1.24'
     - name: Run tests
       run: make e2e-test-nats
   e2e-test-grpc:
@@ -69,6 +69,6 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: '1.23'
+        go-version: '1.24'
     - name: Run tests
       run: make e2e-test-grpc

examples/testing/docker-compose.yml

@@ -1,13 +1,14 @@
-version: '3'
 services:
   nats:
     image: nats
     ports:
       - 4222:4222
   etcd:
-    image: bitnami/etcd
-    environment:
-      - ALLOW_NONE_AUTHENTICATION=yes
+    image: quay.io/coreos/etcd:v3.5.15
+    command:
+      - /usr/local/bin/etcd
+      - --listen-client-urls=http://0.0.0.0:2379
+      - --advertise-client-urls=http://0.0.0.0:2379
     ports:
       - 2379:2379
   redis:

metrics/mocks/statsd_reporter.go

@@ -51,6 +51,8 @@ type PrometheusReporter struct {
 	additionalLabels      map[string]string
 }
 
+var _ Reporter = (*PrometheusReporter)(nil)
+
 func (p *PrometheusReporter) registerCustomMetrics(
 	constLabels map[string]string,
 	additionalLabelsKeys []string,

metrics/prometheus_reporter.go

@@ -23,8 +23,6 @@ package metrics
 import (
 	"fmt"
 
-	"github.com/topfreegames/pitaya/v2/constants"
-
 	"github.com/DataDog/datadog-go/statsd"
 	"github.com/topfreegames/pitaya/v2/config"
 	"github.com/topfreegames/pitaya/v2/logger"
@@ -35,6 +33,7 @@ type Client interface {
 	Count(name string, value int64, tags []string, rate float64) error
 	Gauge(name string, value float64, tags []string, rate float64) error
 	TimeInMilliseconds(name string, value float64, tags []string, rate float64) error
+	Histogram(name string, value float64, tags []string, rate float64) error
 }
 
 // StatsdReporter sends application metrics to statsd
@@ -45,6 +44,8 @@ type StatsdReporter struct {
 	defaultTags []string
 }
 
+var _ Reporter = (*StatsdReporter)(nil)
+
 // NewStatsdReporter returns an instance of statsd reportar and an
 // error if something fails
 func NewStatsdReporter(
@@ -143,5 +144,16 @@ func (s *StatsdReporter) ReportSummary(metric string, tagsMap map[string]string,
 
 // ReportHistogram observes the histogram value and reports to statsd
 func (s *StatsdReporter) ReportHistogram(metric string, tagsMap map[string]string, value float64) error {
-	return constants.ErrNotImplemented
+	fullTags := s.defaultTags
+
+	for k, v := range tagsMap {
+		fullTags = append(fullTags, fmt.Sprintf("%s:%s", k, v))
+	}
+
+	err := s.client.Histogram(metric, value, fullTags, s.rate)
+	if err != nil {
+		logger.Log.Errorf("failed to report histogram: %q", err)
+	}
+
+	return err
 }