Add support for raw ArrayBuffer

Author: surma

lib/asbind-instance/bind-function.js

@@ -42,13 +42,29 @@ function putString(asbindInstance, value, typeName) {
   return asbindInstance.exports.__newString(value);
 }
 
+function getArrayBuffer(asbindInstance, value, typeName) {
+  return asbindInstance.exports.__getArrayBuffer(value);
+}
+
+function putArrayBuffer(asbindInstance, value, typeName) {
+  const ptr = asbindInstance.exports.__new(
+    value.byteLength,
+    getTypeId(asbindInstance, typeName)
+  );
+  new Uint8Array(
+    asbindInstance.exports.memory.buffer,
+    ptr,
+    value.byteLength
+  ).set(new Uint8Array(value));
+  return ptr;
+}
+
 function getArrayBufferView(asbindInstance, value, typeName) {
   return asbindInstance.exports[
     `__get${normalizeArrayBufferViewTypeName(typeName)}View`
   ](value);
 }
-
-function putArrayBuffer(asbindInstance, value, typeName) {
+function putArrayBufferView(asbindInstance, value, typeName) {
   return asbindInstance.exports.__newArray(
     getTypeId(asbindInstance, typeName),
     value
@@ -92,19 +108,23 @@ const converters = new Map([
   [/^~lib\/string\/String$/, { ascToJs: getString, jsToAsc: putString }],
   [
     /^~lib\/typedarray\/(Ui|I)nt(8|16|32)Array$/,
-    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+    { ascToJs: getArrayBufferView, jsToAsc: putArrayBufferView }
   ],
   [
     /^~lib\/typedarray\/Big(Ui|I)nt64Array$/,
-    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+    { ascToJs: getArrayBufferView, jsToAsc: putArrayBufferView }
   ],
   [
     /^~lib\/typedarray\/Uint8ClampedArray$/,
-    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+    { ascToJs: getArrayBufferView, jsToAsc: putArrayBufferView }
   ],
   [
     /^~lib\/typedarray\/Float(32|64)Array$/,
-    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+    { ascToJs: getArrayBuffer, jsToAsc: putArrayBufferView }
+  ],
+  [
+    /^~lib\/arraybuffer\/ArrayBuffer$/,
+    { ascToJs: getArrayBuffer, jsToAsc: putArrayBuffer }
   ],
   [/^~lib\/array\/Array<.+>$/, { ascToJs: getArray, jsToAsc: putArray }]
 ]);

test/tests/arraybuffer/asc.ts

@@ -0,0 +1,10 @@
+export function swapAndPad(a: ArrayBuffer, b: ArrayBuffer): ArrayBuffer {
+  const intermediate = Uint8Array.wrap(swappedConcat(a, b));
+  const result = new Uint8Array(intermediate.length + 2);
+  result.set(intermediate, 1);
+  result[0] = 255;
+  result[result.length - 1] = 255;
+  return result.buffer;
+}
+
+declare function swappedConcat(a: ArrayBuffer, b: ArrayBuffer): ArrayBuffer;

test/tests/arraybuffer/test.js

@@ -0,0 +1,24 @@
+describe("as-bind", function() {
+  it("should handle ArrayBuffers", async function() {
+    const instance = await AsBind.instantiate(this.rawModule, {
+      asc: {
+        swappedConcat(a, b) {
+          a = new Uint8Array(a);
+          b = new Uint8Array(b);
+          const result = new Uint8Array(a.length + b.length);
+          result.set(b, 0);
+          result.set(a, b.length);
+          return result.buffer;
+        }
+      }
+    });
+    assert(
+      new Uint8Array(
+        instance.exports.swapAndPad(
+          new Uint8Array([1, 2, 3]).buffer,
+          new Uint8Array([10, 11, 12]).buffer
+        )
+      ).join(",") === new Uint8Array([255, 10, 11, 12, 1, 2, 3, 255]).join(",")
+    );
+  });
+});