Only warn once

surma · surma · commit c74f88e5ea5d · 2021-03-15T20:08:20.000Z
diff --git a/lib/asbind-instance/bind-function.js b/lib/asbind-instance/bind-function.js
@@ -72,15 +72,19 @@ const converters = new Map([
   ]
 ]);
 
+const warned = new Set();
 function getConverterForType(typeName) {
   for (const [matcher, converter] of converters) {
     if (matcher.test(typeName)) {
       return converter;
     }
   }
-  console.warn(
-    `No converter for ${JSON.stringify(typeName)}, using pass-through`
-  );
+  if (!warned.has(typeName)) {
+    console.warn(
+      `No converter for ${JSON.stringify(typeName)}, using pass-through`
+    );
+    warned.add(typeName);
+  }
   return { ascToJs: nop, jsToAsc: nop };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -72,15 +72,19 @@ const converters = new Map([`
`72`	`72`	`]`
`73`	`73`	`]);`
`74`	`74`
	`75`	`+const warned = new Set();`
`75`	`76`	`function getConverterForType(typeName) {`
`76`	`77`	`for (const [matcher, converter] of converters) {`
`77`	`78`	`if (matcher.test(typeName)) {`
`78`	`79`	`return converter;`
`79`	`80`	`}`
`80`	`81`	`}`
`81`		`- console.warn(`
`82`		- `No converter for ${JSON.stringify(typeName)}, using pass-through`
`83`		`- );`
	`82`	`+ if (!warned.has(typeName)) {`
	`83`	`+ console.warn(`
	`84`	+ `No converter for ${JSON.stringify(typeName)}, using pass-through`
	`85`	`+ );`
	`86`	`+ warned.add(typeName);`
	`87`	`+ }`
`84`	`88`	`return { ascToJs: nop, jsToAsc: nop };`
`85`	`89`	`}`
`86`	`90`