Refactor converter map

Author: surma

lib/asbind-instance/bind-function.js

@@ -44,44 +44,44 @@ function putArrayBuffer(asbindInstance, value, typeName) {
   );
 }
 
-const ascToJsConverters = new Map([
-  [/void/, nop],
-  [/(i|u)(8|16|32)/, nop],
-  [/f(32|64)/, nop],
-  [/[sS]tring/, getString],
-  [/(Ui|I)nt(8|16|32)Array/, getArrayBufferView],
-  [/Big(Ui|I)nt64Array/, getArrayBufferView],
-  [/Uint8ClampedArray/, getArrayBufferView],
-  [/Float(32|64)Array/, getArrayBufferView]
+const converters = new Map([
+  [/void/, { ascToJs: nop, jsToAsc: nop }],
+  [/(i|u)(8|16|32)/, { ascToJs: nop, jsToAsc: nop }],
+  [/f(32|64)/, { ascToJs: nop, jsToAsc: nop }],
+  [/[sS]tring/, { ascToJs: getString, jsToAsc: putString }],
+  [
+    /(Ui|I)nt(8|16|32)Array/,
+    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+  ],
+  [
+    /Big(Ui|I)nt64Array/,
+    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+  ],
+  [
+    /Uint8ClampedArray/,
+    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+  ],
+  [
+    /Float(32|64)Array/,
+    { ascToJs: getArrayBufferView, jsToAsc: putArrayBuffer }
+  ]
 ]);
 
-function getAscToJsConverterForType(typeName) {
-  for (const [matcher, converter] of ascToJsConverters) {
+function getConverterForType(typeName) {
+  for (const [matcher, converter] of converters) {
     if (matcher.test(typeName)) {
       return converter;
     }
   }
-  throw Error(`No AscToJs converter for ${JSON.stringify(typeName)}`);
+  throw Error(`No converter for ${JSON.stringify(typeName)}`);
 }
 
-const jsToAscConverters = new Map([
-  [/void/, nop],
-  [/(i|u)(8|16|32)/, nop],
-  [/f(32|64)/, nop],
-  [/[sS]tring/, putString],
-  [/(Ui|I)nt(8|16|32)Array/, putArrayBuffer],
-  [/Big(Ui|I)nt64Array/, putArrayBuffer],
-  [/Uint8ClampedArray/, putArrayBuffer],
-  [/Float(32|64)Array/, putArrayBuffer]
-]);
+function getAscToJsConverterForType(typeName) {
+  return getConverterForType(typeName)?.ascToJs;
+}
 
 function getJsToAscConverterForType(typeName) {
-  for (const [matcher, converter] of jsToAscConverters) {
-    if (matcher.test(typeName)) {
-      return converter;
-    }
-  }
-  throw Error(`No JsToAsc converter for ${JSON.stringify(typeName)}`);
+  return getConverterForType(typeName)?.jsToAsc;
 }
 
 // Function that takes in an asbindInstance, and importObject, and the path to the import function on the object