Derive ids from RTTI #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So after taking a look at your PR, it looks good! And I tested the code very thoroughly, so if it passes the tests. Should be good to go! Though I may re-architect some things if we go down this route, as the supported types could probably be simplified quite a bit 😄 That being said though, before we move forward with this, I'd like to hear your response to my comment in #20 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of the suggestion made in #20, that is deriving the ids of the typed arrays from runtime type information instead of requiring the user to provide an additional entry file. Cornerstones are that the ids of
ArrayBuffer,StringandArrayBufferVieware fixed, and all the typed arrays have common properties in RTTI.Leaving this as a draft for now, since it so far intentionally tries to touch as few code as possible to pass
npm test. Let me know what you think :)