Adjust rules based on trial

Author: thibaudcolas

src/typescript.rules.test.js

@@ -14,7 +14,10 @@ describe('semver for TypeScript rules - should those tests break, consider relea
         expect(computed).toMatchInlineSnapshot(`
             Object {
               "env": Object {
+                "browser": true,
+                "commonjs": true,
                 "es6": true,
+                "jest": true,
                 "node": true,
               },
               "globals": Object {},
@@ -171,7 +174,7 @@ describe('semver for TypeScript rules - should those tests break, consider relea
                   "error",
                 ],
                 "@typescript-eslint/no-var-requires": Array [
-                  "error",
+                  0,
                 ],
                 "@typescript-eslint/object-curly-spacing": Array [
                   "off",
@@ -3004,4 +3007,42 @@ describe('semver for TypeScript rules - should those tests break, consider relea
             }
         `);
     });
+
+    it('has stable overrides', () => {
+        /**
+         * Overrides are snapshotted directly because:
+         * - They aren’t computed in the base configuration (which snapshots the configuration for a `.js` file).
+         * - They’re only at the top level, so it’s enough to snapshot their top-level definition only.
+         */
+        expect(config.overrides).toMatchInlineSnapshot(`
+            Array [
+              Object {
+                "files": Array [
+                  "*.ts",
+                  "*.tsx",
+                ],
+                "rules": Object {
+                  "constructor-super": "off",
+                  "getter-return": "off",
+                  "import/named": "off",
+                  "import/no-unresolved": "off",
+                  "no-const-assign": "off",
+                  "no-dupe-args": "off",
+                  "no-dupe-class-members": "off",
+                  "no-dupe-keys": "off",
+                  "no-func-assign": "off",
+                  "no-new-symbol": "off",
+                  "no-obj-calls": "off",
+                  "no-redeclare": "off",
+                  "no-this-before-super": "off",
+                  "no-undef": "off",
+                  "no-unreachable": "off",
+                  "no-unsafe-negation": "off",
+                  "react/require-default-props": 0,
+                  "valid-typeof": "off",
+                },
+              },
+            ]
+        `);
+    });
 });

typescript.js

@@ -273,6 +273,9 @@ module.exports = {
             'node_modules/@types',
         ],
     },
+    env: {
+        ...base.env,
+    },
     rules: {
         ...base.rules,
         ...airbnbTypeScript,
@@ -289,13 +292,18 @@ module.exports = {
             },
         ],
         'react/jsx-filename-extension': [2, { extensions: ['.js', '.tsx'] }],
+        // Disabled so we can lint Node files (Webpack, Vite, Jest) more easily.
+        '@typescript-eslint/no-var-requires': 0,
     },
     overrides: [
         {
-            // Copy from eslint-config-airbnb-typescript
-            // https://github.com/iamturns/eslint-config-airbnb-typescript/blob/d30b7d2a41f3f2cf899cad3ed69e3b7eacbc7234/lib/shared.js#L256
             files: ['*.ts', '*.tsx'],
             rules: {
+                // This is not needed in TypeScript, where `defaultProps` aren’t used,
+                // and function default parameters are introspect-able by the type checker.
+                'react/require-default-props': 0,
+                // Copy from eslint-config-airbnb-typescript
+                // https://github.com/iamturns/eslint-config-airbnb-typescript/blob/d30b7d2a41f3f2cf899cad3ed69e3b7eacbc7234/lib/shared.js#L256
                 // The following rules are enabled in Airbnb config, but are already checked (more thoroughly) by the TypeScript compiler
                 // Some of the rules also fail in TypeScript files, for example: https://github.com/typescript-eslint/typescript-eslint/issues/662#issuecomment-507081586
                 'constructor-super': 'off',