Skip to content

Commit d52b774

Browse files
committed
Stop enforcing a11y/content-property-no-static-value, which feels too restrictive for projects already following best practices
1 parent be3d2ee commit d52b774

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
66

77
## Unreleased
88

9+
### Features
10+
11+
- Stop enforcing `a11y/content-property-no-static-value`, which feels too restrictive for projects already following best practices.
12+
913
### Bug fixes
1014

1115
- Fix `scale-unlimited/declaration-strict-value` being applied twice to `background-color` declarations.

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ To get the most out of this config, it is assumed that projects have the followi
7373
- [`scss/at-mixin-argumentless-call-parentheses`](https://github.com/kristerkari/stylelint-scss#readme): `always`
7474
- [`scss/at-mixin-pattern`](https://github.com/kristerkari/stylelint-scss#readme): ``
7575
- [`order/order`](https://github.com/hudochenkov/stylelint-order): `dollar-variables, custom-properties, type: at-rule, hasBlock: false, declarations`
76-
- [`a11y/content-property-no-static-value`](https://github.com/YozhikM/stylelint-a11y#readme)
7776
- [`a11y/no-obsolete-attribute`](https://github.com/YozhikM/stylelint-a11y#readme)
7877
- [`a11y/no-obsolete-element`](https://github.com/YozhikM/stylelint-a11y#readme)
7978
- [`a11y/no-text-align-justify`](https://github.com/YozhikM/stylelint-a11y#readme)

config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ module.exports = {
5454
{ type: 'at-rule', hasBlock: false },
5555
'declarations',
5656
],
57-
'a11y/content-property-no-static-value': true,
5857
'a11y/no-obsolete-attribute': true,
5958
'a11y/no-obsolete-element': true,
6059
'a11y/no-text-align-justify': true,

src/__snapshots__/semver.test.js.snap

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
exports[`semver - should those tests break, consider releasing a new major version of the package config contents 1`] = `
44
Object {
5-
"a11y/content-property-no-static-value": Array [
6-
true,
7-
],
85
"a11y/no-obsolete-attribute": Array [
96
true,
107
],

src/unused.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ const tooOpinionated = [
6161
'scss/dollar-variable-default',
6262
'scss/no-dollar-variables',
6363
'order/properties-alphabetical-order',
64+
// This is useful in principle, but a blanket ban means lots of manual work to add "disable"
65+
// comments whenever `content` is used for decorative purposes only, e.g. breadcrumb / menu separators.
66+
'a11y/content-property-no-static-value',
6467
'a11y/font-size-is-readable',
6568
'a11y/line-height-is-vertical-rhythmed',
6669
'a11y/media-prefers-color-scheme',

0 commit comments

Comments
 (0)