Skip to content

Commit 8491e27

Browse files
committed
Update to improve use of semantic tags, layout & styling
1 parent 804ec63 commit 8491e27

File tree

3 files changed

+34
-17
lines changed

3 files changed

+34
-17
lines changed

tbx/project_styleguide/templates/patterns/organisms/footer/footer.html

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,14 @@
6363
{% endif %}
6464
{% endwith %}
6565
</div>
66-
67-
</div>
68-
<div class="grid">
69-
<div class="grid__footer-address">
70-
<div class="footer__address">
71-
<p class="footer__address-text">3rd Floor, 15 Colston St, Bristol BS1 5AP. Registered in England and Wales. Company No. 3983354. VAT No. 752981011.</p>
66+
<div class="grid__footer-company">
67+
<div class="footer__company">
68+
<div class="footer__company-address">
69+
<p>© Torchbox {% now "Y" %} - </p><address>3rd Floor, 15 Colston St, Bristol, BS1 5AP</address>
70+
</div>
71+
<div>
72+
<p>Registered in England &amp; Wales. Company no. 3983354, VAT no. 752981011</p>
73+
</div>
7274
</div>
7375
</div>
7476
</div>

tbx/static_src/sass/components/_footer.scss

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,6 @@
7777
}
7878
}
7979

80-
&__address {
81-
text-align: center;
82-
padding-bottom: $spacer-small;
83-
}
84-
85-
&__address-text {
86-
color: var(--color--grey-20);
87-
}
88-
8980
&__logo-link {
9081
display: flex;
9182
align-items: center;
@@ -105,6 +96,28 @@
10596
}
10697
}
10798

99+
&__company {
100+
display: flex;
101+
flex-direction: column;
102+
height: 100%;
103+
margin: $spacer-medium 0 $spacer-mini;
104+
color: var(--color--grey-20);
105+
106+
@include media-query(large) {
107+
justify-content: center;
108+
margin: 0;
109+
}
110+
}
111+
112+
&__company-address {
113+
font-weight: 600;
114+
115+
> * {
116+
font-style: normal;
117+
display: inline;
118+
}
119+
}
120+
108121
&__carbon-impact-container {
109122
background-color: var(--color--footer-background);
110123
border-top: 1px solid var(--color--border);

tbx/static_src/sass/components/_grid.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,13 @@
277277
}
278278
}
279279

280-
&__footer-address {
280+
&__footer-company {
281281
grid-column: 2 / span 4;
282+
grid-row: 2;
282283

283284
@include media-query(large) {
284-
grid-column: 2 / span 12;
285+
grid-column: 10 / span 4;
286+
grid-row: auto;
285287
}
286288
}
287289

0 commit comments

Comments
 (0)