Switch to fetchcontent instead of submodules

Author: toroidal-code

.clang-tidy

@@ -0,0 +1,55 @@
+---
+Checks: >
+  -*,
+  readability-braces-around-statements,
+  clang-diagnostic-*,
+  clang-analyzer-*,
+  cppcoreguidelines-*,
+  cppcoreguidelines-*,
+  readability-*,
+  modernize-*,
+  bugprone-*,
+  chromium-include-order,
+  performance-for-range-copy,
+  performance-implicit-conversion-in-loop,
+  performance-inefficient-algorithm,
+  performance-inefficient-string-concatenation,
+  performance-inefficient-vector-operation,
+  performance-move-const-arg,
+  performance-move-constructor-init,
+  performance-no-automatic-move,
+  performance-no-int-to-ptr,
+  performance-trivially-destructible,
+  performance-type-promotion-in-math-fn,
+  performance-unnecessary-copy-initialization,
+  performance-unnecessary-value-param,
+  -modernize-use-trailing-return-type,
+  -modernize-avoid-c-arrays,
+  -bugprone-easily-swappable-parameters,
+  -cppcoreguidelines-avoid-non-const-global-variables,
+  -cppcoreguidelines-avoid-magic-numbers,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  -cppcoreguidelines-special-member-functions,
+  -cppcoreguidelines-pro-bounds-constant-array-index,
+  -cppcoreguidelines-non-private-member-variables-in-classes,
+  -readability-uppercase-literal-suffix,
+  -readability-identifier-length,
+  -readability-magic-numbers
+WarningsAsErrors: false # should be true once we get there
+#HeaderFileExtensions:         ['h','hh','hpp','hxx'] # enable iff clang-tidy v17+
+#ImplementationFileExtensions: ['c','cc','cpp','cxx'] # enable iff clang-tidy v17+ (stops from touching .S assembly files)
+HeaderFilterRegex: ".*"
+AnalyzeTemporaryDtors: false
+ExtraArgs: ['-Wno-unknown-argument', '-Wno-unknown-warning-option', '-W']
+FormatStyle: file
+CheckOptions:
+  - key: cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
+    value: "1"
+  - key: cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
+    value: "1"
+  - key: modernize-loop-convert.IncludeStyle
+    value: google
+  - key: modernize-pass-by-value.IncludeStyle
+    value: google
+  - key: modernize-replace-auto-ptr.IncludeStyle
+    value: google

.gitmodules

@@ -0,0 +1,5 @@
+{
+  "recommendations": [
+    "llvm-vs-code-extensions.vscode-clangd"
+  ]
+}

.vscode/extensions.json

@@ -74,5 +74,30 @@
     "xmemory": "cpp",
     "xstring": "cpp",
     "xtree": "cpp"
-  }
+  },
+  "C_Cpp.intelliSenseEngine": "disabled",
+  "C_Cpp.autocomplete": "disabled",
+  "C_Cpp.errorSquiggles": "disabled",
+  "editor.tokenColorCustomizations": {
+    "textMateRules": [
+      {
+        "scope": "googletest.failed",
+        "settings": {
+          "foreground": "#f00"
+        }
+      },
+      {
+        "scope": "googletest.passed",
+        "settings": {
+          "foreground": "#0f0"
+        }
+      },
+      {
+        "scope": "googletest.run",
+        "settings": {
+          "foreground": "#0f0"
+        }
+      }
+    ]
+  },
 }

.vscode/settings.json

@@ -7,11 +7,36 @@ project(c++spec)
 
 set(CMAKE_COLOR_DIAGNOSTICS ON)
 
+cmake_policy(SET CMP0135 NEW)
+
+include(FetchContent)
+
+# FetchContent_Declare(argparse
+#   GIT_REPOSITORY https://github.com/p-ranav/argparse/
+#   GIT_TAG        v2.9
+# )
+# FetchContent_MakeAvailable(argparse)
+
+FetchContent_Declare(cxx-prettyprint
+  GIT_REPOSITORY https://github.com/louisdx/cxx-prettyprint
+  GIT_TAG        master
+)
+FetchContent_MakeAvailable(cxx-prettyprint)
+
+add_library(cxx-prettyprint INTERFACE)
+target_sources(cxx-prettyprint INTERFACE ${cxx-prettyprint_SOURCE_DIR}/prettyprint.hpp)
+target_include_directories(cxx-prettyprint INTERFACE ${cxx-prettyprint_SOURCE_DIR})
+
+
 add_library(c++spec INTERFACE)
 target_include_directories(c++spec INTERFACE
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include/>
   $<INSTALL_INTERFACE:include/cppspec/> # <prefix>/include/cppspec
 )
+target_link_libraries(c++spec INTERFACE
+  cxx-prettyprint
+#  argparse
+)
 
 FILE(GLOB_RECURSE c++spec_headers ${CMAKE_CURRENT_LIST_DIR}/include/*.hpp)
 target_precompile_headers(c++spec INTERFACE
@@ -50,10 +75,6 @@ if(DOXYGEN_FOUND)
             "Can't find GraphViz DOT tool for generating images."
             "Make sure it's on your PATH or install GraphViz")
     endif()
-
-    cmake_policy(SET CMP0135 NEW)
-
-    include(FetchContent)
 
     FetchContent_Declare(doxygen-awesome-css
       URL      https://github.com/jothepro/doxygen-awesome-css/archive/refs/tags/v2.2.1.tar.gz
@@ -65,7 +86,7 @@ if(DOXYGEN_FOUND)
     set(DOXYGEN_PROJECT_BRIEF "BDD testing for C++")
     set(DOXYGEN_RECURSIVE YES)
     set(DOXYGEN_EXAMPLE_RECURSIVE YES)
-
+    set(DOXYGEN_EXCLUDE_PATTERNS "*/cxx-prettyprint/*")
     set(DOXYGEN_NUM_PROC_THREADS ${HOST_NUM_CORES})
 
     # From doxygen-awesome

CMakeLists.txt

@@ -7,7 +7,7 @@
 #include <vector>
 #include <algorithm>
 #include <regex>
-#include "cxx-prettyprint/prettyprint.hpp"
+#include "prettyprint.hpp"
 #include "util.hpp"
 
 namespace CppSpec {

include/cxx-prettyprint

@@ -18,7 +18,7 @@ class Runner {
   Formatters::BaseFormatter &formatter;
 
  public:
-  typedef std::function<void(Runner &)> spec_group;
+  using spec_group = std::function<void (Runner &)>;
   explicit Runner(Formatters::BaseFormatter &formatter =
                       Formatters::progress) noexcept : formatter(formatter) {}