Skip to content

Commit fe897fd

Browse files
committed
settings: fix extremely bad cache bar defaults
I think this has been broken since the cache bar was split into foreground and background components (and I had a bad half-height cache bar in the defaults even before that for some insane reason). I think these changes provide a much more reasonable out-of-the-box experience (what can I say, they match my local configuration now).
1 parent 77135c4 commit fe897fd

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

readme.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,10 @@ convenient to update if you symlink it in from somewhere else.
2626
the way it displays. These can be set on the mpv command line, but the
2727
recommended approach is by using the configuration file
2828
`~~/script-opts/torque-progressbar/main.conf`, where `~~` is either
29-
`~/.mpv` or `~/.config/mpv`, depending on your setup. The defaults are
30-
provided in `settings.moon`, and are reproduced in config-file-
31-
compatible syntax in [`torque-progressbar.conf`][conf-example].
29+
`~/.mpv` or `~/.config/mpv`, depending on your setup (on Windows, it's
30+
`%appdata%\mpv`). The defaults are provided in `settings.moon`, and are
31+
reproduced in config-file- compatible syntax in
32+
[`torque-progressbar.conf`][conf-example].
3233

3334
#### Keybindings
3435

src/settings.moon

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,15 @@ demuxer cache ranges that are prior to the current playback point will not be
110110
shown. This matches the previous behavior.
111111
]]
112112

113-
settings['bar-cache-height-inactive'] = 1.5
113+
settings['bar-cache-height-inactive'] = 3
114114
helpText['bar-cache-height-inactive'] = [[
115115
Sets the height of the cache bar display when the mouse is not in the active
116116
zone and there is no request-display active. Useful in combination with bar-
117117
cache-position to control whether or not the cache bar is occluded by (or
118118
occludes) the progress bar.
119119
]]
120120

121-
settings['bar-cache-height-active'] = 4
121+
settings['bar-cache-height-active'] = 8
122122
helpText['bar-cache-height-active'] = [[
123123
Sets the height of the cache bar display when the mouse is in the active zone or
124124
request-display is active. Useful in combination with bar-cache- position to
@@ -139,14 +139,14 @@ A string of ASS override tags that get applied only to the progress layer of the
139139
bar.
140140
]]
141141

142-
settings['bar-cache-style'] = [[\c&H515151&]]
142+
settings['bar-cache-style'] = [[\c&HFDAFC8&]]
143143
helpText['bar-cache-style'] = [[
144144
A string of ASS override tags that get applied only to the cache layer of the
145145
bar, particularly the part of the cache bar that is behind the current playback
146146
position. The default sets only the color.
147147
]]
148148

149-
settings['bar-cache-background-style'] = [[]]
149+
settings['bar-cache-background-style'] = [[\c&H525252&]]
150150
helpText['bar-cache-background-style'] = [[
151151
A string of ASS override tags that get applied only to the cache layer of the
152152
bar, particularly the part of the cache bar that is after the current playback

torque-progressbar.conf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ bar-cache-position=overlay
8989
# zone and there is no request-display active. Useful in combination with bar-
9090
# cache-position to control whether or not the cache bar is occluded by (or
9191
# occludes) the progress bar.
92-
bar-cache-height-inactive=1.5
92+
bar-cache-height-inactive=3
9393

9494
# Sets the height of the cache bar display when the mouse is in the active zone or
9595
# request-display is active. Useful in combination with bar-cache- position to
9696
# control whether or not the cache bar is occluded by (or occludes) the progress
9797
# bar.
98-
bar-cache-height-active=4
98+
bar-cache-height-active=8
9999

100100
# A string of ASS override tags that get applied to all three layers of the bar:
101101
# progress, cache, and background. You probably don't want to remove \bord0 unless
@@ -109,15 +109,15 @@ bar-foreground-style=
109109
# A string of ASS override tags that get applied only to the cache layer of the
110110
# bar, particularly the part of the cache bar that is behind the current playback
111111
# position. The default sets only the color.
112-
bar-cache-style=\c&H515151&
112+
bar-cache-style=\c&HFDAFC8&
113113

114114
# A string of ASS override tags that get applied only to the cache layer of the
115115
# bar, particularly the part of the cache bar that is after the current playback
116116
# position. The tags specified here are applied after bar-cache-style and override
117117
# them. Leaving this blank will leave the style the same as specified by bar-
118118
# cache-style. The split does not account for a nonzero progress-bar-width and may
119119
# look odd when used in tandem with that setting.
120-
bar-cache-background-style=
120+
bar-cache-background-style=\c&H525252&
121121

122122
# A string of ASS override tags that get applied only to the background layer of
123123
# the bar. The default sets only the color.

0 commit comments

Comments
 (0)