Merge #84: Create shared test utilities module for command handlers

045f131 style: [#75] Fix clippy warnings and formatting (copilot-swe-agent[bot])
c2cc568 feat: [#75] Create shared test utilities module (copilot-swe-agent[bot])
0ad3a26 Initial plan (copilot-swe-agent[bot])

Pull request description:

  Test utilities were duplicated across `create/tests/fixtures.rs` and inconsistently implemented in `destroy/tests/`. This created maintenance burden and inconsistent test patterns.

  ## Changes

  **New shared test utilities** (`src/presentation/commands/tests/mod.rs`):
  - `TestContext` - Manages temporary directories with automatic cleanup
  - `create_valid_config()` - Generates valid environment configurations
  - `create_invalid_json_config()` - Creates malformed JSON for error testing
  - `create_config_with_invalid_name()` - Invalid environment name for validation testing
  - `create_config_with_missing_keys()` - Non-existent SSH keys for file validation testing

  **Test file updates**:
  - `create/tests/integration.rs` - 8 tests migrated to shared utilities
  - `create/tests/template.rs` - 4 tests migrated to shared utilities
  - `destroy/tests/integration.rs` - 5 tests migrated to shared utilities
  - Removed duplicate `create/tests/fixtures.rs` (162 lines)

  ## Usage

  ```rust
  use crate::presentation::commands::tests::{TestContext, create_valid_config};

  #[test]
  fn it_should_create_environment_from_valid_config() {
      let context = TestContext::new();
      let config_path = create_valid_config(context.working_dir(), "test-env");

      let result = handle_environment_creation(&config_path, context.working_dir());
      assert!(result.is_ok());
      // Temp directory cleaned up automatically when context drops
  }
  ```

  Net reduction of ~190 lines with improved consistency across all command tests.

  <!-- START COPILOT CODING AGENT SUFFIX -->

  <details>

  <summary>Original prompt</summary>

  >
  > ----
  >
  > *This section details on the original issue you should resolve*
  >
  > <issue_title>Create Shared Test Utilities Module</issue_title>
  > <issue_description>**Parent Issue**: #63
  > **Type**: 🔨 Structural Improvement
  > **Impact**: 🟢🟢 Medium
  > **Effort**: 🔵🔵 Medium
  > **Priority**: P1
  >
  > ## Problem
  >
  > Test utilities are duplicated and inconsistent:
  >
  > - `create/tests/` has comprehensive fixtures module
  > - `destroy/tests/` lacks test helpers
  > - Common patterns like creating temp directories, generating test configs are repeated
  >
  > ## Proposed Solution
  >
  > Create shared test utilities at `src/presentation/commands/tests/mod.rs`:
  >
  > ```rust
  > //! Shared test utilities for command handlers
  >
  > use std::path::{Path, PathBuf};
  > use std::sync::Arc;
  > use tempfile::TempDir;
  >
  > /// Test context with temp directory and common test dependencies
  > pub struct TestContext {
  >     _temp_dir: TempDir,
  >     pub working_dir: PathBuf,
  >     pub repository: Arc<MockEnvironmentRepository>,
  >     pub clock: Arc<MockClock>,
  > }
  >
  > impl TestContext {
  >     pub fn new() -> Self {
  >         let temp_dir = TempDir::new().expect("Failed to create temp directory");
  >         let working_dir = temp_dir.path().to_path_buf();
  >
  >         let repository_factory = RepositoryFactory::new(std::time::Duration::from_secs(30));
  >         let repository = Arc::new(repository_factory.create(working_dir.clone()));
  >
  >         let clock = Arc::new(MockClock::new(chrono::Utc::now()));
  >
  >         Self { _temp_dir: temp_dir, working_dir, repository, clock }
  >     }
  >
  >     pub fn working_dir(&self) -> &Path {
  >         &self.working_dir
  >     }
  > }
  >
  > /// Create a valid test configuration file
  > pub fn create_test_config(path: &Path, env_name: &str) -> PathBuf {
  >     // Implementation
  > }
  >
  > /// Create an invalid JSON configuration file for error testing
  > pub fn create_invalid_json_config(path: &Path) -> PathBuf {
  >     // Implementation
  > }
  >
  > /// Create a configuration with invalid environment name
  > pub fn create_config_with_invalid_name(path: &Path) -> PathBuf {
  >     // Implementation
  > }
  > ```
  >
  > Then use in tests:
  > ```rust
  > use crate::presentation::commands::tests::{TestContext, create_test_config};
  >
  > #[test]
  > fn it_should_create_environment_from_valid_config() {
  >     let context = TestContext::new();
  >     let config_path = create_test_config(context.working_dir(), "test-env");
  >
  >     let result = handle_environment_creation(&config_path, context.working_dir());
  >     assert!(result.is_ok());
  > }
  > ```
  >
  > ## Benefits
  >
  > - ✅ Reduces test code duplication
  > - ✅ Consistent test patterns across commands
  > - ✅ Easier to write new tests
  > - ✅ Shared improvements benefit all tests
  >
  > ## Implementation Checklist
  >
  > - [ ] Create `src/presentation/commands/tests/mod.rs`
  > - [ ] Implement `TestContext` struct with temp dir management
  > - [ ] Migrate `create_test_config()` from fixtures.rs
  > - [ ] Migrate `create_invalid_json_config()` from fixtures.rs
  > - [ ] Migrate `create_config_with_invalid_name()` from fixtures.rs
  > - [ ] Add comprehensive documentation
  > - [ ] Update `create/tests/` to use shared utilities
  > - [ ] Update `destroy/tests/` to use shared utilities
  > - [ ] Remove duplicate code from old test files
  > - [ ] Verify all tests pass
  > - [ ] Run linter
  >
  > ## Acceptance Criteria
  >
  > - [ ] Shared test utilities module exists
  > - [ ] `TestContext` provides consistent test setup
  > - [ ] Common test config generators are shared
  > - [ ] Both create and destroy tests use shared utilities
  > - [ ] No duplicate test helper code remains
  > - [ ] All tests pass: `cargo test presentation::commands`
  > - [ ] Pre-commit checks pass: `./scripts/pre-commit.sh`
  > - [ ] Code follows project conventions
  >
  > ## Related Documentation
  >
  > - [Testing Guide](https://github.com/torrust/torrust-tracker-deployer/blob/main/docs/contributing/testing.md)
  > - [Refactor Plan](https://github.com/torrust/torrust-tracker-deployer/blob/main/docs/refactors/plans/presentation-commands-cleanup.md)</issue_description>
  >
  > ## Comments on the Issue (you are @copilot in this section)
  >
  > <comments>
  > </comments>
  >

  </details>

  - Fixes #70

  <!-- START COPILOT CODING AGENT TIPS -->
  ---

  💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

ACKs for top commit:
  josecelano:
    ACK 045f131

Tree-SHA512: fee2de626b1010bcde7e06dfbfa7f0e145caf0c4efbe2d9b294ad8b80eabb9c1ea800f2c830a6db5d539a762d278270444c70fbb3db6d92db917066a23de6604

Author: josecelano

src/presentation/commands/create/tests/fixtures.rs

@@ -3,12 +3,12 @@
 //! This module tests the complete create command workflow including
 //! configuration loading, validation, and command execution.
 
-use tempfile::TempDir;
-
 use crate::presentation::cli::CreateAction;
 use crate::presentation::commands::create;
-
-use super::fixtures;
+use crate::presentation::commands::tests::{
+    create_config_with_invalid_name, create_config_with_missing_keys, create_invalid_json_config,
+    create_valid_config, TestContext,
+};
 
 /// Helper function to call the environment creation handler
 fn handle_environment_creation(
@@ -23,10 +23,10 @@ fn handle_environment_creation(
 
 #[test]
 fn it_should_create_environment_from_valid_config() {
-    let temp_dir = TempDir::new().unwrap();
-    let config_path = fixtures::create_valid_config(temp_dir.path(), "integration-test-env");
+    let context = TestContext::new();
+    let config_path = create_valid_config(context.working_dir(), "integration-test-env");
 
-    let result = handle_environment_creation(&config_path, temp_dir.path());
+    let result = handle_environment_creation(&config_path, context.working_dir());
 
     assert!(
         result.is_ok(),
@@ -36,8 +36,8 @@ fn it_should_create_environment_from_valid_config() {
 
     // Verify environment state file was created by repository
     // Repository creates: <base_dir>/{env-name}/environment.json
-    let env_state_file = temp_dir
-        .path()
+    let env_state_file = context
+        .working_dir()
         .join("integration-test-env/environment.json");
     assert!(
         env_state_file.exists(),
@@ -48,10 +48,10 @@ fn it_should_create_environment_from_valid_config() {
 
 #[test]
 fn it_should_reject_nonexistent_config_file() {
-    let temp_dir = TempDir::new().unwrap();
-    let nonexistent_path = temp_dir.path().join("nonexistent.json");
+    let context = TestContext::new();
+    let nonexistent_path = context.working_dir().join("nonexistent.json");
 
-    let result = handle_environment_creation(&nonexistent_path, temp_dir.path());
+    let result = handle_environment_creation(&nonexistent_path, context.working_dir());
 
     assert!(result.is_err(), "Should fail for nonexistent file");
     match result.unwrap_err() {
@@ -64,10 +64,10 @@ fn it_should_reject_nonexistent_config_file() {
 
 #[test]
 fn it_should_reject_invalid_json() {
-    let temp_dir = TempDir::new().unwrap();
-    let config_path = fixtures::create_invalid_json_config(temp_dir.path());
+    let context = TestContext::new();
+    let config_path = create_invalid_json_config(context.working_dir());
 
-    let result = handle_environment_creation(&config_path, temp_dir.path());
+    let result = handle_environment_creation(&config_path, context.working_dir());
 
     assert!(result.is_err(), "Should fail for invalid JSON");
     match result.unwrap_err() {
@@ -80,10 +80,10 @@ fn it_should_reject_invalid_json() {
 
 #[test]
 fn it_should_reject_invalid_environment_name() {
-    let temp_dir = TempDir::new().unwrap();
-    let config_path = fixtures::create_config_with_invalid_name(temp_dir.path());
+    let context = TestContext::new();
+    let config_path = create_config_with_invalid_name(context.working_dir());
 
-    let result = handle_environment_creation(&config_path, temp_dir.path());
+    let result = handle_environment_creation(&config_path, context.working_dir());
 
     assert!(result.is_err(), "Should fail for invalid environment name");
     match result.unwrap_err() {
@@ -96,10 +96,10 @@ fn it_should_reject_invalid_environment_name() {
 
 #[test]
 fn it_should_reject_missing_ssh_keys() {
-    let temp_dir = TempDir::new().unwrap();
-    let config_path = fixtures::create_config_with_missing_keys(temp_dir.path());
+    let context = TestContext::new();
+    let config_path = create_config_with_missing_keys(context.working_dir());
 
-    let result = handle_environment_creation(&config_path, temp_dir.path());
+    let result = handle_environment_creation(&config_path, context.working_dir());
 
     assert!(result.is_err(), "Should fail for missing SSH keys");
     match result.unwrap_err() {
@@ -112,15 +112,15 @@ fn it_should_reject_missing_ssh_keys() {
 
 #[test]
 fn it_should_reject_duplicate_environment() {
-    let temp_dir = TempDir::new().unwrap();
-    let config_path = fixtures::create_valid_config(temp_dir.path(), "duplicate-test-env");
+    let context = TestContext::new();
+    let config_path = create_valid_config(context.working_dir(), "duplicate-test-env");
 
     // Create environment first time
-    let result1 = handle_environment_creation(&config_path, temp_dir.path());
+    let result1 = handle_environment_creation(&config_path, context.working_dir());
     assert!(result1.is_ok(), "First create should succeed");
 
     // Try to create same environment again
-    let result2 = handle_environment_creation(&config_path, temp_dir.path());
+    let result2 = handle_environment_creation(&config_path, context.working_dir());
     assert!(result2.is_err(), "Second create should fail");
 
     match result2.unwrap_err() {
@@ -133,11 +133,11 @@ fn it_should_reject_duplicate_environment() {
 
 #[test]
 fn it_should_create_environment_in_custom_working_dir() {
-    let temp_dir = TempDir::new().unwrap();
-    let custom_working_dir = temp_dir.path().join("custom");
+    let context = TestContext::new();
+    let custom_working_dir = context.working_dir().join("custom");
     std::fs::create_dir(&custom_working_dir).unwrap();
 
-    let config_path = fixtures::create_valid_config(temp_dir.path(), "custom-dir-env");
+    let config_path = create_valid_config(context.working_dir(), "custom-dir-env");
 
     let result = handle_environment_creation(&config_path, &custom_working_dir);
 
@@ -155,27 +155,27 @@ fn it_should_create_environment_in_custom_working_dir() {
 
 #[test]
 fn it_should_provide_help_for_all_error_types() {
-    let temp_dir = TempDir::new().unwrap();
+    let context = TestContext::new();
 
     // Test ConfigFileNotFound
-    let nonexistent = temp_dir.path().join("nonexistent.json");
-    if let Err(e) = handle_environment_creation(&nonexistent, temp_dir.path()) {
+    let nonexistent = context.working_dir().join("nonexistent.json");
+    if let Err(e) = handle_environment_creation(&nonexistent, context.working_dir()) {
         let help = e.help();
         assert!(!help.is_empty());
         assert!(help.contains("File Not Found") || help.contains("Check that the file path"));
     }
 
     // Test ConfigParsingFailed
-    let invalid_json = fixtures::create_invalid_json_config(temp_dir.path());
-    if let Err(e) = handle_environment_creation(&invalid_json, temp_dir.path()) {
+    let invalid_json = create_invalid_json_config(context.working_dir());
+    if let Err(e) = handle_environment_creation(&invalid_json, context.working_dir()) {
         let help = e.help();
         assert!(!help.is_empty());
         assert!(help.contains("JSON") || help.contains("syntax"));
     }
 
     // Test ConfigValidationFailed
-    let invalid_name = fixtures::create_config_with_invalid_name(temp_dir.path());
-    if let Err(e) = handle_environment_creation(&invalid_name, temp_dir.path()) {
+    let invalid_name = create_config_with_invalid_name(context.working_dir());
+    if let Err(e) = handle_environment_creation(&invalid_name, context.working_dir()) {
         let help = e.help();
         assert!(!help.is_empty());
         // Should delegate to config error help

src/presentation/commands/create/tests/integration.rs

@@ -3,6 +3,5 @@
 //! This module contains integration tests for the create command presentation
 //! layer, including CLI integration, configuration loading, and error handling.
 
-pub mod fixtures;
 pub mod integration;
 pub mod template;