feat: enable cloud-init validation for both VM and container environments

- Refactor CloudInitValidator.execute() to detect cloud-init installation
- Only check cloud-init status when cloud-init is actually installed
- Always check completion marker file for both VM and container environments
- Uncomment cloud-init validation step in TestCommand.execute()
- Remove TODO comments as the issue is now resolved

This allows the cloud-init validation to work seamlessly across:
- VM environments: Checks cloud-init status + completion marker
- Container environments: Only checks completion marker (cloud-init not installed)

Author: josecelano

src/application/commands/test.rs

@@ -16,8 +16,7 @@ use std::net::IpAddr;
 use tracing::{info, instrument};
 
 use crate::application::steps::{
-    // ValidateCloudInitCompletionStep, // Disabled for container testing - see execute() method
-    ValidateDockerComposeInstallationStep,
+    ValidateCloudInitCompletionStep, ValidateDockerComposeInstallationStep,
     ValidateDockerInstallationStep,
 };
 use crate::infrastructure::remote_actions::RemoteActionError;
@@ -76,16 +75,9 @@ impl TestCommand {
         let ssh_connection =
             SshConnection::with_default_port(self.ssh_credentials.clone(), self.instance_ip);
 
-        // TODO: Cloud-init validation disabled for container testing
-        // This step fails when testing with Docker containers since they don't have cloud-init installed.
-        // In the future, we can:
-        // - Add a flag to enable this only when the provisioned instance supports it
-        // - Check for the cloud-init completion file (which is simulated in the Docker container)
-        //   instead of calling the cloud-init service directly
-        //
-        // ValidateCloudInitCompletionStep::new(ssh_connection.clone())
-        //     .execute()
-        //     .await?;
+        ValidateCloudInitCompletionStep::new(ssh_connection.clone())
+            .execute()
+            .await?;
 
         ValidateDockerInstallationStep::new(ssh_connection.clone())
             .execute()

src/infrastructure/remote_actions/cloud_init.rs

@@ -61,23 +61,52 @@ impl RemoteAction for CloudInitValidator {
             "Validating cloud-init completion"
         );
 
-        // Check cloud-init status
-        let status_output = self
+        // Check if cloud-init is installed
+        let cloud_init_installed = self
             .ssh_client
-            .execute("cloud-init status")
+            .check_command("command -v cloud-init")
             .map_err(|source| RemoteActionError::SshCommandFailed {
                 action_name: self.name().to_string(),
                 source,
             })?;
 
-        if !status_output.contains("status: done") {
-            return Err(RemoteActionError::ValidationFailed {
-                action_name: self.name().to_string(),
-                message: format!("Cloud-init status is not 'done': {status_output}"),
-            });
+        if cloud_init_installed {
+            info!(
+                action = "cloud_init_validation",
+                check = "installation",
+                "Cloud-init is installed, checking status"
+            );
+
+            // Check cloud-init status only if cloud-init is installed
+            let status_output = self
+                .ssh_client
+                .execute("cloud-init status")
+                .map_err(|source| RemoteActionError::SshCommandFailed {
+                    action_name: self.name().to_string(),
+                    source,
+                })?;
+
+            if !status_output.contains("status: done") {
+                return Err(RemoteActionError::ValidationFailed {
+                    action_name: self.name().to_string(),
+                    message: format!("Cloud-init status is not 'done': {status_output}"),
+                });
+            }
+
+            info!(
+                action = "cloud_init_validation",
+                check = "status_done",
+                "Cloud-init status is 'done'"
+            );
+        } else {
+            info!(
+                action = "cloud_init_validation",
+                check = "installation",
+                "Cloud-init is not installed, skipping status check (container environment)"
+            );
         }
 
-        // Check for completion marker file
+        // Check for completion marker file (applies to both VM and container environments)
         let marker_exists = self
             .ssh_client
             .check_command("test -f /var/lib/cloud/instance/boot-finished")
@@ -95,18 +124,14 @@ impl RemoteAction for CloudInitValidator {
 
         info!(
             action = "cloud_init_validation",
-            status = "success",
-            "Cloud-init validation passed"
-        );
-        info!(
-            action = "cloud_init_validation",
-            check = "status_done",
-            "Cloud-init status is 'done'"
+            check = "completion_marker",
+            "Completion marker file exists"
         );
+
         info!(
             action = "cloud_init_validation",
-            check = "completion_marker",
-            "Completion marker file exists"
+            status = "success",
+            "Cloud-init validation passed"
         );
 
         Ok(())