refactor: pass TemplateManager as constructor dependency in TofuTemplateRenderer

- Change TofuTemplateRenderer to accept Arc<TemplateManager> in constructor
- Remove template_manager parameter from render() method
- Update all dependent files to use new constructor signature
- Simplify RenderOpenTofuTemplatesStep by removing template_manager field
- Improve encapsulation and follow dependency injection principles
- All tests pass and maintain existing functionality

Author: josecelano

src/bin/e2e_tests.rs

@@ -142,7 +142,6 @@ impl TestEnvironment {
     async fn render_provision_templates(&self) -> Result<()> {
         let step = RenderOpenTofuTemplatesStep::new(
             Arc::clone(&self.services.tofu_template_renderer),
-            Arc::clone(&self.services.template_manager),
         );
         step.execute()
             .await

src/container.rs

@@ -27,6 +27,7 @@ impl Services {
     pub fn new(config: &Config) -> Self {
         // Create template manager
         let template_manager = TemplateManager::new(config.templates_dir.clone());
+        let template_manager = Arc::new(template_manager);
 
         // Create OpenTofu client pointing to build/opentofu_subfolder directory
         let opentofu_client = OpenTofuClient::new(
@@ -44,8 +45,11 @@ impl Services {
         );
 
         // Create provision template renderer
-        let provision_renderer =
-            TofuTemplateRenderer::new(config.build_dir.clone(), config.verbose);
+        let provision_renderer = TofuTemplateRenderer::new(
+            template_manager.clone(),
+            config.build_dir.clone(),
+            config.verbose,
+        );
 
         // Create configuration template renderer
         let configuration_renderer =
@@ -58,7 +62,7 @@ impl Services {
             ansible_client: Arc::new(ansible_client),
 
             // Template related services
-            template_manager: Arc::new(template_manager),
+            template_manager: template_manager.clone(),
             tofu_template_renderer: Arc::new(provision_renderer),
             ansible_template_renderer: Arc::new(configuration_renderer),
         }

src/steps/template/render_opentofu_templates.rs

@@ -2,24 +2,18 @@ use std::sync::Arc;
 
 use tracing::info;
 
-use crate::template::TemplateManager;
 use crate::tofu::template_renderer::{ProvisionTemplateError, TofuTemplateRenderer};
 
 /// Simple step that renders `OpenTofu` templates to the build directory
 pub struct RenderOpenTofuTemplatesStep {
     tofu_template_renderer: Arc<TofuTemplateRenderer>,
-    template_manager: Arc<TemplateManager>,
 }
 
 impl RenderOpenTofuTemplatesStep {
     #[must_use]
-    pub fn new(
-        tofu_template_renderer: Arc<TofuTemplateRenderer>,
-        template_manager: Arc<TemplateManager>,
-    ) -> Self {
+    pub fn new(tofu_template_renderer: Arc<TofuTemplateRenderer>) -> Self {
         Self {
             tofu_template_renderer,
-            template_manager,
         }
     }
 
@@ -32,9 +26,7 @@ impl RenderOpenTofuTemplatesStep {
     pub async fn execute(&self) -> Result<(), ProvisionTemplateError> {
         info!("📝 Stage 1: Rendering OpenTofu templates...");
 
-        self.tofu_template_renderer
-            .render(&self.template_manager)
-            .await?;
+        self.tofu_template_renderer.render().await?;
 
         info!("✅ Stage 1: OpenTofu templates rendered successfully");