refactor: [#220] rename E2E test binaries to better reflect their purpose

BREAKING CHANGE: E2E test binary names have changed

Old naming (what they did):
- e2e-provision-and-destroy-tests - Infrastructure provisioning lifecycle
- e2e-config-and-release-tests - Software deployment workflow
- e2e-tests-full - Complete end-to-end workflow

New naming (what they test):
- e2e-infrastructure-lifecycle-tests - Infrastructure provisioning lifecycle
- e2e-deployment-workflow-tests - Software deployment workflow
- e2e-complete-workflow-tests - Complete end-to-end workflow

Changes applied:
- Renamed binary source files in src/bin/
- Updated Cargo.toml binary definitions
- Renamed GitHub Actions workflow files
- Updated all binary names in workflows
- Changed ENVIRONMENT_NAME constants (e2e-provision -> e2e-infrastructure, e2e-config -> e2e-deployment, e2e-full -> e2e-complete)
- Updated all test_suite logging references
- Updated log directory paths
- Updated container/VM names in workflows
- Updated all documentation (README.md, AGENTS.md, docs/e2e-testing.md, etc.)
- Updated pre-commit.sh script with new binary names
- Updated clap command names and help text

Benefits:
- Clearer naming that describes test scope rather than implementation
- Consistent with workflow-based terminology
- Better developer experience understanding test purposes
- Aligns with industry standards for test naming conventions

Author: josecelano

.github/workflows/test-e2e-config.yml .github/workflows/test-e2e-deployment.yml.github/workflows/test-e2e-config.yml renamed to .github/workflows/test-e2e-deployment.yml

@@ -1,5 +1,5 @@
 ---
-name: E2E Configuration Tests
+name: E2E Deployment Workflow Tests
 
 # This workflow tests ONLY software configuration, release, and run phases
 # using Docker containers. It does NOT test infrastructure provisioning
@@ -22,7 +22,7 @@ on:
   workflow_dispatch: # Allow manual triggering
 
 jobs:
-  e2e-config-and-release-tests:
+  e2e-deployment-workflow-tests:
     runs-on: ubuntu-latest
     timeout-minutes: 45 # Timeout for complete configuration testing with software installation
 
@@ -62,16 +62,16 @@ jobs:
           chmod 600 fixtures/testing_rsa
           ls -la fixtures/testing_rsa
 
-      - name: Build E2E configuration and release tests binary
+      - name: Build E2E deployment workflow tests binary
         run: |
-          cargo build --bin e2e-config-and-release-tests --release
+          cargo build --bin e2e-deployment-workflow-tests --release
 
-      - name: Run E2E configuration and release test
+      - name: Run E2E deployment workflow test
         run: |
-          # Run the E2E configuration and release test with debug logging for better debugging
-          echo "🚀 Starting E2E configuration and release test at $(date)"
-          cargo run --bin e2e-config-and-release-tests
-          echo "✅ E2E configuration and release test completed at $(date)"
+          # Run the E2E deployment workflow test with debug logging for better debugging
+          echo "🚀 Starting E2E deployment workflow test at $(date)"
+          cargo run --bin e2e-deployment-workflow-tests
+          echo "✅ E2E deployment workflow test completed at $(date)"
         env:
           # Preserve environment variables for the E2E test
           RUST_LOG: debug
@@ -113,8 +113,8 @@ jobs:
           # properly (e.g., if the test was abruptly halted). Under normal circumstances,
           # the testcontainers crate should automatically clean up containers when tests finish.
 
-          # Clean up the specific container created for e2e-config tests
-          docker rm -f torrust-tracker-vm-e2e-config 2>/dev/null || echo "Container torrust-tracker-vm-e2e-config not found or already removed"
+          # Clean up the specific container created for e2e-deployment tests
+          docker rm -f torrust-tracker-vm-e2e-deployment 2>/dev/null || echo "Container torrust-tracker-vm-e2e-deployment not found or already removed"
 
           # Clean up any test images if needed
           docker images --filter "reference=torrust-provisioned-instance*" -q | xargs -r docker rmi -f || echo "No test images to remove"
@@ -126,9 +126,9 @@ jobs:
           docker ps -a
 
           echo "=== Test Summary ==="
-          echo "E2E configuration test workflow completed"
+          echo "E2E deployment workflow test completed"
           if [ "${{ job.status }}" = "success" ]; then
-            echo "✅ All configuration tests passed successfully"
+            echo "✅ All deployment workflow tests passed successfully"
           else
-            echo "❌ Some configuration tests failed - check logs above"
+            echo "❌ Some deployment workflow tests failed - check logs above"
           fi

.github/workflows/test-e2e-provision.yml …ub/workflows/test-e2e-infrastructure.yml.github/workflows/test-e2e-provision.yml renamed to .github/workflows/test-e2e-infrastructure.yml .github/workflows/test-e2e-provision.yml renamed to .github/workflows/test-e2e-infrastructure.yml

@@ -1,4 +1,4 @@
-name: E2E Provision and Destroy Tests
+name: E2E Infrastructure Lifecycle Tests
 
 # This workflow tests infrastructure provisioning and destruction (creating and destroying VMs/containers)
 # It does NOT test software configuration/installation to avoid GitHub Actions
@@ -18,7 +18,7 @@ on:
   workflow_dispatch: # Allow manual triggering
 
 jobs:
-  e2e-provision-tests:
+  e2e-infrastructure-lifecycle-tests:
     runs-on: ubuntu-latest
     timeout-minutes: 30 # Reduced timeout since we're not installing software
 
@@ -48,17 +48,17 @@ jobs:
           tofu version
           cargo --version
 
-      - name: Build E2E provision and destroy tests binary
+      - name: Build E2E infrastructure lifecycle tests binary
         run: |
-          cargo build --bin e2e-provision-and-destroy-tests --release
+          cargo build --bin e2e-infrastructure-lifecycle-tests --release
 
-      - name: Run E2E provision and destroy test
+      - name: Run E2E infrastructure lifecycle test
         run: |
-          # Run the E2E provision and destroy test with debug logging for better debugging
+          # Run the E2E infrastructure lifecycle test with debug logging for better debugging
           # Use sudo -E and preserve PATH to ensure cargo is accessible
-          echo "🚀 Starting E2E provision and destroy test at $(date)"
-          sudo -E env "PATH=$PATH" cargo run --bin e2e-provision-and-destroy-tests
-          echo "✅ E2E provision and destroy test completed at $(date)"
+          echo "🚀 Starting E2E infrastructure lifecycle test at $(date)"
+          sudo -E env "PATH=$PATH" cargo run --bin e2e-infrastructure-lifecycle-tests
+          echo "✅ E2E infrastructure lifecycle test completed at $(date)"
         env:
           # Preserve environment variables for the E2E test
           RUST_LOG: debug
@@ -68,18 +68,18 @@ jobs:
         run: |
           echo "=== Infrastructure Outputs ==="
           # Only check outputs if build directory still exists (it may be cleaned up by DestroyCommand)
-          if [ -d "build/e2e-provision/tofu/lxd" ]; then
-            cd build/e2e-provision/tofu/lxd
+          if [ -d "build/e2e-infrastructure/tofu/lxd" ]; then
+            cd build/e2e-infrastructure/tofu/lxd
             sudo -E tofu output || echo "No outputs available"
           else
             echo "Build directory not found (likely cleaned up by DestroyCommand)"
           fi
 
           echo "=== Container Status ==="
-          sudo lxc list torrust-tracker-vm-e2e-provision || echo "Container not found"
+          sudo lxc list torrust-tracker-vm-e2e-infrastructure || echo "Container not found"
 
           # Check if the container has an IP address before proceeding
-          sudo lxc info torrust-tracker-vm-e2e-provision || echo "Container info not available"
+          sudo lxc info torrust-tracker-vm-e2e-infrastructure || echo "Container info not available"
 
       - name: Debug information (on failure)
         if: failure()
@@ -88,8 +88,8 @@ jobs:
           sudo lxc list || echo "LXC list failed"
 
           echo "=== OpenTofu State ==="
-          if [ -d "build/e2e-provision/tofu/lxd" ]; then
-            cd build/e2e-provision/tofu/lxd
+          if [ -d "build/e2e-infrastructure/tofu/lxd" ]; then
+            cd build/e2e-infrastructure/tofu/lxd
             sudo -E tofu show || echo "No state to show"
           else
             echo "No OpenTofu state directory found"
@@ -108,18 +108,18 @@ jobs:
           echo "Test failed - attempting emergency cleanup..."
 
           # Try OpenTofu cleanup only if build directory still exists
-          if [ -d "build/e2e-provision/tofu/lxd" ]; then
+          if [ -d "build/e2e-infrastructure/tofu/lxd" ]; then
             echo "Found OpenTofu state directory, attempting tofu destroy..."
-            cd build/e2e-provision/tofu/lxd
+            cd build/e2e-infrastructure/tofu/lxd
             sudo -E tofu destroy -auto-approve || echo "Tofu destroy failed or nothing to destroy"
           else
             echo "No OpenTofu state directory found (likely cleaned up by DestroyCommand)"
           fi
 
           # Always attempt LXD cleanup (no working directory dependency)
           echo "Attempting LXD resource cleanup..."
-          sudo lxc delete torrust-tracker-vm-e2e-provision --force || echo "Container deletion failed or container doesn't exist"
-          sudo lxc profile delete torrust-profile-e2e-provision || echo "Profile deletion failed or profile doesn't exist"
+          sudo lxc delete torrust-tracker-vm-e2e-infrastructure --force || echo "Container deletion failed or container doesn't exist"
+          sudo lxc profile delete torrust-profile-e2e-infrastructure || echo "Profile deletion failed or profile doesn't exist"
 
       - name: Final verification
         if: always()
@@ -128,9 +128,9 @@ jobs:
           sudo lxc list
 
           echo "=== Test Summary ==="
-          echo "E2E provision and destroy test workflow completed"
+          echo "E2E infrastructure lifecycle test workflow completed"
           if [ "${{ job.status }}" = "success" ]; then
-            echo "✅ All provision and destroy tests passed successfully"
+            echo "✅ All infrastructure lifecycle tests passed successfully"
           else
-            echo "❌ Some provision and destroy tests failed - check logs above"
+            echo "❌ Some infrastructure lifecycle tests failed - check logs above"
           fi

AGENTS.md

@@ -130,10 +130,10 @@ These principles should guide all development decisions, code reviews, and featu
 - **Test**: `cargo test`
 - **Unit Tests**: When writing unit tests, follow conventions described in [`docs/contributing/testing/`](docs/contributing/testing/)
 - **E2E Tests**:
-  - `cargo run --bin e2e-tests-full` - Comprehensive tests (⚠️ **LOCAL ONLY** - cannot run on GitHub Actions due to network connectivity issues)
-  - `cargo run --bin e2e-provision-and-destroy-tests` - Infrastructure provisioning and destruction tests (GitHub runner-compatible)
-  - `cargo run --bin e2e-config-and-release-tests` - Software installation, configuration, release, and run workflow tests (GitHub runner-compatible)
-  - Pre-commit hook runs the split tests (`e2e-provision-and-destroy-tests` + `e2e-config-and-release-tests`) for GitHub Copilot compatibility
+  - `cargo run --bin e2e-complete-workflow-tests` - Comprehensive tests (⚠️ **LOCAL ONLY** - cannot run on GitHub Actions due to network connectivity issues)
+  - `cargo run --bin e2e-infrastructure-lifecycle-tests` - Infrastructure provisioning and destruction tests (GitHub runner-compatible)
+  - `cargo run --bin e2e-deployment-workflow-tests` - Software installation, configuration, release, and run workflow tests (GitHub runner-compatible)
+  - Pre-commit hook runs the split tests (`e2e-infrastructure-lifecycle-tests` + `e2e-deployment-workflow-tests`) for GitHub Copilot compatibility
   - See [`docs/e2e-testing.md`](docs/e2e-testing.md) for detailed information about CI limitations
 
 Follow the project conventions and ensure all checks pass.

Cargo.toml

@@ -21,16 +21,16 @@ name = "torrust-tracker-deployer"
 path = "src/main.rs"
 
 [[bin]]
-name = "e2e-tests-full"
-path = "src/bin/e2e_tests_full.rs"
+name = "e2e-complete-workflow-tests"
+path = "src/bin/e2e_complete_workflow_tests.rs"
 
 [[bin]]
-name = "e2e-config-and-release-tests"
-path = "src/bin/e2e_config_and_release_tests.rs"
+name = "e2e-deployment-workflow-tests"
+path = "src/bin/e2e_deployment_workflow_tests.rs"
 
 [[bin]]
-name = "e2e-provision-and-destroy-tests"
-path = "src/bin/e2e_provision_and_destroy_tests.rs"
+name = "e2e-infrastructure-lifecycle-tests"
+path = "src/bin/e2e_infrastructure_lifecycle_tests.rs"
 
 [[bin]]
 name = "linter"

README.md

@@ -164,18 +164,18 @@ Use the E2E test binaries to run automated infrastructure tests with hardcoded e
 
 ```bash
 # Run comprehensive E2E tests (LOCAL ONLY - connectivity issues in GitHub runners)
-cargo run --bin e2e-tests-full
+cargo run --bin e2e-complete-workflow-tests
 
 # Run individual E2E test suites
-cargo run --bin e2e-config-and-release-tests      # Configuration, release, and run workflow tests
-cargo run --bin e2e-provision-and-destroy-tests   # Infrastructure provisioning tests
+cargo run --bin e2e-deployment-workflow-tests         # Configuration, release, and run workflow tests
+cargo run --bin e2e-infrastructure-lifecycle-tests   # Infrastructure provisioning tests
 
 # Keep the test environment after completion for inspection
-cargo run --bin e2e-tests-full -- --keep
-cargo run --bin e2e-provision-and-destroy-tests -- --keep
+cargo run --bin e2e-complete-workflow-tests -- --keep
+cargo run --bin e2e-infrastructure-lifecycle-tests -- --keep
 
 # Use custom templates directory
-cargo run --bin e2e-tests-full -- --templates-dir ./custom/templates
+cargo run --bin e2e-complete-workflow-tests -- --templates-dir ./custom/templates
 
 # See all available options
 cargo run --bin e2e-tests-full -- --help

docs/codebase-architecture.md

@@ -209,9 +209,9 @@ Application initialization and lifecycle management:
 **Binary Files:**
 
 - ✅ `src/bin/linter.rs` - Code quality linting binary
-- ✅ `src/bin/e2e-config-and-release-tests.rs` - E2E configuration and release tests
-- ✅ `src/bin/e2e-provision-and-destroy-tests.rs` - E2E provisioning and destruction tests
-- ✅ `src/bin/e2e-tests-full.rs` - Full E2E test suite
+- ✅ `src/bin/e2e-deployment-workflow-tests.rs` - E2E deployment workflow tests
+- ✅ `src/bin/e2e-infrastructure-lifecycle-tests.rs` - E2E infrastructure lifecycle tests
+- ✅ `src/bin/e2e-complete-workflow-tests.rs` - Complete E2E workflow test suite
 
 ### Presentation Layer
 

docs/contributing/commit-process.md

@@ -134,8 +134,8 @@ This script runs all mandatory checks:
 2. **Run all linters**: `cargo run --bin linter all` (stable & nightly toolchains)
 3. **Run tests**: `cargo test`
 4. **Test documentation builds**: `cargo doc --no-deps --bins --examples --workspace --all-features`
-5. **Run E2E provision and destroy tests**: `cargo run --bin e2e-provision-and-destroy-tests`
-6. **Run E2E configuration and release tests**: `cargo run --bin e2e-config-and-release-tests`
+5. **Run E2E infrastructure lifecycle tests**: `cargo run --bin e2e-infrastructure-lifecycle-tests`
+6. **Run E2E deployment workflow tests**: `cargo run --bin e2e-deployment-workflow-tests`
 
 **Note**: Code coverage is checked automatically in CI via GitHub Actions, not in the pre-commit script, to keep local commits fast and efficient.
 

docs/contributing/templates.md

@@ -206,7 +206,7 @@ Run E2E tests to verify the playbook is copied correctly:
 
 ```bash
 # Run E2E config and release tests (faster, tests configuration only)
-cargo run --bin e2e-config-and-release-tests
+cargo run --bin e2e-deployment-workflow-tests
 
 # Or run full E2E tests
 cargo run --bin e2e-tests-full

docs/contributing/testing/testing-commands.md

@@ -176,10 +176,10 @@ Commands should be integrated into E2E test suites:
 
 ### Provision and Destroy E2E Tests
 
-The `e2e-provision-and-destroy-tests` binary tests the complete infrastructure lifecycle:
+The `e2e-infrastructure-lifecycle-tests` binary tests the complete infrastructure lifecycle:
 
 ```rust
-// From src/bin/e2e_provision_and_destroy_tests.rs
+// From src/bin/e2e_infrastructure_lifecycle_tests.rs
 
 // Provision infrastructure
 let provisioned_env = run_provision_command(&context).await?;

docs/e2e-testing.md

@@ -6,40 +6,40 @@ This guide explains how to run and understand the End-to-End (E2E) tests for the
 
 The E2E tests validate the complete deployment process using two independent test suites:
 
-1. **E2E Provision and Destroy Tests** - Test infrastructure provisioning and destruction lifecycle using LXD VMs
-2. **E2E Configuration Tests** - Test software installation and configuration using Docker containers
+1. **E2E Infrastructure Lifecycle Tests** - Test infrastructure provisioning and destruction lifecycle using LXD VMs
+2. **E2E Deployment Workflow Tests** - Test software installation and configuration using Docker containers
 
 This split approach ensures reliable testing in CI environments while maintaining comprehensive coverage.
 
 ## 🚀 Running E2E Tests
 
 ### Independent Test Suites
 
-#### Provision and Destroy Tests
+#### Infrastructure Lifecycle Tests
 
 Test infrastructure provisioning and destruction lifecycle (VM creation, cloud-init, and destruction):
 
 ```bash
-cargo run --bin e2e-provision-and-destroy-tests
+cargo run --bin e2e-infrastructure-lifecycle-tests
 ```
 
-#### Configuration Tests
+#### Deployment Workflow Tests
 
 Test software installation, configuration, release, and run workflows (Ansible playbooks):
 
 ```bash
-cargo run --bin e2e-config-and-release-tests
+cargo run --bin e2e-deployment-workflow-tests
 ```
 
 #### Full Local Testing
 
 For local development, you can run the complete end-to-end test:
 
 ```bash
-cargo run --bin e2e-tests-full
+cargo run --bin e2e-complete-workflow-tests
 ```
 
-⚠️ **Note**: The `e2e-tests-full` binary cannot run on GitHub Actions due to network connectivity issues, but is useful for local validation.
+⚠️ **Note**: The `e2e-complete-workflow-tests` binary cannot run on GitHub Actions due to network connectivity issues, but is useful for local validation.
 
 ### Command Line Options
 
@@ -52,22 +52,22 @@ All test binaries support these options:
 ### Examples
 
 ```bash
-# Run provision and destroy tests
-cargo run --bin e2e-provision-and-destroy-tests
+# Run infrastructure lifecycle tests
+cargo run --bin e2e-infrastructure-lifecycle-tests
 
-# Run provision and destroy tests with debugging (keep environment)
-cargo run --bin e2e-provision-and-destroy-tests -- --keep
+# Run infrastructure lifecycle tests with debugging (keep environment)
+cargo run --bin e2e-infrastructure-lifecycle-tests -- --keep
 
-# Run configuration tests with debugging
-cargo run --bin e2e-config-and-release-tests -- --keep
+# Run deployment workflow tests with debugging
+cargo run --bin e2e-deployment-workflow-tests -- --keep
 
 # Run full local tests with custom templates
-cargo run --bin e2e-tests-full -- --templates-dir ./custom/templates
+cargo run --bin e2e-complete-workflow-tests -- --templates-dir ./custom/templates
 ```
 
 ## 📋 Test Sequences
 
-### E2E Provision and Destroy Tests (`e2e-provision-and-destroy-tests`)
+### E2E Infrastructure Lifecycle Tests (`e2e-infrastructure-lifecycle-tests`)
 
 Tests the complete infrastructure lifecycle using LXD VMs:
 
@@ -147,7 +147,7 @@ For detailed destroy command documentation, see:
 - [Destroy Command User Guide](user-guide/commands/destroy.md)
 - [Destroy Command Developer Guide](contributing/commands.md#destroycommand)
 
-### E2E Configuration and Release Tests (`e2e-config-and-release-tests`)
+### E2E Deployment Workflow Tests (`e2e-deployment-workflow-tests`)
 
 Tests software installation and configuration using Docker containers:
 
@@ -174,7 +174,7 @@ Tests software installation and configuration using Docker containers:
 - ✅ Docker Compose version command works
 - ✅ Can parse and validate a test docker-compose.yml file
 
-### Full Local Tests (`e2e-tests-full`)
+### E2E Complete Workflow Tests (`e2e-complete-workflow-tests`)
 
 Combines both provision and configuration phases in a single LXD VM for comprehensive local testing.