refactor: simplify TemplateRenderer trait and remove StaticContext dependency

- Remove generic Context type from TemplateRenderer trait
- Simplify render method to only require output path
- Move template validation and rendering to construction time
- Remove template_path and validate_context methods from trait
- Templates now pre-validate content and render directly
- Maintains all existing functionality while reducing API complexity
- All tests pass and linting requirements met

Author: josecelano

src/bin/e2e_tests.rs

@@ -12,7 +12,7 @@ use torrust_tracker_deploy::template::file::File;
 use torrust_tracker_deploy::template::wrappers::ansible::inventory::{
     InventoryContext, InventoryTemplate,
 };
-use torrust_tracker_deploy::template::{StaticContext, TemplateRenderer};
+use torrust_tracker_deploy::template::TemplateRenderer;
 
 #[derive(Parser)]
 #[command(name = "e2e-tests")]
@@ -150,9 +150,8 @@ impl TestEnvironment {
             InventoryTemplate::new(&inventory_template_file, &inventory_context)
                 .context("Failed to create InventoryTemplate")?;
 
-        let static_context = StaticContext::default();
         inventory_template
-            .render(&static_context, &inventory_output_path)
+            .render(&inventory_output_path)
             .context("Failed to render inventory template")?;
 
         // Copy static ansible files

src/template/renderer.rs

@@ -3,26 +3,13 @@
 //! Defines the core `TemplateRenderer` trait that all template wrappers must implement.
 
 use anyhow::Result;
-use serde::Serialize;
 use std::path::Path;
 
 /// Core trait for template rendering with strong typing and validation
 pub trait TemplateRenderer {
-    /// Context type that provides template variables
-    type Context: Serialize;
-
-    /// Returns the path to the template file
-    fn template_path(&self) -> &Path;
-
     /// Renders the template with the given context to the output path
     ///
     /// # Errors
     /// Returns an error if template rendering fails or output file cannot be written
-    fn render(&self, context: &Self::Context, output_path: &Path) -> Result<()>;
-
-    /// Validates that the context contains all required variables
-    ///
-    /// # Errors
-    /// Returns an error if any required variables are missing from the context
-    fn validate_context(&self, context: &Self::Context) -> Result<()>;
+    fn render(&self, output_path: &Path) -> Result<()>;
 }

src/template/wrappers/ansible/inventory/mod.rs

@@ -6,7 +6,7 @@ pub mod ansible_host;
 pub mod ssh_private_key_file;
 
 use crate::template::file::File;
-use crate::template::{StaticContext, TemplateRenderer};
+use crate::template::TemplateRenderer;
 use anyhow::{Context, Result};
 use serde::Serialize;
 use std::fs;
@@ -115,15 +115,7 @@ impl InventoryTemplate {
 }
 
 impl TemplateRenderer for InventoryTemplate {
-    type Context = StaticContext; // We don't use external context since we have fields
-
-    fn template_path(&self) -> &Path {
-        // Since we're working with content instead of paths, return a dummy path
-        // This should be refactored in the trait if this pattern is used more widely
-        Path::new("inventory.yml")
-    }
-
-    fn render(&self, _context: &Self::Context, output_path: &Path) -> Result<()> {
+    fn render(&self, output_path: &Path) -> Result<()> {
         // Create output directory if it doesn't exist
         if let Some(parent) = output_path.parent() {
             fs::create_dir_all(parent).with_context(|| {
@@ -138,11 +130,6 @@ impl TemplateRenderer for InventoryTemplate {
 
         Ok(())
     }
-
-    fn validate_context(&self, _context: &Self::Context) -> Result<()> {
-        // Validation is built-in since fields are mandatory at construction
-        Ok(())
-    }
 }
 
 #[cfg(test)]

tests/template_integration.rs

@@ -10,7 +10,7 @@ use torrust_tracker_deploy::template::file::File;
 use torrust_tracker_deploy::template::wrappers::ansible::inventory::{
     InventoryContext, InventoryTemplate,
 };
-use torrust_tracker_deploy::template::{StaticContext, TemplateRenderer};
+use torrust_tracker_deploy::template::TemplateRenderer;
 
 #[cfg(test)]
 mod integration_tests {
@@ -45,8 +45,7 @@ mod integration_tests {
         let inventory = InventoryTemplate::new(&template_file, &inventory_context)?;
 
         // Render the template
-        let context = StaticContext::default();
-        inventory.render(&context, &output_path)?;
+        inventory.render(&output_path)?;
 
         // Verify the output file exists and has the right content
         assert!(output_path.exists());
@@ -144,8 +143,7 @@ mod integration_tests {
             )?;
             let inventory = InventoryTemplate::new(&template_file, &inventory_context)?;
 
-            let context = StaticContext::default();
-            inventory.render(&context, &output_path)?;
+            inventory.render(&output_path)?;
         }
 
         // Verify the original template is unchanged
@@ -187,8 +185,7 @@ mod integration_tests {
             )?;
             let inventory = InventoryTemplate::new(&template_file, &inventory_context)?;
 
-            let context = StaticContext::default();
-            inventory.render(&context, &output_path)?;
+            inventory.render(&output_path)?;
 
             // Verify output in build directory
             assert!(output_path.exists());