fix: address code review feedback - async sleep and cross-platform concerns

Co-authored-by: josecelano <[email protected]>

Author: Copilot

packages/dependency-installer/src/installer/lxd.rs

@@ -4,8 +4,6 @@
 
 // Standard library
 use std::process::Command;
-use std::thread;
-use std::time::Duration;
 
 // External crates
 use async_trait::async_trait;
@@ -60,7 +58,7 @@ impl DependencyInstaller for LxdInstaller {
 
         // Wait for LXD daemon to start
         debug!("Waiting for LXD daemon to initialize");
-        thread::sleep(Duration::from_secs(15));
+        tokio::time::sleep(tokio::time::Duration::from_secs(15)).await;
 
         // Initialize LXD with default settings
         debug!("Initializing LXD with default settings");

packages/dependency-installer/src/installer/opentofu.rs

@@ -67,16 +67,27 @@ impl DependencyInstaller for OpenTofuInstaller {
             });
         }
 
-        // Make script executable
-        debug!("Making installer script executable");
-        fs::set_permissions(
-            script_path,
-            std::os::unix::fs::PermissionsExt::from_mode(0o755),
-        )
-        .map_err(|e| InstallationError::CommandFailed {
-            dependency: Dependency::OpenTofu,
-            source: e,
-        })?;
+        // Make script executable (Unix-specific)
+        #[cfg(unix)]
+        {
+            debug!("Making installer script executable");
+            fs::set_permissions(
+                script_path,
+                std::os::unix::fs::PermissionsExt::from_mode(0o755),
+            )
+            .map_err(|e| InstallationError::CommandFailed {
+                dependency: Dependency::OpenTofu,
+                source: e,
+            })?;
+        }
+
+        #[cfg(not(unix))]
+        {
+            return Err(InstallationError::InstallationFailed {
+                dependency: Dependency::OpenTofu,
+                message: "OpenTofu installation is only supported on Unix-like systems".to_string(),
+            });
+        }
 
         // Run installer with sudo
         debug!("Running OpenTofu installer with sudo");
@@ -90,8 +101,8 @@ impl DependencyInstaller for OpenTofuInstaller {
 
         if !output.status.success() {
             let stderr = String::from_utf8_lossy(&output.stderr);
-            // Clean up script before returning error
-            drop(fs::remove_file(script_path));
+            // Clean up script before returning error (ignore cleanup errors)
+            fs::remove_file(script_path).ok();
             return Err(InstallationError::InstallationFailed {
                 dependency: Dependency::OpenTofu,
                 message: format!("Installer script failed: {stderr}"),