Skip to content

Commit 4dd3cc5

Browse files
committed
docs: [#246] complete Phase 4 - add Grafana terms to dictionary and fix Clippy warnings
1 parent 607c26b commit 4dd3cc5

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

docs/issues/246-grafana-slice-release-run-commands.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -738,12 +738,13 @@ fn create_environment_from_config(config: UserInputs) -> Result<Environment, Con
738738

739739
4. **Update Project Dictionary** (`project-words.txt`):
740740

741-
- [ ] Add Grafana-related technical terms
741+
- [x] Add Grafana-related technical terms
742742

743743
5. **Final Documentation Review**:
744-
- [ ] Run markdown linter: `cargo run --bin linter markdown`
745-
- [ ] Verify all links work
746-
- [ ] Review for clarity and completeness
744+
- [x] Run markdown linter: `cargo run --bin linter markdown`
745+
- [x] Run all linters: `cargo run --bin linter all`
746+
- [x] Verify all links work
747+
- [x] Review for clarity and completeness
747748

748749
## Acceptance Criteria
749750

project-words.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ EPEL
1414
Falkenstein
1515
Gossman
1616
Graça
17+
Grafana
1718
Herberto
1819
Hillsboro
1920
Hostnames
@@ -263,6 +264,7 @@ vbqajnc
263264
viewmodel
264265
webservers
265266
writeln
267+
wrongpassword
266268
youruser
267269
zeroize
268270
Émojis

src/domain/environment/context.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ impl EnvironmentContext {
191191
/// provided working directory as the base, and allows specifying custom
192192
/// tracker, prometheus, and grafana configurations.
193193
#[must_use]
194+
#[allow(clippy::too_many_arguments)] // Public API with necessary configuration parameters
194195
pub fn with_working_dir_and_tracker(
195196
name: &EnvironmentName,
196197
provider_config: ProviderConfig,

src/domain/environment/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ impl Environment {
291291
/// tracker, prometheus, and grafana configurations.
292292
#[must_use]
293293
#[allow(clippy::needless_pass_by_value)] // Public API takes ownership for ergonomics
294+
#[allow(clippy::too_many_arguments)] // Public API with necessary configuration parameters
294295
pub fn with_working_dir_and_tracker(
295296
name: EnvironmentName,
296297
provider_config: ProviderConfig,

0 commit comments

Comments
 (0)