refactor: apply ProjectGenerator pattern to Ansible renderer

Author: josecelano

src/application/services/ansible_template_service.rs

@@ -29,7 +29,7 @@ use tracing::info;
 use crate::adapters::ssh::SshCredentials;
 use crate::application::steps::RenderAnsibleTemplatesStep;
 use crate::domain::TemplateManager;
-use crate::infrastructure::external_tools::ansible::AnsibleTemplateRenderer;
+use crate::infrastructure::external_tools::ansible::AnsibleProjectGenerator;
 
 /// Errors that can occur during Ansible template rendering
 #[derive(Error, Debug)]
@@ -57,7 +57,7 @@ pub enum AnsibleTemplateServiceError {
 /// This allows the service to be configured once and reused with different
 /// runtime parameters.
 pub struct AnsibleTemplateService {
-    ansible_template_renderer: Arc<AnsibleTemplateRenderer>,
+    ansible_template_renderer: Arc<AnsibleProjectGenerator>,
 }
 
 impl AnsibleTemplateService {
@@ -67,7 +67,7 @@ impl AnsibleTemplateService {
     ///
     /// * `ansible_template_renderer` - The renderer for Ansible templates
     #[must_use]
-    pub fn new(ansible_template_renderer: Arc<AnsibleTemplateRenderer>) -> Self {
+    pub fn new(ansible_template_renderer: Arc<AnsibleProjectGenerator>) -> Self {
         Self {
             ansible_template_renderer,
         }
@@ -103,7 +103,7 @@ impl AnsibleTemplateService {
         let template_manager = Arc::new(TemplateManager::new(templates_dir));
 
         let ansible_template_renderer =
-            Arc::new(AnsibleTemplateRenderer::new(build_dir, template_manager));
+            Arc::new(AnsibleProjectGenerator::new(build_dir, template_manager));
 
         Self::new(ansible_template_renderer)
     }

src/application/steps/rendering/ansible_templates.rs

@@ -25,12 +25,12 @@ use thiserror::Error;
 use tracing::{info, instrument};
 
 use crate::adapters::ssh::credentials::SshCredentials;
-use crate::infrastructure::external_tools::ansible::template::renderer::ConfigurationTemplateError;
+use crate::infrastructure::external_tools::ansible::template::renderer::AnsibleProjectGeneratorError;
 use crate::infrastructure::external_tools::ansible::template::wrappers::inventory::{
     AnsibleHost, AnsiblePort, AnsiblePortError, InventoryContext, InventoryContextError,
     SshPrivateKeyFile, SshPrivateKeyFileError,
 };
-use crate::infrastructure::external_tools::ansible::AnsibleTemplateRenderer;
+use crate::infrastructure::external_tools::ansible::AnsibleProjectGenerator;
 
 /// Errors that can occur during Ansible template rendering step execution
 #[derive(Error, Debug)]
@@ -49,7 +49,7 @@ pub enum RenderAnsibleTemplatesError {
 
     /// Template rendering failed
     #[error("Template rendering failed: {0}")]
-    TemplateRenderingError(#[from] ConfigurationTemplateError),
+    TemplateRenderingError(#[from] AnsibleProjectGeneratorError),
 }
 
 impl crate::shared::Traceable for RenderAnsibleTemplatesError {
@@ -82,20 +82,20 @@ impl crate::shared::Traceable for RenderAnsibleTemplatesError {
 
 /// Simple step that renders `Ansible` templates to the build directory with runtime variables
 pub struct RenderAnsibleTemplatesStep {
-    ansible_template_renderer: Arc<AnsibleTemplateRenderer>,
+    ansible_project_generator: Arc<AnsibleProjectGenerator>,
     ssh_credentials: SshCredentials,
     ssh_socket_addr: SocketAddr,
 }
 
 impl RenderAnsibleTemplatesStep {
     #[must_use]
     pub fn new(
-        ansible_template_renderer: Arc<AnsibleTemplateRenderer>,
+        ansible_project_generator: Arc<AnsibleProjectGenerator>,
         ssh_credentials: SshCredentials,
         ssh_socket_addr: SocketAddr,
     ) -> Self {
         Self {
-            ansible_template_renderer,
+            ansible_project_generator,
             ssh_credentials,
             ssh_socket_addr,
         }
@@ -122,7 +122,7 @@ impl RenderAnsibleTemplatesStep {
         let inventory_context = self.create_inventory_context()?;
 
         // Use the configuration renderer to handle all template rendering
-        self.ansible_template_renderer
+        self.ansible_project_generator
             .render(&inventory_context)
             .await?;
 

src/infrastructure/external_tools/ansible/mod.rs

@@ -11,7 +11,7 @@
 
 pub mod template;
 
-pub use template::{AnsibleTemplateRenderer, InventoryTemplateRenderer};
+pub use template::{AnsibleProjectGenerator, InventoryRenderer};
 
 /// Subdirectory name for Ansible-related files within the build directory.
 ///

src/infrastructure/external_tools/ansible/template/mod.rs

@@ -7,4 +7,4 @@
 pub mod renderer;
 pub mod wrappers;
 
-pub use renderer::{AnsibleTemplateRenderer, InventoryTemplateRenderer};
+pub use renderer::{AnsibleProjectGenerator, InventoryRenderer};

src/infrastructure/external_tools/ansible/template/renderer/inventory.rs

@@ -14,14 +14,14 @@
 //! ```rust
 //! # use std::sync::Arc;
 //! # use tempfile::TempDir;
-//! use torrust_tracker_deployer_lib::infrastructure::external_tools::ansible::template::renderer::inventory::InventoryTemplateRenderer;
+//! use torrust_tracker_deployer_lib::infrastructure::external_tools::ansible::template::renderer::inventory::InventoryRenderer;
 //! use torrust_tracker_deployer_lib::domain::template::TemplateManager;
 //! use torrust_tracker_deployer_lib::infrastructure::external_tools::ansible::template::wrappers::inventory::InventoryContext;
 //!
 //! # async fn example() -> Result<(), Box<dyn std::error::Error>> {
 //! let temp_dir = TempDir::new()?;
 //! let template_manager = Arc::new(TemplateManager::new("/path/to/templates"));
-//! let renderer = InventoryTemplateRenderer::new(template_manager);
+//! let renderer = InventoryRenderer::new(template_manager);
 //!
 //! let inventory_context = InventoryContext::builder().build()?;
 //! renderer.render(&inventory_context, temp_dir.path())?;
@@ -41,7 +41,7 @@ use crate::infrastructure::external_tools::ansible::template::wrappers::inventor
 
 /// Errors that can occur during inventory template rendering
 #[derive(Error, Debug)]
-pub enum InventoryTemplateError {
+pub enum InventoryRendererError {
     /// Failed to get template path from template manager
     #[error("Failed to get template path for '{file_name}': {source}")]
     TemplatePathFailed {
@@ -87,11 +87,11 @@ pub enum InventoryTemplateError {
 /// - Loading the inventory.yml.tera template
 /// - Processing it with runtime context (hosts, SSH keys, etc.)
 /// - Rendering the final inventory.yml file for Ansible consumption
-pub struct InventoryTemplateRenderer {
+pub struct InventoryRenderer {
     template_manager: Arc<TemplateManager>,
 }
 
-impl InventoryTemplateRenderer {
+impl InventoryRenderer {
     /// Template filename for the inventory Tera template
     const INVENTORY_TEMPLATE_FILE: &'static str = "inventory.yml.tera";
 
@@ -137,29 +137,29 @@ impl InventoryTemplateRenderer {
         &self,
         inventory_context: &InventoryContext,
         output_dir: &Path,
-    ) -> Result<(), InventoryTemplateError> {
+    ) -> Result<(), InventoryRendererError> {
         tracing::debug!("Rendering inventory template with runtime variables");
 
         // Get the inventory template path
         let inventory_template_path = self
             .template_manager
             .get_template_path(&Self::build_template_path())
-            .map_err(|source| InventoryTemplateError::TemplatePathFailed {
+            .map_err(|source| InventoryRendererError::TemplatePathFailed {
                 file_name: Self::INVENTORY_TEMPLATE_FILE.to_string(),
                 source,
             })?;
 
         // Read template content
         let inventory_template_content = std::fs::read_to_string(&inventory_template_path)
-            .map_err(|source| InventoryTemplateError::TeraTemplateReadFailed {
+            .map_err(|source| InventoryRendererError::TeraTemplateReadFailed {
                 file_name: Self::INVENTORY_TEMPLATE_FILE.to_string(),
                 source,
             })?;
 
         // Create File object for template processing
         let inventory_template_file =
             File::new(Self::INVENTORY_TEMPLATE_FILE, inventory_template_content).map_err(
-                |source| InventoryTemplateError::FileCreationFailed {
+                |source| InventoryRendererError::FileCreationFailed {
                     file_name: Self::INVENTORY_TEMPLATE_FILE.to_string(),
                     source,
                 },
@@ -168,14 +168,14 @@ impl InventoryTemplateRenderer {
         // Create InventoryTemplate with runtime context
         let inventory_template =
             InventoryTemplate::new(&inventory_template_file, inventory_context.clone()).map_err(
-                |source| InventoryTemplateError::InventoryTemplateCreationFailed { source },
+                |source| InventoryRendererError::InventoryTemplateCreationFailed { source },
             )?;
 
         // Render to output file
         let inventory_output_path = output_dir.join(Self::INVENTORY_OUTPUT_FILE);
         inventory_template
             .render(&inventory_output_path)
-            .map_err(|source| InventoryTemplateError::InventoryTemplateRenderFailed { source })?;
+            .map_err(|source| InventoryRendererError::InventoryTemplateRenderFailed { source })?;
 
         tracing::debug!(
             "Successfully rendered inventory template to {}",
@@ -252,7 +252,7 @@ mod tests {
         let temp_dir = TempDir::new().expect("Failed to create temp directory");
         let template_manager = Arc::new(TemplateManager::new(temp_dir.path()));
 
-        let renderer = InventoryTemplateRenderer::new(template_manager.clone());
+        let renderer = InventoryRenderer::new(template_manager.clone());
 
         assert!(Arc::ptr_eq(&renderer.template_manager, &template_manager));
     }
@@ -261,9 +261,9 @@ mod tests {
     fn it_should_build_correct_template_path() {
         let temp_dir = TempDir::new().expect("Failed to create temp directory");
         let template_manager = Arc::new(TemplateManager::new(temp_dir.path()));
-        let _renderer = InventoryTemplateRenderer::new(template_manager);
+        let _renderer = InventoryRenderer::new(template_manager);
 
-        let template_path = InventoryTemplateRenderer::build_template_path();
+        let template_path = InventoryRenderer::build_template_path();
 
         assert_eq!(template_path, "ansible/inventory.yml.tera");
     }
@@ -284,7 +284,7 @@ mod tests {
             .ensure_templates_dir()
             .expect("Failed to ensure templates directory");
 
-        let renderer = InventoryTemplateRenderer::new(template_manager);
+        let renderer = InventoryRenderer::new(template_manager);
         let inventory_context = create_test_inventory_context(temp_dir.path());
 
         // Render template
@@ -339,7 +339,7 @@ mod tests {
             .ensure_templates_dir()
             .expect("Failed to ensure templates directory");
 
-        let renderer = InventoryTemplateRenderer::new(template_manager);
+        let renderer = InventoryRenderer::new(template_manager);
         let inventory_context = create_test_inventory_context(temp_dir.path());
 
         let result = renderer.render(&inventory_context, &output_dir);
@@ -349,7 +349,7 @@ mod tests {
             "Should fail when template references non-existent context field"
         );
         match result.unwrap_err() {
-            InventoryTemplateError::InventoryTemplateCreationFailed { .. } => {
+            InventoryRendererError::InventoryTemplateCreationFailed { .. } => {
                 // Expected error type when template engine fails to process template
             }
             other => panic!("Expected InventoryTemplateCreationFailed, got: {other:?}"),
@@ -379,7 +379,7 @@ mod tests {
             .ensure_templates_dir()
             .expect("Failed to ensure templates directory");
 
-        let renderer = InventoryTemplateRenderer::new(template_manager);
+        let renderer = InventoryRenderer::new(template_manager);
         let inventory_context = create_test_inventory_context(temp_dir.path());
 
         let result = renderer.render(&inventory_context, &output_dir);
@@ -388,7 +388,7 @@ mod tests {
         // The exact error type will depend on the template engine's error handling
         assert!(matches!(
             result.unwrap_err(),
-            InventoryTemplateError::InventoryTemplateCreationFailed { .. }
+            InventoryRendererError::InventoryTemplateCreationFailed { .. }
         ));
     }
 
@@ -414,7 +414,7 @@ mod tests {
             .ensure_templates_dir()
             .expect("Failed to ensure templates directory");
 
-        let renderer = InventoryTemplateRenderer::new(template_manager);
+        let renderer = InventoryRenderer::new(template_manager);
         let inventory_context = create_test_inventory_context(temp_dir.path());
 
         let result = renderer.render(&inventory_context, &output_dir);
@@ -424,7 +424,7 @@ mod tests {
             "Should fail when output directory is read-only"
         );
         match result.unwrap_err() {
-            InventoryTemplateError::InventoryTemplateRenderFailed { .. } => {
+            InventoryRendererError::InventoryTemplateRenderFailed { .. } => {
                 // Expected error type
             }
             other => panic!("Expected InventoryTemplateRenderFailed, got: {other:?}"),