refactor: implement TestContext with Environment field encapsulation

- Add Environment field to TestContext with private constructor pattern
- Implement explicit .init() method for TestContext initialization
- Add hardcoded environment names per binary (e2e-config, e2e-provision, e2e-full)
- Create environment-specific directory structure for test isolation
- Fix SSH key paths to use absolute paths preventing permission errors
- Update all E2E binaries to use refactored TestContext pattern

This refactoring enables proper test environment isolation by ensuring
each E2E test binary creates its own environment-specific directories
and uses distinct environment identifiers.

Author: josecelano

docs/issues/multi-environment-support.md

@@ -158,29 +158,41 @@ Each binary now:
 **Example for e2e_config_tests.rs**:
 
 ```rust
+let env_name = EnvironmentName::new("e2e-config".to_string())?;
+let ssh_user = Username::new("torrust")?;
 let environment = Environment::new(
-    EnvironmentName::new("e2e-config".to_string())?,
+    env_name,
+    ssh_user,
     ssh_private_key_path,
     ssh_public_key_path,
 );
 
-let test_context = TestContext::initialized(
+let test_context = TestContext::from_environment(
     false,
     environment,
-    &ssh_user,
     TestContextType::Container,
-)?;
+)?.init()?;
 ```
 
-### Step 5: Update TestContext
+### Step 5: Update TestContext ✅ COMPLETED
 
 **Location**: `src/e2e/context.rs`
 
 **Requirements**:
 
-- Replace individual parameters with Environment entity
-- Maintain backward compatibility during transition
-- Update all dependent code
+- ✅ Replace individual parameters with Environment entity
+- ✅ Add Environment as a field in TestContext struct
+- ✅ Rename `initialized` to private `new` method
+- ✅ Make `init` method public for explicit initialization
+- ✅ Update all dependent code
+
+**Implementation Summary**:
+
+- Added `environment: Environment` field to TestContext struct
+- Renamed `TestContext::initialized` → `TestContext::new` (private)
+- Made `TestContext::init()` public with ownership transfer pattern
+- Updated all E2E binaries to use `.init()` explicitly
+- Updated documentation examples and comments
 
 **Key Changes**:
 

src/bin/e2e_config_tests.rs

@@ -16,9 +16,6 @@
 //! Run with custom options:
 //!
 //! ```bash
-//! # Use specific environment name
-//! cargo run --bin e2e-config-tests -- --environment e2e-staging
-//!
 //! # Change logging format  
 //! cargo run --bin e2e-config-tests -- --log-format json
 //!
@@ -67,10 +64,6 @@ use torrust_tracker_deploy::shared::Username;
 #[command(name = "e2e-config-tests")]
 #[command(about = "E2E configuration tests for Torrust Tracker Deploy using Docker containers")]
 struct CliArgs {
-    /// Environment name for deployment testing (e.g., "e2e-config", "staging"). This determines the instance name and directory structure.
-    #[arg(long, default_value = "e2e-config")]
-    environment: String,
-
     /// Logging format to use
     #[arg(
         long,
@@ -106,39 +99,32 @@ pub async fn main() -> Result<()> {
     info!(
         application = "torrust_tracker_deploy",
         test_suite = "e2e_config_tests",
-        environment = %cli.environment,
         log_format = ?cli.log_format,
         "Starting E2E configuration tests with Docker containers"
     );
 
     let test_start = Instant::now();
 
-    // Create Environment entity from CLI argument
-    let env_name = EnvironmentName::new(&cli.environment)
-        .map_err(|e| anyhow::anyhow!("Invalid environment name '{}': {}", cli.environment, e))?;
+    // Create Environment entity with hardcoded name for this binary
+    let env_name =
+        EnvironmentName::new("e2e-config").expect("Hardcoded environment name should be valid");
 
-    let ssh_private_key_path = std::path::PathBuf::from("fixtures/testing_rsa");
-    let ssh_public_key_path = std::path::PathBuf::from("fixtures/testing_rsa.pub");
+    // Use absolute paths to project root for SSH keys to ensure they can be found by Ansible
+    let project_root = std::env::current_dir().expect("Failed to get current directory");
+    let ssh_private_key_path = project_root.join("fixtures/testing_rsa");
+    let ssh_public_key_path = project_root.join("fixtures/testing_rsa.pub");
+    let ssh_user = Username::new("torrust").expect("Valid hardcoded username");
 
     let environment = Environment::new(
         env_name,
+        ssh_user.clone(),
         ssh_private_key_path.clone(),
         ssh_public_key_path.clone(),
     );
 
-    let ssh_user = Username::new("torrust").expect("Valid hardcoded username");
-
-    // Extract values from Environment entity for TestContext
-    // TODO: Update TestContext to accept Environment entity directly
-    let test_context = TestContext::initialized(
-        false,
-        environment.templates_dir(),
-        &ssh_user,
-        environment.instance_name.clone(),
-        ssh_private_key_path,
-        ssh_public_key_path,
-        TestContextType::Container,
-    )?;
+    // Create and initialize TestContext
+    let test_context =
+        TestContext::from_environment(false, environment, TestContextType::Container)?.init()?;
 
     preflight_cleanup::cleanup_lingering_resources(&test_context)?;
 

src/bin/e2e_provision_tests.rs

@@ -16,9 +16,6 @@
 //! Run with custom options:
 //!
 //! ```bash
-//! # Use specific environment name
-//! cargo run --bin e2e-provision-tests -- --environment e2e-staging
-//!
 //! # Keep test environment after completion (for debugging)
 //! cargo run --bin e2e-provision-tests -- --keep
 //!
@@ -66,10 +63,6 @@ struct Cli {
     #[arg(long)]
     keep: bool,
 
-    /// Environment name for deployment testing (e.g., "e2e-provision", "staging"). This determines the instance name and directory structure.
-    #[arg(long, default_value = "e2e-provision")]
-    environment: String,
-
     /// Logging format to use
     #[arg(
         long,
@@ -117,27 +110,25 @@ pub async fn main() -> Result<()> {
         "Starting E2E provisioning tests"
     );
 
-    // Create environment entity from CLI input
-    let environment_name = EnvironmentName::new(cli.environment)?;
-    let ssh_private_key_path = std::path::PathBuf::from("fixtures/testing_rsa");
-    let ssh_public_key_path = std::path::PathBuf::from("fixtures/testing_rsa.pub");
+    // Create environment entity for e2e-provision testing
+    let environment_name = EnvironmentName::new("e2e-provision".to_string())?;
+
+    // Use absolute paths to project root for SSH keys to ensure they can be found by Ansible
+    let project_root = std::env::current_dir().expect("Failed to get current directory");
+    let ssh_private_key_path = project_root.join("fixtures/testing_rsa");
+    let ssh_public_key_path = project_root.join("fixtures/testing_rsa.pub");
+    let ssh_user = Username::new("torrust").expect("Valid hardcoded username");
+
     let environment = Environment::new(
         environment_name,
+        ssh_user.clone(),
         ssh_private_key_path.clone(),
         ssh_public_key_path.clone(),
     );
 
-    let ssh_user = Username::new("torrust").expect("Valid hardcoded username");
-
-    let test_context = TestContext::initialized(
-        cli.keep,
-        environment.data_dir.to_string_lossy().to_string(),
-        &ssh_user,
-        environment.instance_name.clone(),
-        ssh_private_key_path,
-        ssh_public_key_path,
-        TestContextType::VirtualMachine,
-    )?;
+    let test_context =
+        TestContext::from_environment(cli.keep, environment, TestContextType::VirtualMachine)?
+            .init()?;
 
     // Perform pre-flight cleanup to remove any lingering resources from interrupted tests
     cleanup_lingering_resources(&test_context)?;

src/bin/e2e_tests_full.rs

@@ -73,10 +73,6 @@ struct Cli {
     #[arg(long)]
     keep: bool,
 
-    /// Environment name for deployment testing (e.g., "e2e-full", "staging"). This determines the instance name and directory structure.
-    #[arg(long, default_value = "e2e-full")]
-    environment: String,
-
     /// Logging format to use
     #[arg(
         long,
@@ -119,27 +115,25 @@ pub async fn main() -> Result<()> {
         "Starting E2E tests"
     );
 
-    // Create environment entity from CLI input
-    let environment_name = EnvironmentName::new(cli.environment)?;
-    let ssh_private_key_path = std::path::PathBuf::from("fixtures/testing_rsa");
-    let ssh_public_key_path = std::path::PathBuf::from("fixtures/testing_rsa.pub");
+    // Create environment entity for e2e-full testing
+    let environment_name = EnvironmentName::new("e2e-full".to_string())?;
+
+    // Use absolute paths to project root for SSH keys to ensure they can be found by Ansible
+    let project_root = std::env::current_dir().expect("Failed to get current directory");
+    let ssh_private_key_path = project_root.join("fixtures/testing_rsa");
+    let ssh_public_key_path = project_root.join("fixtures/testing_rsa.pub");
+    let ssh_user = Username::new("torrust").expect("Valid hardcoded username");
+
     let environment = Environment::new(
         environment_name,
+        ssh_user.clone(),
         ssh_private_key_path.clone(),
         ssh_public_key_path.clone(),
     );
 
-    let ssh_user = Username::new("torrust").expect("Valid hardcoded username");
-
-    let test_context = TestContext::initialized(
-        cli.keep,
-        environment.data_dir.to_string_lossy().to_string(),
-        &ssh_user,
-        environment.instance_name.clone(),
-        ssh_private_key_path,
-        ssh_public_key_path,
-        TestContextType::VirtualMachine,
-    )?;
+    let test_context =
+        TestContext::from_environment(cli.keep, environment, TestContextType::VirtualMachine)?
+            .init()?;
 
     // Perform pre-flight cleanup to remove any lingering resources from interrupted tests
     cleanup_lingering_resources(&test_context)?;